Slab allocators: Remove support for kmem_cache_name()

PATCH Christoph Lameter 1 participant 1 message Jan 20, 2011 5 messages not in the archive

Subsystems (2)

Memory management Slab allocator

lore

Share & tools

lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Christoph Lameter

author

2011-01-20 17:12 UTC #5 lore raw

Quoted 5 lines · Eric Sandeen

Quoted 4 lines · Christoph Lameter
Quoted 1 line · Eric Sandeen
I did send a patch yesterday to stop the evil-ness ;)

Quoted 8 lines

Quoted 1 line
Can you give me an URL to that patch? CC me next time.
Sure, sorry, didn't think of it, was in "ext4-is-broken" mode.
Rather than fix up accounting I just made ext4 allocate the slab with a static name like everyone else.
http://marc.info/?l=linux-ext4&m=129546975702198&w=2

Subject: Slab allocators: Remove support for kmem_cache_name()

The last user was ext4 and Eric Sandeen removed the call in a recent patch.

Signed-off-by Christoph Lameter <[email protected]>

---
 include/linux/slab.h |    1 -
 mm/slab.c            |    8 --------
 mm/slob.c            |    6 ------
 mm/slub.c            |    6 ------
 4 files changed, 21 deletions(-)

include/linux/slab.h +0 -1

Index: linux-2.6/include/linux/slab.h
===================================================================
@@ -105,7 +105,6 @@ void kmem_cache_destroy(struct kmem_cach
 int kmem_cache_shrink(struct kmem_cache *);
 void kmem_cache_free(struct kmem_cache *, void *);
 unsigned int kmem_cache_size(struct kmem_cache *);
-const char *kmem_cache_name(struct kmem_cache *);
 
 /*
  * Please use this macro to create slab caches. Simply specify the

mm/slab.c +0 -8

Index: linux-2.6/mm/slab.c
===================================================================
@@ -2147,8 +2147,6 @@ static int __init_refok setup_cpu_cache(
  *
  * @name must be valid until the cache is destroyed. This implies that
  * the module calling this has to destroy the cache before getting unloaded.
- * Note that kmem_cache_name() is not guaranteed to return the same pointer,
- * therefore applications must manage it themselves.
  *
  * The flags are
  *

@@ -3840,12 +3838,6 @@ unsigned int kmem_cache_size(struct kmem
 }
 EXPORT_SYMBOL(kmem_cache_size);
 
-const char *kmem_cache_name(struct kmem_cache *cachep)
-{
-	return cachep->name;
-}
-EXPORT_SYMBOL_GPL(kmem_cache_name);
-
 /*
  * This initializes kmem_list3 or resizes various caches for all nodes.
  */

mm/slob.c +0 -6

Index: linux-2.6/mm/slob.c
===================================================================
@@ -666,12 +666,6 @@ unsigned int kmem_cache_size(struct kmem
 }
 EXPORT_SYMBOL(kmem_cache_size);
 
-const char *kmem_cache_name(struct kmem_cache *c)
-{
-	return c->name;
-}
-EXPORT_SYMBOL(kmem_cache_name);
-
 int kmem_cache_shrink(struct kmem_cache *d)
 {
 	return 0;

mm/slub.c +0 -6

Index: linux-2.6/mm/slub.c
===================================================================
@@ -2399,12 +2399,6 @@ unsigned int kmem_cache_size(struct kmem
 }
 EXPORT_SYMBOL(kmem_cache_size);
 
-const char *kmem_cache_name(struct kmem_cache *s)
-{
-	return s->name;
-}
-EXPORT_SYMBOL(kmem_cache_name);
-
 static void list_slab_objects(struct kmem_cache *s, struct page *page,
 							const char *text)
 {

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>