Skip to contentSkip to conversation

hid kernel module for wireless remote LC Power model RC1000MCE

PATCH Applied Chris Schlund 2 participants 4 messages Jan 26, 2011 – Feb 13, 2011 HID

lore
Share & tools
lore

Chris Schlund

author
#0 lore raw

Hi Jiri,

Quoted 3 lines
Quoted 3 lines

First, I am missing your Signed-off-by: line, without which I can't apply your driver. Please see Documentation/SubmittingPatches for details.. Second, your mailer has damaged (line-wrapped) the patch..
Also, we are not going the EMBEDDED path any more (see commit 73d5e8f77e88a4 for explanation).

I attached the newly prepared patch with removed EMBEDDED path and hopefully without line-wrap. I also added the Signed-off-by line.

Thanks,
Chris

Signed-off-by Chris Schlund <[email protected]>

---

drivers/hid/hid-core.c +1 -0
diff -uprN linux-2.6.37/drivers/hid/hid-core.c linux/drivers/hid/hid-core.c
@@ -1312,6 +1312,7 @@ static const struct hid_device_id hid_bl
 	{ HID_USB_DEVICE(USB_VENDOR_ID_KENSINGTON, USB_DEVICE_ID_KS_SLIMBLADE) },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_KYE, USB_DEVICE_ID_KYE_ERGO_525V) },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_LABTEC, USB_DEVICE_ID_LABTEC_WIRELESS_KEYBOARD) },
+	{ HID_USB_DEVICE(USB_VENDOR_ID_LCPOWER, USB_DEVICE_ID_LCPOWER_LC1000 ) },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_MX3000_RECEIVER) },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_S510_RECEIVER) },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_S510_RECEIVER_2) },
drivers/hid/hid-ids.h +3 -0
diff -uprN linux-2.6.37/drivers/hid/hid-ids.h linux/drivers/hid/hid-ids.h
@@ -330,6 +330,9 @@
 #define USB_VENDOR_ID_LABTEC		0x1020
 #define USB_DEVICE_ID_LABTEC_WIRELESS_KEYBOARD	0x0006
 
+#define USB_VENDOR_ID_LCPOWER		0x1241
+#define USB_DEVICE_ID_LCPOWER_LC1000	0xf767
+
 #define USB_VENDOR_ID_LD		0x0f11
 #define USB_DEVICE_ID_LD_CASSY		0x1000
 #define USB_DEVICE_ID_LD_POCKETCASSY	0x1010
drivers/hid/hid-lcpower.c +70 -0

70 lines not on this page · raw message

drivers/hid/Kconfig +6 -0
diff -uprN linux-2.6.37/drivers/hid/Kconfig linux/drivers/hid/Kconfig
@@ -207,6 +207,12 @@ config HID_KENSINGTON
 	---help---
 	Support for Kensington Slimblade Trackball.
 
+config HID_LCPOWER
+	tristate "LC-Power"
+	depends on USB_HID
+	---help---
+	Support for LC-Power RC1000MCE RF remote control.
+
 config HID_LOGITECH
 	tristate "Logitech devices" if EMBEDDED
 	depends on USB_HID
drivers/hid/Makefile +1 -0
diff -uprN linux-2.6.37/drivers/hid/Makefile linux/drivers/hid/Makefile
@@ -41,6 +41,7 @@ obj-$(CONFIG_HID_EZKEY)		+= hid-ezkey.o
 obj-$(CONFIG_HID_GYRATION)	  += hid-gyration.o
 obj-$(CONFIG_HID_KENSINGTON)	  += hid-kensington.o
 obj-$(CONFIG_HID_KYE)		  += hid-kye.o
+obj-$(CONFIG_HID_LCPOWER)	  += hid-lcpower.o
 obj-$(CONFIG_HID_LOGITECH)	  += hid-logitech.o
 obj-$(CONFIG_HID_MAGICMOUSE)     += hid-magicmouse.o
 obj-$(CONFIG_HID_MICROSOFT)	  += hid-microsoft.o
Applied
#1 lore raw
Quoted 8 lines · Chris Schlund

Hi Jiri,

Quoted 3 lines
Quoted 3 lines

First, I am missing your Signed-off-by: line, without which I can't apply your driver. Please see Documentation/SubmittingPatches for details.. Second, your mailer has damaged (line-wrapped) the patch..
Also, we are not going the EMBEDDED path any more (see commit 73d5e8f77e88a4 for explanation).

I attached the newly prepared patch with removed EMBEDDED path and hopefully without line-wrap. I also added the Signed-off-by line.

Applied, thanks Chris.

Oh, how I wish we move all this mapping stuff to udev as soon as possible
...

Signature · 2 lines
Jiri Kosina
SUSE Labs, Novell Inc.
author
#2 lore raw

Hi Jiri,

I already got some feedback for this module, telling me red and blue keys are exchanged. I checked it, and they are right. Due to my incorrect userspace settings I missed this during my testing. So here is the fixed mapping.
I am sorry for the inconvenience.

Thanks, Chris

Signed-off-by Chris Schlund <[email protected]>

---

drivers/hid/hid-lcpower.c 2011-02-07 17:32:50.000000000 +0100 renamed from drivers/hid/hid-lcpower.c 2011-02-07 17:31:49.000000000 +0100 +2 -2
diff -urN linux-2.6.37/drivers/hid/hid-lcpower.c linux/drivers/hid/hid-lcpower.c
@@ -30,8 +30,8 @@
        switch (usage->hid & HID_USAGE) {
        case 0x046: ts_map_key_clear(KEY_YELLOW);         break;
        case 0x047: ts_map_key_clear(KEY_GREEN);          break;
-        case 0x049: ts_map_key_clear(KEY_RED);            break;
-        case 0x04a: ts_map_key_clear(KEY_BLUE);           break;
+        case 0x04a: ts_map_key_clear(KEY_RED);            break;
+        case 0x049: ts_map_key_clear(KEY_BLUE);           break;
        case 0x00d: ts_map_key_clear(KEY_HOME);           break;
        case 0x025: ts_map_key_clear(KEY_TV);             break;
        case 0x048: ts_map_key_clear(KEY_VCR);            break;
#3 lore raw
Quoted 17 lines · Chris Schlund

Hi Jiri,

I already got some feedback for this module, telling me red and blue keys are exchanged. I checked it, and they are right. Due to my incorrect userspace settings I missed this during my testing. So here is the fixed mapping.
I am sorry for the inconvenience.

Thanks, Chris

Signed-off-by Chris Schlund <[email protected]>

---

diff -urN linux-2.6.37/drivers/hid/hid-lcpower.c linux/drivers/hid/hid-lcpower.c

drivers/hid/hid-lcpower.c 2011-02-07 17:32:50.000000000 +0100 line 34

Quoted 7 lines
drivers/hid/hid-lcpower.c 2011-02-07 17:32:50.000000000 +0100 renamed from drivers/hid/hid-lcpower.c 2011-02-07 17:31:49.000000000 +0100 +2 -2
@@ -30,8 +30,8 @@
        switch (usage->hid & HID_USAGE) {
        case 0x046: ts_map_key_clear(KEY_YELLOW);         break;
        case 0x047: ts_map_key_clear(KEY_GREEN);          break;
-        case 0x049: ts_map_key_clear(KEY_RED);            break;
-        case 0x04a: ts_map_key_clear(KEY_BLUE);           break;
+        case 0x04a: ts_map_key_clear(KEY_RED);            break;
+        case 0x049: ts_map_key_clear(KEY_BLUE);           break;

We'd rather keep the numbers sorted. Plus your patch has been whitespace-damaged by your mail-client.

I have fixed both things and applied. Please fix your mail client for further patch submissions.

Thanks,

Signature · 2 lines
Jiri Kosina
SUSE Labs, Novell Inc.