xl: fix xl cpupool-list <poolid>

Hi,

the help screen of xl cpupool-list promises to allow a CPU pool to be named on the command line, which will then be listed only. Probably caused by a "DeMorgan brain twist" this specific CPU pool is _omitted_ instead. The patch fixes this, so single CPU pools can be explicitly listed again.

Regards,
Andre.

Andre Przywara
AMD-Operating System Research Center (OSRC), Dresden, Germany

commit 94738f94d02714624a6aa1a66b3af23cc7941ef3

Author: Andre Przywara <[email protected]>
Date:   Thu Jan 27 23:55:40 2011 +0100

fix xl cpupool-list <poolid>

The help screen of cpupool-list promises to allow a CPU pool to be named on the command line, which will then be listed only. Probably caused by a "DeMorgan brain twist" this specific CPU pool is _omitted_ instead. The patch fixes this, so single CPU pools can be explicitly listed again.

index e0aa93d..6341767 100644
@@ -5427,7 +5427,7 @@ int main_cpupoollist(int argc, char **argv)
         printf("CPUs   Sched     Active   Domain count\n");
 
     for (p = 0; p < n_pools; p++) {
-        if (!ret && (!pool || (poolinfo[p].poolid != poolid))) {
+        if (!ret && (!pool || (poolinfo[p].poolid == poolid))) {
             name = libxl_cpupoolid_to_name(&ctx, poolinfo[p].poolid);
             if (!name) {
                 fprintf(stderr, "error getting cpupool info\n");

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel

Nice catch!

Juergen Gross                 Principal Developer Operating Systems
TSP ES&S SWE OS6                       Telephone: +49 (0) 89 3222 2967
Fujitsu Technology Solutions              e-mail: [email protected]
Domagkstr. 28                           Internet: ts.fujitsu.com
D-80807 Muenchen                 Company details: ts.fujitsu.com/imprint.html

Juergen Gross writes ("Re: [Xen-devel] [PATCH] xl: fix xl cpupool-list <poolid>"):

Thanks, applied.

Ian.