Skip to contentSkip to conversation

Kconfig: XIP doesn't depend on block

PATCH In review Marco Stornelli 2 participants 3 messages Feb 6, 2011 – Feb 7, 2011 VFS

lore
Share & tools
lore

Marco Stornelli

author
#0 lore raw

PATCH 1/1 Kconfig: XIP doesn't depend on block

From: Marco Stornelli <[email protected]>

XIP doesn't depend on block symbol, then we can reorder the Kconfig. For ext2 doesn't change the Kconfig behavior but if other fs will use FS_XIP it won't need to include block support if not needed.

Signed-off-by Marco Stornelli <[email protected]>

---

Kconfig renamed from Kconfig.orig +6 -7
@@ -9,13 +9,6 @@ if BLOCK
 source "fs/ext2/Kconfig"
 source "fs/ext3/Kconfig"
 source "fs/ext4/Kconfig"
-
-config FS_XIP
-# execute in place
-	bool
-	depends on EXT2_FS_XIP
-	default y
-
 source "fs/jbd/Kconfig"
 source "fs/jbd2/Kconfig"
 

@@ -38,6 +31,12 @@ source "fs/nilfs2/Kconfig"
 
 endif # BLOCK
 
+config FS_XIP
+# execute in place
+	bool
+	depends on EXT2_FS_XIP
+	default y
+
 # Posix ACL utility routines
 #
 # Note: Posix ACLs can be implemented without these helpers.  Never use
#1 lore raw
Quoted 5 lines · On Sun, 06 Feb 2011 16:15:00 +0100 Marco Stornelli wrote:

From: Marco Stornelli <[email protected]>

XIP doesn't depend on block symbol, then we can reorder the Kconfig. For ext2 doesn't change the Kconfig behavior but if other fs will use FS_XIP it won't need to include block support if not needed.

Hi Marco,

Do you know of a filesystem where this matters?

Kconfig

Quoted 5 lines
Signed-off-by Marco Stornelli <[email protected]>

---

Kconfig renamed from Kconfig.orig +0 -0

This filename should include path, like
--- fs/Kconfig.orig
+++ fs/Kconfig

Kconfig if BLOCK · line 12

Quoted 5 lines
Kconfig renamed from Kconfig.orig +0 -1
@@ -9,13 +9,6 @@ if BLOCK
 source "fs/ext2/Kconfig"
 source "fs/ext3/Kconfig"
 source "fs/ext4/Kconfig"
-

The 3 filesystems above are immediately under:

if BLOCK

so ext[234] depend on BLOCK. Why would it matter about FS_XIP?

I don't object to the patch if FS_XIP builds/works without BLOCK being enabled.

Quoted 13 lines
Kconfig renamed from Kconfig.orig +0 -6
-config FS_XIP
-# execute in place
-	bool
-	depends on EXT2_FS_XIP
-	default y
-
 source "fs/jbd/Kconfig"
 source "fs/jbd2/Kconfig"
 

@@ -38,6 +31,12 @@ source "fs/nilfs2/Kconfig"
 
 endif # BLOCK

Kconfig source "fs/nilfs2/Kconfig" · line 42

Quoted 10 lines
Kconfig renamed from Kconfig.orig +6 -0
 
+config FS_XIP
+# execute in place
+	bool
+	depends on EXT2_FS_XIP
+	default y
+
 # Posix ACL utility routines
 #
 # Note: Posix ACLs can be implemented without these helpers.  Never use

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

author
#2 lore raw

2011/2/6 Randy Dunlap <[email protected]>:

Quoted 12 lines · On Sun, 06 Feb 2011 16:15:00 +0100 Marco Stornelli wrote:
Quoted 6 lines

From: Marco Stornelli <[email protected]>

XIP doesn't depend on block symbol, then we can reorder the Kconfig. For ext2 doesn't change the Kconfig behavior but if other fs will use FS_XIP it won't need to include block support if not needed.

Hi Marco,

Do you know of a filesystem where this matters?

Yes, for example mine (pramfs) :)

Quoted 18 lines

Kconfig   2011-02-06 16:04:51.000000000 +0100

Quoted 5 lines
Signed-off-by Marco Stornelli <[email protected]>

---

Kconfig   2011-02-06 16:04:51.000000000 +0100 renamed from Kconfig.orig      2011-01-19 00:14:02.000000000 +0100 +0 -0

This filename should include path, like

Kconfig renamed from Kconfig.orig +0 -0
Quoted 6 lines
Kconfig   2011-02-06 16:04:51.000000000 +0100 renamed from Kconfig.orig      2011-01-19 00:14:02.000000000 +0100 +0 -0
@@ -9,13 +9,6 @@ if BLOCK

 source "fs/ext2/Kconfig"
 source "fs/ext3/Kconfig"
 source "fs/ext4/Kconfig"
-

The 3 filesystems above are immediately under:

Quoted 4 lines

if BLOCK

so ext[234] depend on BLOCK.  Why would it matter about FS_XIP?

I don't know but for example even POSIX ACL was under "if BLOCK", maybe there is only an historical refuse.

Marco