Skip to contentSkip to conversation

fused X86_UP_APIC and X86_UP_IOAPIC ?

DISCUSSION Henrik Kretzschmar 3 participants 3 messages Feb 10, 2011 – Feb 12, 2011

lore
Share & tools
lore
#0 lore raw

Hi there,

In commit 7cd92366a593246650cc7d6198e2c7d3af8c1d8a (x86/Voyager: remove APIC/IO-APIC Kbuild quirk / just before 2.6.29-rc4) Ingo replaced the X86_UP_IOAPIC with X86_UP_APIC.

Was this intended ord by accident?

Greets,
Henrik Kretzschmar

#1 lore raw
Quoted 7 lines · Henrik Kretzschmar

Hi there,

In commit 7cd92366a593246650cc7d6198e2c7d3af8c1d8a (x86/Voyager: remove APIC/IO-APIC Kbuild quirk / just before 2.6.29-rc4) Ingo replaced the X86_UP_IOAPIC with X86_UP_APIC.

Was this intended or by accident?

Looks accidental. Wondering why it didn't cause problems. Mind sending a patch against the latest x86 tree:

http://people.redhat.com/mingo/tip.git/README

Thanks,

Ingo

#2 lore raw
In reply to Henrik Kretzschmar

Am 10.02.2011 11:35, schrieb Henrik Kretzschmar:

Quoted 4 lines
Quoted 4 lines

In commit 7cd92366a593246650cc7d6198e2c7d3af8c1d8a (x86/Voyager: remove APIC/IO-APIC Kbuild quirk / just before 2.6.29-rc4) Ingo replaced the X86_UP_IOAPIC with X86_UP_APIC.

Was this intended ord by accident?

Quoted 1 line · Ingo Molnar

Mind sending a patch against the latest x86 tree.

Yes, I do, but just changing the config makes the compilation break, so some prior steps are needed, since X86_APIC and X86_IO_APIC have fused a bit too much.

But I'm confident.

Greets,
Henrik