Skip to contentSkip to conversation

kvm,async_pf: add missing kvm_async_pf_hash_reset()

PATCH Applied Lai Jiangshan 3 participants 4 messages Feb 21, 2011 – Feb 27, 2011

Subsystems (3)
x86 KVM KVM x86
lore
Share & tools
lore

Lai Jiangshan

author
#0 lore raw

PATCH 1/1 kvm,async_pf: add missing kvm_async_pf_hash_reset()

The hash array of async gfns may still contain some left gfns after kvm_clear_async_pf_completion_queue() called, need to clear them.

arch/x86/kvm/x86.c +3 -1
index 17af71d..dae2d15 100644
@@ -525,8 +525,10 @@ int kvm_set_cr0(struct kvm_vcpu *vcpu, unsigned long cr0)
 
 	kvm_x86_ops->set_cr0(vcpu, cr0);
 
-	if ((cr0 ^ old_cr0) & X86_CR0_PG)
+	if ((cr0 ^ old_cr0) & X86_CR0_PG) {
 		kvm_clear_async_pf_completion_queue(vcpu);
+		kvm_async_pf_hash_reset(vcpu);
+	}
 
 	if ((cr0 ^ old_cr0) & update_bits)
 		kvm_mmu_reset_context(vcpu);
author
#1 lore raw
Quoted 4 lines · Lai Jiangshan

The hash array of async gfns may still contain some left gfns after kvm_clear_async_pf_completion_queue() called, need to clear them.

sorry.

Signed-off-by Lai Jiangshan <[email protected]>
Quoted 21 lines
arch/x86/kvm/x86.c +3 -2
index 17af71d..dae2d15 100644
@@ -525,8 +525,10 @@ int kvm_set_cr0(struct kvm_vcpu *vcpu, unsigned long cr0)
 
 	kvm_x86_ops->set_cr0(vcpu, cr0);
 
-	if ((cr0 ^ old_cr0) & X86_CR0_PG)
+	if ((cr0 ^ old_cr0) & X86_CR0_PG) {
 		kvm_clear_async_pf_completion_queue(vcpu);
+		kvm_async_pf_hash_reset(vcpu);
+	}
 
 	if ((cr0 ^ old_cr0) & update_bits)
 		kvm_mmu_reset_context(vcpu);
--

To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Acked-by
#2 lore raw
Quoted 10 lines · Lai Jiangshan
Quoted 4 lines · Lai Jiangshan

The hash array of async gfns may still contain some left gfns after kvm_clear_async_pf_completion_queue() called, need to clear them.

sorry.

Signed-off-by Lai Jiangshan <[email protected]>
Acked-by Gleb Natapov <[email protected]>
Quoted 14 lines
Quoted 14 lines
arch/x86/kvm/x86.c +3 -1
index 17af71d..dae2d15 100644
@@ -525,8 +525,10 @@ int kvm_set_cr0(struct kvm_vcpu *vcpu, unsigned long cr0)
 
 	kvm_x86_ops->set_cr0(vcpu, cr0);
 
-	if ((cr0 ^ old_cr0) & X86_CR0_PG)
+	if ((cr0 ^ old_cr0) & X86_CR0_PG) {
 		kvm_clear_async_pf_completion_queue(vcpu);
+		kvm_async_pf_hash_reset(vcpu);
+	}
Quoted 7 lines
Quoted 7 lines
arch/x86/kvm/x86.c +0 -1
 	if ((cr0 ^ old_cr0) & update_bits)
 		kvm_mmu_reset_context(vcpu);
--

To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

--
Gleb.

Applied
#3 lore raw
In reply to Lai Jiangshan
Quoted 2 lines · Lai Jiangshan

The hash array of async gfns may still contain some left gfns after kvm_clear_async_pf_completion_queue() called, need to clear them.

Applied, thanks.

Signature · 1 line
error compiling committee.c: too many arguments to function