Skip to contentSkip to conversation

ALSA: HDA: Add a new Conexant codec 506e (20590)

PATCH In review David Henningsson 2 participants 2 messages Feb 23, 2011 Sound

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 ALSA: HDA: Add a new Conexant codec 506e (20590)

I'm a little hesitant as of whether to send this one to stable or not, as the fallback of the 5066 parser can perform worse than the generic one. However, if we don't, we can't quirk them to work perfectly later. What do you think?

Signature · 2 lines
David Henningsson, Canonical Ltd.
http://launchpad.net/~diwic
Quoted 1 line

From 7ba625cf57f80e124024fd46a1bfe1fb8f9c1558 Mon Sep 17 00:00:00 2001

From: David Henningsson <[email protected]>
Date: Tue, 8 Feb 2011 07:16:06 +0100
Subject: [PATCH 1/2] ALSA: HDA: Add a new Conexant codec 506e (20590)

Conexant 506e/20590 has the same graph as the rest of the 5066 family.

---
 sound/pci/hda/patch_conexant.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
sound/pci/hda/patch_conexant.c +3 -0
index dd7c5c1..909ce9e 100644
@@ -3937,6 +3937,8 @@ static struct hda_codec_preset snd_hda_preset_conexant[] = {
 	  .patch = patch_cxt5066 },
 	{ .id = 0x14f15069, .name = "CX20585",
 	  .patch = patch_cxt5066 },
+	{ .id = 0x14f1506e, .name = "CX20590",
+	  .patch = patch_cxt5066 },
 	{ .id = 0x14f15097, .name = "CX20631",
 	  .patch = patch_conexant_auto },
 	{ .id = 0x14f15098, .name = "CX20632",
@@ -3963,6 +3965,7 @@ MODULE_ALIAS("snd-hda-codec-id:14f15066");
 MODULE_ALIAS("snd-hda-codec-id:14f15067");
 MODULE_ALIAS("snd-hda-codec-id:14f15068");
 MODULE_ALIAS("snd-hda-codec-id:14f15069");
+MODULE_ALIAS("snd-hda-codec-id:14f1506e");
 MODULE_ALIAS("snd-hda-codec-id:14f15097");
 MODULE_ALIAS("snd-hda-codec-id:14f15098");
 MODULE_ALIAS("snd-hda-codec-id:14f150a1");
Signature · 1 line
1.7.1

_______________________________________________
Alsa-devel mailing list
[email protected]
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

#1 lore raw

At Wed, 23 Feb 2011 13:22:39 +0100,

Quoted 5 lines · David Henningsson

I'm a little hesitant as of whether to send this one to stable or not, as the fallback of the 5066 parser can perform worse than the generic one. However, if we don't, we can't quirk them to work perfectly later. What do you think?

In principle, it's not for stable unless you have a real machine with this codec that has been tested with older kernels. But, the change is so small and this can't regress much, I'll take it to stable, too.

thanks,

Takashi

Quoted 40 lines

[2 0001-ALSA-HDA-Add-a-new-Conexant-codec-506e-20590.patch <text/x-patch (7bit)>]

Quoted 1 line

From 7ba625cf57f80e124024fd46a1bfe1fb8f9c1558 Mon Sep 17 00:00:00 2001

From: David Henningsson <[email protected]>
Date: Tue, 8 Feb 2011 07:16:06 +0100
Subject: [PATCH 1/2] ALSA: HDA: Add a new Conexant codec 506e (20590)

Conexant 506e/20590 has the same graph as the rest of the 5066 family.

---
 sound/pci/hda/patch_conexant.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
sound/pci/hda/patch_conexant.c +3 -0
index dd7c5c1..909ce9e 100644
@@ -3937,6 +3937,8 @@ static struct hda_codec_preset snd_hda_preset_conexant[] = {
 	  .patch = patch_cxt5066 },
 	{ .id = 0x14f15069, .name = "CX20585",
 	  .patch = patch_cxt5066 },
+	{ .id = 0x14f1506e, .name = "CX20590",
+	  .patch = patch_cxt5066 },
 	{ .id = 0x14f15097, .name = "CX20631",
 	  .patch = patch_conexant_auto },
 	{ .id = 0x14f15098, .name = "CX20632",
@@ -3963,6 +3965,7 @@ MODULE_ALIAS("snd-hda-codec-id:14f15066");
 MODULE_ALIAS("snd-hda-codec-id:14f15067");
 MODULE_ALIAS("snd-hda-codec-id:14f15068");
 MODULE_ALIAS("snd-hda-codec-id:14f15069");
+MODULE_ALIAS("snd-hda-codec-id:14f1506e");
 MODULE_ALIAS("snd-hda-codec-id:14f15097");
 MODULE_ALIAS("snd-hda-codec-id:14f15098");
 MODULE_ALIAS("snd-hda-codec-id:14f150a1");
Signature · 1 line
1.7.1