firmware: Allow release-specific firmware dir

Every kernel package trying to provide files under /lib/firmware runs into problems really quickly with multiple kernels installed.

This patch moves them to /lib/firmware/$KERNELRELEASE. udev v127's firmware.sh looks there first before falling back to /lib/firmware.

---
 Makefile |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

@@ -975,7 +975,7 @@ depend dep:
 
 # ---------------------------------------------------------------------------
 # Firmware install
-INSTALL_FW_PATH=$(INSTALL_MOD_PATH)/lib/firmware
+INSTALL_FW_PATH=$(INSTALL_MOD_PATH)/lib/firmware/$(KERNELRELEASE)
 export INSTALL_FW_PATH
 
 PHONY += firmware_install

Jeff Mahoney
SUSE Labs

Which problems?

This was the way it worked before, -- all fw in kernel-specific dir. Nowadays it moved to a common place, /lib/firmware, since the blobs there are not kernel-specific but hardware-specific. And now you propose to move it back. Why?

/mjt

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Because every time you run 'make modules_install', it overwrites whatever is in /lib/firmware when there is a collision. When you're working with multiple kernel versions, you can end up with firmware blobs from older builds, and that may not be what you want. If the right answer is to always use kernel-firmware, then the firmwares should probably not be in the kernel tree at all.

As I mentioned in the header, udev looks in /lib/firmware/$(uname -r) already. Since Aug 2008, in fact.

- -Jeff

- --
Jeff Mahoney
SUSE Labs
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.16 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org/

iEYEARECAAYFAk1nxKYACgkQLPWxlyuTD7KohACfRmDshnoXwVTpSs+xblUfQSKQ svkAnikK8sk7S6Fd8NKT1Ui2ugaP7IzC
=odyW
-----END PGP SIGNATURE-----

The right answer is to always use kernel-firmware. The firmwares should not be in the kernel tree at all.

Changing the default behaviour of 'make modules_install' so that it no longer installs firmware would be the better option. As a stop-gap until we finally do drop the legacy firmware images from the source tree.

dwmw2