Skip to contentSkip to conversation

ARM: EXYNOS4: Adds Samsung NURI board support

PATCH New Minkyu Kang 2 participants 6 messages Feb 25, 2011 – Mar 4, 2011

Subsystems (3)
Arm (32-bit) Arm sub-architectures Arm Samsung Exynos
lore
Share & tools
lore

Minkyu Kang

author
#0 lore raw

PATCH 1/1 ARM: EXYNOS4: Adds Samsung NURI board support

This patch adds Samsung NURI board support.

Signed-off-by Minkyu Kang <[email protected]>
Signed-off-by Kyungmin Park <[email protected]>

---
This patch is base on next-exynos4 branch at kgene tree.

 arch/arm/configs/exynos4_defconfig |    1 +
 arch/arm/mach-exynos4/Kconfig      |   15 +++
 arch/arm/mach-exynos4/Makefile     |    1 +
 arch/arm/mach-exynos4/mach-nuri.c  |  233 ++++++++++++++++++++++++++++++++++++
 4 files changed, 250 insertions(+), 0 deletions(-)
 create mode 100644 arch/arm/mach-exynos4/mach-nuri.c
arch/arm/configs/exynos4_defconfig +1 -0
index 2ffba24..fd92324 100644
@@ -9,6 +9,7 @@ CONFIG_S3C_LOWLEVEL_UART_PORT=1
 CONFIG_MACH_SMDKC210=y
 CONFIG_MACH_SMDKV310=y
 CONFIG_MACH_UNIVERSAL_C210=y
+CONFIG_MACH_NURI=y
 CONFIG_NO_HZ=y
 CONFIG_HIGH_RES_TIMERS=y
 CONFIG_SMP=y
arch/arm/mach-exynos4/Kconfig +15 -0
index ad03840..5bf00b9 100644
@@ -123,6 +123,21 @@ config MACH_UNIVERSAL_C210
 	  Machine support for Samsung Mobile Universal S5PC210 Reference
 	  Board.
 
+config MACH_NURI
+	bool "Mobile NURI Board"
+	select CPU_EXYNOS4210
+	select S3C_DEV_WDT
+	select S3C_DEV_HSMMC
+	select S3C_DEV_HSMMC2
+	select S3C_DEV_HSMMC3
+	select S3C_DEV_I2C1
+	select S3C_DEV_I2C5
+	select EXYNOS4_SETUP_I2C1
+	select EXYNOS4_SETUP_I2C5
+	select EXYNOS4_SETUP_SDHCI
+	help
+	  Machine support for Samsung Mobile NURI Board.
+
 endmenu
 
 comment "Configuration for HSMMC bus width"
arch/arm/mach-exynos4/Makefile +1 -0
index 0558235..fa9e814 100644
@@ -25,6 +25,7 @@ obj-$(CONFIG_HOTPLUG_CPU)	+= hotplug.o
 obj-$(CONFIG_MACH_SMDKC210)		+= mach-smdkc210.o
 obj-$(CONFIG_MACH_SMDKV310)		+= mach-smdkv310.o
 obj-$(CONFIG_MACH_UNIVERSAL_C210)	+= mach-universal_c210.o
+obj-$(CONFIG_MACH_NURI)			+= mach-nuri.o
 
 # device support
arch/arm/mach-exynos4/mach-nuri.c new file +233 -0

233 lines not on this page · raw message

Signature · 1 line
1.7.1
#1 lore raw

PATCH 1/1 ARM: EXYNOS4: Adds Samsung NURI board support

Quoted 16 lines · Minkyu Kang

This patch adds Samsung NURI board support.

Signed-off-by Minkyu Kang <[email protected]>
Signed-off-by Kyungmin Park <[email protected]>

---
This patch is base on next-exynos4 branch at kgene tree.

 arch/arm/configs/exynos4_defconfig |    1 +
 arch/arm/mach-exynos4/Kconfig      |   15 +++
 arch/arm/mach-exynos4/Makefile     |    1 +
 arch/arm/mach-exynos4/mach-nuri.c  |  233
++++++++++++++++++++++++++++++++++++
 4 files changed, 250 insertions(+), 0 deletions(-)
 create mode 100644 arch/arm/mach-exynos4/mach-nuri.c

(snip)

Quoted 15 lines
arch/arm/mach-exynos4/Kconfig +15 -0
+config MACH_NURI
+	bool "Mobile NURI Board"
+	select CPU_EXYNOS4210
+	select S3C_DEV_WDT
+	select S3C_DEV_HSMMC
+	select S3C_DEV_HSMMC2
+	select S3C_DEV_HSMMC3
+	select S3C_DEV_I2C1
+	select S3C_DEV_I2C5
+	select EXYNOS4_SETUP_I2C1
+	select EXYNOS4_SETUP_I2C5
+	select EXYNOS4_SETUP_SDHCI
+	help
+	  Machine support for Samsung Mobile NURI Board.
+

(snip)

arch/arm/mach-exynos4/mach-nuri.c line 47

Quoted 2 lines
arch/arm/mach-exynos4/mach-nuri.c new file +2 -0
+enum fixed_regulator_id {
+	FIXED_REG_ID_MMC = 0,

FIXED_REG_ID_MMC,

(snip)

arch/arm/mach-exynos4/mach-nuri.c line 111

Quoted 3 lines
arch/arm/mach-exynos4/mach-nuri.c new file +3 -0
+static struct platform_device emmc_fixed_voltage = {
+	.name			= "reg-fixed-voltage",
+	.id			= FIXED_REG_ID_MMC,

Is there any reason to use FIXED_REG_ID_MMC instead directly id 0?

(snip)

arch/arm/mach-exynos4/mach-nuri.c line 202

Quoted 9 lines
arch/arm/mach-exynos4/mach-nuri.c new file +9 -0
+static struct platform_device *nuri_devices[] __initdata = {
+	/* Samsung Platform Devices */
+	&emmc_fixed_voltage,
+	&s3c_device_hsmmc0,
+	&s3c_device_hsmmc2,
+	&s3c_device_hsmmc3,
+#ifdef CONFIG_S3C2410_WATCHDOG
+	&s3c_device_wdt,
+#endif

Basically no need to add #ifdef here.
Because "s3c_device_wdt" depends on CONFIG_S3C_DEV_WDT and you already selected it in Kconfig.

Of course, CONFIG_S3C2410_WATCHDOG is another selection for watchdog driver.

I'm sorting it out like the relation of platform device and regarding device driver.

(snip)

Others, looks ok to me.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.

author
#2 lore raw

PATCH 1/1 ARM: EXYNOS4: Adds Samsung NURI board support

Dear Kukjin Kim,

2011-02-28 ?? 4:42, Kukjin Kim ? ?:

Quoted 23 lines
Quoted 17 lines · Minkyu Kang

This patch adds Samsung NURI board support.

Signed-off-by Minkyu Kang <[email protected]>
Signed-off-by Kyungmin Park <[email protected]>

---
This patch is base on next-exynos4 branch at kgene tree.

 arch/arm/configs/exynos4_defconfig |    1 +
 arch/arm/mach-exynos4/Kconfig      |   15 +++
 arch/arm/mach-exynos4/Makefile     |    1 +
 arch/arm/mach-exynos4/mach-nuri.c  |  233
++++++++++++++++++++++++++++++++++++
 4 files changed, 250 insertions(+), 0 deletions(-)
 create mode 100644 arch/arm/mach-exynos4/mach-nuri.c

arch/arm/mach-exynos4/mach-nuri.c line 47

Quoted 2 lines
arch/arm/mach-exynos4/mach-nuri.c new file +2 -0
+enum fixed_regulator_id {
+	FIXED_REG_ID_MMC = 0,

FIXED_REG_ID_MMC,

Quoted 8 lines

(snip)

arch/arm/mach-exynos4/mach-nuri.c line 111

Quoted 3 lines
arch/arm/mach-exynos4/mach-nuri.c new file +3 -0
+static struct platform_device emmc_fixed_voltage = {
+	.name			= "reg-fixed-voltage",
+	.id			= FIXED_REG_ID_MMC,

Is there any reason to use FIXED_REG_ID_MMC instead directly id 0?

I'm going to add more IDs of fixed regulator that are LCD and Backlight, and so on. So use enum values for avoid the hard coding.

Thanks.
Minkyu Kang.

#3 lore raw

PATCH 1/1 ARM: EXYNOS4: Adds Samsung NURI board support

Quoted 36 lines · Minkyu Kang

Dear Kukjin Kim,

2011-02-28 ?? 4:42, Kukjin Kim ? ?:

Quoted 23 lines
Quoted 17 lines · Minkyu Kang

This patch adds Samsung NURI board support.

Signed-off-by Minkyu Kang <[email protected]>
Signed-off-by Kyungmin Park <[email protected]>

---
This patch is base on next-exynos4 branch at kgene tree.

 arch/arm/configs/exynos4_defconfig |    1 +
 arch/arm/mach-exynos4/Kconfig      |   15 +++
 arch/arm/mach-exynos4/Makefile     |    1 +
 arch/arm/mach-exynos4/mach-nuri.c  |  233
++++++++++++++++++++++++++++++++++++
 4 files changed, 250 insertions(+), 0 deletions(-)
 create mode 100644 arch/arm/mach-exynos4/mach-nuri.c

arch/arm/mach-exynos4/mach-nuri.c line 47

Quoted 2 lines
arch/arm/mach-exynos4/mach-nuri.c new file +2 -0
+enum fixed_regulator_id {
+	FIXED_REG_ID_MMC = 0,

FIXED_REG_ID_MMC,

Quoted 8 lines

(snip)

arch/arm/mach-exynos4/mach-nuri.c line 111

Quoted 3 lines
arch/arm/mach-exynos4/mach-nuri.c new file +3 -0
+static struct platform_device emmc_fixed_voltage = {
+	.name			= "reg-fixed-voltage",
+	.id			= FIXED_REG_ID_MMC,

Is there any reason to use FIXED_REG_ID_MMC instead directly id 0?

Quoted 4 lines

I'm going to add more IDs of fixed regulator that are LCD and Backlight, and so on.
So use enum values for avoid the hard coding.

Ok, applied this after removing "ifdef WATCHDOG".
Thanks.

Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.

#4 lore raw

PATCH 1/1 ARM: EXYNOS4: Adds Samsung NURI board support

Quoted 38 lines · Kukjin Kim
Quoted 36 lines · Minkyu Kang

Dear Kukjin Kim,

2011-02-28 ?? 4:42, Kukjin Kim ? ?:

Quoted 31 lines
Quoted 17 lines · Minkyu Kang

This patch adds Samsung NURI board support.

Signed-off-by Minkyu Kang <[email protected]>
Signed-off-by Kyungmin Park <[email protected]>

---
This patch is base on next-exynos4 branch at kgene tree.

 arch/arm/configs/exynos4_defconfig |    1 +
 arch/arm/mach-exynos4/Kconfig      |   15 +++
 arch/arm/mach-exynos4/Makefile     |    1 +
 arch/arm/mach-exynos4/mach-nuri.c  |  233
++++++++++++++++++++++++++++++++++++
 4 files changed, 250 insertions(+), 0 deletions(-)
 create mode 100644 arch/arm/mach-exynos4/mach-nuri.c

arch/arm/mach-exynos4/mach-nuri.c line 47

Quoted 2 lines
arch/arm/mach-exynos4/mach-nuri.c new file +2 -0
+enum fixed_regulator_id {
+	FIXED_REG_ID_MMC = 0,

FIXED_REG_ID_MMC,

(snip)

arch/arm/mach-exynos4/mach-nuri.c line 111

Quoted 3 lines
arch/arm/mach-exynos4/mach-nuri.c new file +3 -0
+static struct platform_device emmc_fixed_voltage = {
+	.name			= "reg-fixed-voltage",
+	.id			= FIXED_REG_ID_MMC,

Is there any reason to use FIXED_REG_ID_MMC instead directly id 0?

Quoted 7 lines
Quoted 1 line

I'm going to add more IDs of fixed regulator that are LCD and Backlight,

and

Quoted 3 lines

so on.
So use enum values for avoid the hard coding.

Ok, applied this after removing "ifdef WATCHDOG".

Oops, NURI board is not registered yet :(
So can't merge this before updating it now. Or should drop update defconfig from this...

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.

#5 lore raw

PATCH 1/1 ARM: EXYNOS4: Adds Samsung NURI board support

In reply to Kukjin Kim
Quoted 5 lines · Kukjin Kim

Oops, NURI board is not registered yet :(
So can't merge this before updating it now.
Or should drop update defconfig from this...

So applied without defconfig changes.
As you know, if required, can do it later :)

If any problems, please let me know.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.