Revert "irq: Add tracepoint to softirq_raise" - microblaze build

DISCUSSION Michal Simek 2 participants 5 messages Mar 9, 2011

lore

Share & tools

lore

Michal Simek

author

2011-03-09 12:20 UTC #0 lore raw

Hi Frederic,

I have compiled ftrace support for Microblaze and I have reached a compilation failure.

I bisected it and I found that
"irq: Add tracepoint to softirq_raise"
(sha1:2bf2160d8805de64308e2e7c3cd97813cb58ed2f)
caused it.

I also found one thread which could be related.
http://kerneltrap.org/mailarchive/linux-kernel/2010/9/8/4616941

It is likely any missing header or so.

Do you know what can be wrong?

Thanks,
Michal

[ALL  ]   CC      kernel/trace/power-traces.o
[ALL  ] In file included from /mnt/projects/petalinux-v1.00-devel/software/linux-2.6.x/arch/microblaze/include/asm/irq.h:15,
[ALL  ]                  from include/linux/irq.h:27,
[ALL  ]                  from include/asm-generic/hardirq.h:12,
[ALL  ]                  from /mnt/projects/petalinux-v1.00-devel/software/linux-2.6.x/arch/microblaze/include/asm/hardirq.h:15,
[ALL  ]                  from include/linux/hardirq.h:7,
[ALL  ]                  from include/linux/ftrace_event.h:7,
[ALL  ]                  from include/trace/ftrace.h:19,
[ALL  ]                  from include/trace/define_trace.h:96,
[ALL  ]                  from include/trace/events/power.h:240,
[ALL  ]                  from kernel/trace/power-traces.c:14:
[ALL  ] include/linux/interrupt.h: In function '__raise_softirq_irqoff':
[ERROR] include/linux/interrupt.h:413: error: implicit declaration of function 'trace_softirq_raise'
[ALL  ] In file included from include/trace/ftrace.h:554,
[ALL  ]                  from include/trace/define_trace.h:96,
[ALL  ]                  from include/trace/events/power.h:240,
[ALL  ]                  from kernel/trace/power-traces.c:14:
[ALL  ] include/trace/events/irq.h: In function 'ftrace_test_probe_irq_handler_entry':

[ERROR] include/trace/events/irq.h:37: error: implicit declaration of function 'check_trace_callback_type_irq_handler_entry' [ALL ] include/trace/events/irq.h: In function 'ftrace_test_probe_irq_handler_exit':
[ERROR] include/trace/events/irq.h:67: error: implicit declaration of function 'check_trace_callback_type_irq_handler_exit' [ALL ] include/trace/events/irq.h: In function 'ftrace_test_probe_softirq_entry':
[ERROR] include/trace/events/irq.h:112: error: implicit declaration of function 'check_trace_callback_type_softirq_entry' [ALL ] include/trace/events/irq.h: In function 'ftrace_test_probe_softirq_exit':
[ERROR] include/trace/events/irq.h:126: error: implicit declaration of function 'check_trace_callback_type_softirq_exit' [ALL ] include/trace/events/irq.h: In function 'ftrace_test_probe_softirq_raise':
[ERROR] include/trace/events/irq.h:140: error: implicit declaration of function 'check_trace_callback_type_softirq_raise' [ERROR] make[5]: *** [kernel/trace/power-traces.o] Error 1
[ERROR] make[4]: *** [kernel/trace] Error 2
[ERROR] make[3]: *** [kernel] Error 2

Signature · 4 lines

Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/
Microblaze U-BOOT custodian

Steven Rostedt

2011-03-09 16:46 UTC #1 lore raw

Quoted 16 lines · Michal Simek

Hi Frederic,
I have compiled ftrace support for Microblaze and I have reached a compilation failure.
I bisected it and I found that
"irq: Add tracepoint to softirq_raise"
(sha1:2bf2160d8805de64308e2e7c3cd97813cb58ed2f)
caused it.
I also found one thread which could be related.
http://kerneltrap.org/mailarchive/linux-kernel/2010/9/8/4616941
It is likely any missing header or so.
Do you know what can be wrong?

Quoted 7 lines

Thanks,
Michal
[ALL ] CC kernel/trace/power-traces.o
[ALL ] In file included from /mnt/projects/petalinux-v1.00-devel/software/linux-2.6.x/arch/microblaze/include/asm/irq.h:15,

Is there a reason that arch/microblaze/include/asm/irq.h includes "linux/interrupt.h"?

-- Steve

Quoted 36 lines

[ALL  ]                  from include/linux/irq.h:27,
[ALL  ]                  from include/asm-generic/hardirq.h:12,
[ALL  ]                  from 
/mnt/projects/petalinux-v1.00-devel/software/linux-2.6.x/arch/microblaze/include/asm/hardirq.h:15,
[ALL  ]                  from include/linux/hardirq.h:7,
[ALL  ]                  from include/linux/ftrace_event.h:7,
[ALL  ]                  from include/trace/ftrace.h:19,
[ALL  ]                  from include/trace/define_trace.h:96,
[ALL  ]                  from include/trace/events/power.h:240,
[ALL  ]                  from kernel/trace/power-traces.c:14:
[ALL  ] include/linux/interrupt.h: In function '__raise_softirq_irqoff':
[ERROR] include/linux/interrupt.h:413: error: implicit declaration of function 'trace_softirq_raise'
[ALL  ] In file included from include/trace/ftrace.h:554,
[ALL  ]                  from include/trace/define_trace.h:96,
[ALL  ]                  from include/trace/events/power.h:240,
[ALL  ]                  from kernel/trace/power-traces.c:14:
[ALL  ] include/trace/events/irq.h: In function 'ftrace_test_probe_irq_handler_entry':
[ERROR] include/trace/events/irq.h:37: error: implicit declaration of function 'check_trace_callback_type_irq_handler_entry'
[ALL ] include/trace/events/irq.h: In function 'ftrace_test_probe_irq_handler_exit':
[ERROR] include/trace/events/irq.h:67: error: implicit declaration of function 'check_trace_callback_type_irq_handler_exit'
[ALL ] include/trace/events/irq.h: In function 'ftrace_test_probe_softirq_entry':
[ERROR] include/trace/events/irq.h:112: error: implicit declaration of function 'check_trace_callback_type_softirq_entry'
[ALL ] include/trace/events/irq.h: In function 'ftrace_test_probe_softirq_exit':
[ERROR] include/trace/events/irq.h:126: error: implicit declaration of function 'check_trace_callback_type_softirq_exit'
[ALL ] include/trace/events/irq.h: In function 'ftrace_test_probe_softirq_raise':
[ERROR] include/trace/events/irq.h:140: error: implicit declaration of function 'check_trace_callback_type_softirq_raise'
[ERROR] make[5]: *** [kernel/trace/power-traces.o] Error 1
[ERROR] make[4]: *** [kernel/trace] Error 2
[ERROR] make[3]: *** [kernel] Error 2

Michal Simek

author

2011-03-09 17:01 UTC #2 lore raw

Quoted 21 lines · Steven Rostedt

Quoted 20 lines · Michal Simek
Hi Frederic,
I have compiled ftrace support for Microblaze and I have reached a compilation failure.
I bisected it and I found that
"irq: Add tracepoint to softirq_raise"
(sha1:2bf2160d8805de64308e2e7c3cd97813cb58ed2f)
caused it.
I also found one thread which could be related.
http://kerneltrap.org/mailarchive/linux-kernel/2010/9/8/4616941
It is likely any missing header or so.
Do you know what can be wrong?
Thanks,
Michal

Quoted 5 lines

Quoted 2 lines
[ALL ] CC kernel/trace/power-traces.o
[ALL ] In file included from /mnt/projects/petalinux-v1.00-devel/software/linux-2.6.x/arch/microblaze/include/asm/irq.h:15,
Is there a reason that arch/microblaze/include/asm/irq.h includes "linux/interrupt.h"?

Yep, it is. I tried to add some headers not remove them.

Thanks,
Michal

P.S.: Do you want to create proper patch? If not, I will do it.

Signature · 4 lines

Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/
Microblaze U-BOOT custodian

Steven Rostedt

2011-03-09 17:12 UTC #3 lore raw

Quoted 22 lines · Michal Simek

Quoted 21 lines · Steven Rostedt
Quoted 20 lines · Michal Simek
Hi Frederic,
I have compiled ftrace support for Microblaze and I have reached a compilation failure.
I bisected it and I found that
"irq: Add tracepoint to softirq_raise"
(sha1:2bf2160d8805de64308e2e7c3cd97813cb58ed2f)
caused it.
I also found one thread which could be related.
http://kerneltrap.org/mailarchive/linux-kernel/2010/9/8/4616941
It is likely any missing header or so.
Do you know what can be wrong?
Thanks,
Michal

Quoted 8 lines

Quoted 6 lines
Quoted 3 lines
[ALL ] CC kernel/trace/power-traces.o
[ALL ] In file included from /mnt/projects/petalinux-v1.00-devel/software/linux-2.6.x/arch/microblaze/include/asm/irq.h:15,
Is there a reason that arch/microblaze/include/asm/irq.h includes "linux/interrupt.h"?
Yep, it is. I tried to add some headers not remove them.

Do you mean it is not needed? And removing it fixes the problem?

Quoted 5 lines

Thanks,
Michal
P.S.: Do you want to create proper patch? If not, I will do it.

I rather not add patches to systems that I can't build, boot and test.

If removing the header works, just add a:

Thanks,

-- Steve

Michal Simek

author

2011-03-09 17:36 UTC #4 lore raw

Quoted 23 lines · Steven Rostedt

Quoted 22 lines · Michal Simek
Quoted 21 lines · Steven Rostedt
Quoted 20 lines · Michal Simek
Hi Frederic,
I have compiled ftrace support for Microblaze and I have reached a compilation failure.
I bisected it and I found that
"irq: Add tracepoint to softirq_raise"
(sha1:2bf2160d8805de64308e2e7c3cd97813cb58ed2f)
caused it.
I also found one thread which could be related.
http://kerneltrap.org/mailarchive/linux-kernel/2010/9/8/4616941
It is likely any missing header or so.
Do you know what can be wrong?
Thanks,
Michal

Quoted 8 lines

Quoted 5 lines
Quoted 4 lines
Quoted 2 lines
[ALL ] CC kernel/trace/power-traces.o
[ALL ] In file included from /mnt/projects/petalinux-v1.00-devel/software/linux-2.6.x/arch/microblaze/include/asm/irq.h:15,
Is there a reason that arch/microblaze/include/asm/irq.h includes "linux/interrupt.h"?
Yep, it is. I tried to add some headers not remove them.
Do you mean it is not needed? And removing it fixes the problem?

yes, removing that header fixed the problem. I will do more testing tomorrow.

Quoted 6 lines

I rather not add patches to systems that I can't build, boot and test.
If removing the header works, just add a:
Suggested-by Steven Rostedt <[email protected]>

ok.

Thanks,
Michal

Signature · 4 lines

Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/
Microblaze U-BOOT custodian