Skip to contentSkip to conversation

syscalls: mmap10: fix broken testcase

PATCH In review Caspar Zhang 2 participants 2 messages Mar 15, 2011

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 syscalls: mmap10: fix broken testcase

current mmap10 testcase in git couldn't reproduce the upstream bug as expected, also it is completely broken on ppc64 system since the page size in ppc64 is not 4KB but 64KB. This patch fixes these issues.

Some extra fix and cleaning:

. if a system without MADV_MERGEABLE, it should still be able to run all the other mmap10 tests if only -s option not given.

. Reduce the duplicated useless output to one.

This patch is tested on RHEL6.0 and mmap10 now works as expected.

---
 runtest/mm                              |    2 +-
 testcases/kernel/syscalls/mmap/mmap10.c |   68
+++++++++++++++++++------------
 2 files changed, 43 insertions(+), 27 deletions(-)
runtest/mm +1 -1
index 1296e59..0633e14 100644
@@ -58,7 +58,7 @@ mmap10 mmap10
 mmap10_1 mmap10 -a
 mmap10_2 mmap10 -s
 mmap10_3 mmap10 -a -s
-mmap10_4 mmap10 -a -s -c 60
+mmap10_4 mmap10 -a -s -i 60
 
 ksm01 ksm01
 ksm01_1 ksm01 -u 128
(quoted diff) +0 -0

b/testcases/kernel/syscalls/mmap/mmap10.c
index cc17766..b735f5b 100644

testcases/kernel/syscalls/mmap/mmap10.c +42 -26

139 lines not on this page · raw message

Signature · 8 lines
1.7.4.1


-- 
Quality Engineer (Kernel) in
Red Hat Software (Beijing) Co., R&D Branch
http://www.cn.redhat.com/
TEL: +86-10-62608150

current mmap10 testcase in git couldn't reproduce the upstream bug as expected, also it is completely broken on ppc64 system since the page size in ppc64 is not 4KB but 64KB. This patch fixes these issues.

Some extra fix and cleaning:

. if a system without MADV_MERGEABLE, it should still be able to run all the other mmap10 tests if only -s option not given.

. Reduce the duplicated useless output to one.

This patch is tested on RHEL6.0 and mmap10 now works as expected.

---
 runtest/mm                              |    2 +-
 testcases/kernel/syscalls/mmap/mmap10.c |   68 +++++++++++++++++++------------
 2 files changed, 43 insertions(+), 27 deletions(-)
runtest/mm +1 -1
index 1296e59..0633e14 100644
@@ -58,7 +58,7 @@ mmap10 mmap10
 mmap10_1 mmap10 -a
 mmap10_2 mmap10 -s
 mmap10_3 mmap10 -a -s
-mmap10_4 mmap10 -a -s -c 60
+mmap10_4 mmap10 -a -s -i 60
 
 ksm01 ksm01
 ksm01_1 ksm01 -u 128
testcases/kernel/syscalls/mmap/mmap10.c +42 -26

139 lines not on this page · raw message

Signature · 1 line
1.7.4.1

------------------------------------------------------------------------------
Colocation vs. Managed Hosting
A question and answer guide to determining the best fit for your organization - today and in the future.
http://p.sf.net/sfu/internap-sfd2d

_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

#1 lore raw
Quoted 4 lines · Caspar Zhang

current mmap10 testcase in git couldn't reproduce the upstream bug as expected, also it is completely broken on ppc64 system since the page size in ppc64 is not 4KB but 64KB. This patch fixes these issues.

Quoted 8 lines

Some extra fix and cleaning:

. if a system without MADV_MERGEABLE, it should still be able to run all the other mmap10 tests if only -s option not given.

. Reduce the duplicated useless output to one.

This patch is tested on RHEL6.0 and mmap10 now works as expected.

Committed -- thanks.
-Garrett

------------------------------------------------------------------------------
Colocation vs. Managed Hosting
A question and answer guide to determining the best fit for your organization - today and in the future.
http://p.sf.net/sfu/internap-sfd2d
_______________________________________________
Ltp-list mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list