net,rcu: convert call_rcu(phonet_device_rcu_free) to kfree_rcu()
Subsystems (3)
PATCH 28/36 net,rcu: convert call_rcu(phonet_device_rcu_free) to kfree_rcu()
The rcu callback phonet_device_rcu_free() just calls a kfree(), so we use kfree_rcu() instead of the call_rcu(phonet_device_rcu_free).
Signed-off-by Lai Jiangshan <[email protected]>
--- net/phonet/pn_dev.c | 10 +--------- 1 files changed, 1 insertions(+), 9 deletions(-)
net/phonet/pn_dev.c +1 -9
@@ -162,14 +162,6 @@ int phonet_address_add(struct net_device *dev, u8 addr)return err; } -static void phonet_device_rcu_free (struct rcu_head *head) -{ -struct phonet_device *pnd; - - pnd = container_of(head, struct phonet_device, rcu); -kfree (pnd); -} -int phonet_address_del (struct net_device *dev,u8 addr) {struct phonet_device_list *pndevs =phonet_device_list (dev_net (dev));
@@ -188,7 +180,7 @@ int phonet_address_del(struct net_device *dev, u8 addr)mutex_unlock (&pndevs->lock);if (pnd) -call_rcu (&pnd->rcu, phonet_device_rcu_free); +kfree_rcu (pnd, rcu);return err; }
Signature · 1 line
1.7.4
Quoted 4 lines · you
The rcu callback
phonet_device_rcu_free()just calls akfree(), so we usekfree_rcu()instead of thecall_rcu(phonet_device_rcu_free).Signed-off-by Lai Jiangshan <[email protected]>
In principles, that's fine with me. But I think David is not taking that kind of not-a-fix patch at the moment...
Signature · 2 lines
Rémi Denis-Courmont http://www.remlab.net/
From: Lai Jiangshan <[email protected]>
Date: Fri, 18 Mar 2011 12:09:03 +0800
Quoted 6 lines
The rcu callback
phonet_device_rcu_free()just calls akfree(), so we usekfree_rcu()instead of thecall_rcu(phonet_device_rcu_free).Signed-off-by Lai Jiangshan <[email protected]>
Acked-by David S. Miller <[email protected]>