Skip to contentSkip to conversation

net,rcu: convert call_rcu(phonet_device_rcu_free) to kfree_rcu()

PATCH In review Lai Jiangshan 3 participants 3 messages Mar 18, 2011

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 28/36 net,rcu: convert call_rcu(phonet_device_rcu_free) to kfree_rcu()

The rcu callback phonet_device_rcu_free() just calls a kfree(), so we use kfree_rcu() instead of the call_rcu(phonet_device_rcu_free).

---
 net/phonet/pn_dev.c |   10 +---------
 1 files changed, 1 insertions(+), 9 deletions(-)
net/phonet/pn_dev.c +1 -9
index 947038d..1566672 100644
@@ -162,14 +162,6 @@ int phonet_address_add(struct net_device *dev, u8 addr)
 	return err;
 }
 
-static void phonet_device_rcu_free(struct rcu_head *head)
-{
-	struct phonet_device *pnd;
-
-	pnd = container_of(head, struct phonet_device, rcu);
-	kfree(pnd);
-}
-
 int phonet_address_del(struct net_device *dev, u8 addr)
 {
 	struct phonet_device_list *pndevs = phonet_device_list(dev_net(dev));
@@ -188,7 +180,7 @@ int phonet_address_del(struct net_device *dev, u8 addr)
 	mutex_unlock(&pndevs->lock);
 
 	if (pnd)
-		call_rcu(&pnd->rcu, phonet_device_rcu_free);
+		kfree_rcu(pnd, rcu);
 
 	return err;
 }
Signature · 1 line
1.7.4
#1 lore raw
Quoted 4 lines · you

The rcu callback phonet_device_rcu_free() just calls a kfree(), so we use kfree_rcu() instead of the call_rcu(phonet_device_rcu_free).

In principles, that's fine with me. But I think David is not taking that kind of not-a-fix patch at the moment...

Signature · 2 lines
Rémi Denis-Courmont
http://www.remlab.net/