Skip to contentSkip to conversation

OMAP34xx: Add padconfig offsets for GPIOs 126-129

PATCH In review Matthias Kaehlcke 3 participants 4 messages Apr 1, 2011 – Apr 3, 2011

Subsystems (3)
Arm (32-bit) Arm sub-architectures OMAP2+ support
lore
Share & tools
lore

Matthias Kaehlcke

author
#0 lore raw

PATCH 1/1 OMAP34xx: Add padconfig offsets for GPIOs 126-129

Add OMAP3_CONTROL_PADCONF_GPIOxxx_OFFSET constants for GPIOs 126-129

Signed-off-by Matthias Kaehlcke <[email protected]>
---
 arch/arm/mach-omap2/mux34xx.h |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
arch/arm/mach-omap2/mux34xx.h +4 -0
index 6543ebf..70d2b8d 100644
@@ -393,6 +393,10 @@
 #define OMAP3_CONTROL_PADCONF_SAD2D_SWAKEUP_OFFSET		0xa1c
 #define OMAP3_CONTROL_PADCONF_JTAG_RTCK_OFFSET			0xa1e
 #define OMAP3_CONTROL_PADCONF_JTAG_TDO_OFFSET			0xa20
+#define OMAP3_CONTROL_PADCONF_GPIO127_OFFSET			0xa24
+#define OMAP3_CONTROL_PADCONF_GPIO126_OFFSET			0xa26
+#define OMAP3_CONTROL_PADCONF_GPIO128_OFFSET			0xa28
+#define OMAP3_CONTROL_PADCONF_GPIO129_OFFSET			0xa2a
 
 #define OMAP3_CONTROL_PADCONF_MUX_SIZE				\
 		(OMAP3_CONTROL_PADCONF_JTAG_TDO_OFFSET + 0x2)
Signature · 1 line
1.7.1
#1 lore raw
Quoted 12 lines · Matthias Kaehlcke

Add OMAP3_CONTROL_PADCONF_GPIOxxx_OFFSET constants for GPIOs 126-129

Signed-off-by Matthias Kaehlcke <[email protected]>
---
 arch/arm/mach-omap2/mux34xx.h |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
arch/arm/mach-omap2/mux34xx.h +0 -0
index 6543ebf..70d2b8d 100644

arch/arm/mach-omap2/mux34xx.h line 399

Quoted 7 lines
arch/arm/mach-omap2/mux34xx.h +4 -0
@@ -393,6 +393,10 @@
 #define OMAP3_CONTROL_PADCONF_SAD2D_SWAKEUP_OFFSET		0xa1c
 #define OMAP3_CONTROL_PADCONF_JTAG_RTCK_OFFSET			0xa1e
 #define OMAP3_CONTROL_PADCONF_JTAG_TDO_OFFSET			0xa20
+#define OMAP3_CONTROL_PADCONF_GPIO127_OFFSET			0xa24
+#define OMAP3_CONTROL_PADCONF_GPIO126_OFFSET			0xa26
+#define OMAP3_CONTROL_PADCONF_GPIO128_OFFSET			0xa28
+#define OMAP3_CONTROL_PADCONF_GPIO129_OFFSET			0xa2a

no users for these ?

Signature · 1 line
balbi
#2 lore raw

Hi Felipe,

El Sun, Apr 03, 2011 at 02:06:31PM +0300 Felipe Balbi ha dit:

Quoted 8 lines · Matthias Kaehlcke
Quoted 7 lines

Add OMAP3_CONTROL_PADCONF_GPIOxxx_OFFSET constants for GPIOs 126-129

Signed-off-by Matthias Kaehlcke <[email protected]>
---
 arch/arm/mach-omap2/mux34xx.h |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
Quoted 14 lines

arch/arm/mach-omap2/mux34xx.h line 399

Quoted 12 lines
arch/arm/mach-omap2/mux34xx.h +4 -0
index 6543ebf..70d2b8d 100644
@@ -393,6 +393,10 @@
 #define OMAP3_CONTROL_PADCONF_SAD2D_SWAKEUP_OFFSET		0xa1c
 #define OMAP3_CONTROL_PADCONF_JTAG_RTCK_OFFSET			0xa1e
 #define OMAP3_CONTROL_PADCONF_JTAG_TDO_OFFSET			0xa20
+#define OMAP3_CONTROL_PADCONF_GPIO127_OFFSET			0xa24
+#define OMAP3_CONTROL_PADCONF_GPIO126_OFFSET			0xa26
+#define OMAP3_CONTROL_PADCONF_GPIO128_OFFSET			0xa28
+#define OMAP3_CONTROL_PADCONF_GPIO129_OFFSET			0xa2a

no users for these ?

we use these on a custom board whose board specific code won't be mainlined. i think it still makes sense to have the constants in mainline for the sake of completeness

kind regards

Signature · 15 lines
Matthias Kaehlcke
Embedded Linux Developer
Amsterdam

     La libertad es como la mañana. Hay quienes esperan dormidos a que
   llegue, pero hay quienes desvelan y caminan la noche para alcanzarla
                        (Subcomandante Marcos)
                                                                 .''`.
    using free software / Debian GNU/Linux | http://debian.org  : :'  :
                                                                `. `'`
gpg --keyserver pgp.mit.edu --recv-keys 47D8E5D4                  `-
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
#3 lore raw
Quoted 27 lines · Matthias Kaehlcke

Hi Felipe,

El Sun, Apr 03, 2011 at 02:06:31PM +0300 Felipe Balbi ha dit:

Quoted 8 lines · Matthias Kaehlcke
Quoted 7 lines

Add OMAP3_CONTROL_PADCONF_GPIOxxx_OFFSET constants for GPIOs 126-129

Signed-off-by Matthias Kaehlcke <[email protected]>
---
 arch/arm/mach-omap2/mux34xx.h |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
Quoted 14 lines

arch/arm/mach-omap2/mux34xx.h line 399

Quoted 12 lines
arch/arm/mach-omap2/mux34xx.h +4 -0
index 6543ebf..70d2b8d 100644
@@ -393,6 +393,10 @@
 #define OMAP3_CONTROL_PADCONF_SAD2D_SWAKEUP_OFFSET		0xa1c
 #define OMAP3_CONTROL_PADCONF_JTAG_RTCK_OFFSET			0xa1e
 #define OMAP3_CONTROL_PADCONF_JTAG_TDO_OFFSET			0xa20
+#define OMAP3_CONTROL_PADCONF_GPIO127_OFFSET			0xa24
+#define OMAP3_CONTROL_PADCONF_GPIO126_OFFSET			0xa26
+#define OMAP3_CONTROL_PADCONF_GPIO128_OFFSET			0xa28
+#define OMAP3_CONTROL_PADCONF_GPIO129_OFFSET			0xa2a

no users for these ?

Quoted 3 lines

we use these on a custom board whose board specific code won't be mainlined. i think it still makes sense to have the constants in mainline for the sake of completeness

I'll leave that decision to Tony. I agree that, for the sake of completeness, we should have those. But OTOH, not having any in tree users is kinda of a bummer.

It would be nice to see TomTom's devices in tree. Maybe after the kernel sources is released to the public we could that in tree "for the sake of completeness" :-)

Signature · 1 line
balbi