Skip to contentSkip to conversation

How to append inc file

DISCUSSION Yu Ke 4 participants 7 messages Apr 2, 2011 – Apr 4, 2011

lore
Share & tools
lore

Yu Ke

author
#0 lore raw

Hi,

bbappend file can be used to append content to bb file, and it is very useful in BSP meta data. Today I just find the *.inc file is also need to be appended, so I wonder if there is similar incappend file that can append content to inc file?

I meet this requirement when trying to fix bug 896 (http://bugzilla.yoctoproject.org/show_bug.cgi?id=896). To make poky-image-clutter build pass in n450, the clutter.inc need to be appended to change the COMPATIBLE_MACHINE.

Regards
Ke

#1 lore raw
Quoted 7 lines · Yu Ke

Hi,

bbappend file can be used to append content to bb file, and it is very useful in BSP meta data. Today I just find the *.inc file is also need to be appended, so I wonder if there is similar incappend file that can append content to inc file?

I meet this requirement when trying to fix bug 896 (http://bugzilla.yoctoproject.org/show_bug.cgi?id=896). To make poky-image-clutter build pass in n450, the clutter.inc need to be appended to change the COMPATIBLE_MACHINE.

Why can't you just put the change in the .bbappend file (since it's already recipe/target specific)?

Signature · 4 lines
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------
author
#2 lore raw
Quoted 8 lines · Gary Thomas
Quoted 7 lines · Yu Ke

Hi,

bbappend file can be used to append content to bb file, and it is very useful in BSP meta data. Today I just find the *.inc file is also need to be appended, so I wonder if there
is similar incappend file that can append content to inc file?

Quoted 8 lines
Quoted 4 lines

I meet this requirement when trying to fix bug 896
(http://bugzilla.yoctoproject.org/show_bug.cgi?id=896). To make poky-image-clutter build pass in n450, the clutter.inc need to be appended to change the COMPATIBLE_MACHINE.

Why can't you just put the change in the .bbappend file (since it's already recipe/target specific)?

currently there is clutter 1.4 and clutter 1.6 which both use the clutter.inc. and yes, It is also fine to use duplicate bbappend to append clutter 1.4 and clutter 1.6 respectively. But if clutter.inc can be appended, then it will reduce the duplicate code. Also inc file append has another benefit, when clutter 1.8 is out in the future, the BSP append code don't need any change.

Regards
Ke

#3 lore raw
Quoted 14 lines · Yu Ke
Quoted 13 lines · Gary Thomas
Quoted 11 lines · Yu Ke

Hi,

bbappend file can be used to append content to bb file, and it is very useful in BSP meta data. Today I just find the *.inc file is also need to be appended, so I wonder if there
is similar incappend file that can append content to inc file?

I meet this requirement when trying to fix bug 896
(http://bugzilla.yoctoproject.org/show_bug.cgi?id=896). To make poky-image-clutter build pass in n450, the clutter.inc need to be appended to change the COMPATIBLE_MACHINE.

Quoted 7 lines
Quoted 3 lines

Why can't you just put the change in the .bbappend file (since it's already recipe/target specific)?

currently there is clutter 1.4 and clutter 1.6 which both use the clutter.inc. and yes, It is also fine to use duplicate bbappend to append clutter 1.4 and clutter 1.6 respectively. But if clutter.inc can be appended, then it will reduce the duplicate code. Also inc file append has another benefit, when clutter 1.8 is out in the future, the BSP append code don't need any change.

Agreed, but .inc files are not handled the same way as .bb (at all) by the parser code, so I think it would be a pretty significant change to support such.

Signature · 4 lines
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------
#4 lore raw
In reply to Yu Ke
Quoted 18 lines · Yu Ke
Quoted 8 lines · Gary Thomas
Quoted 7 lines · Yu Ke

Hi,

bbappend file can be used to append content to bb file, and it is very useful in BSP meta data. Today I just find the *.inc file is also need to be appended, so I wonder if there
is similar incappend file that can append content to inc file?

Quoted 8 lines
Quoted 4 lines

I meet this requirement when trying to fix bug 896
(http://bugzilla.yoctoproject.org/show_bug.cgi?id=896). To make poky-image-clutter build pass in n450, the clutter.inc need to be appended to change the COMPATIBLE_MACHINE.

Why can't you just put the change in the .bbappend file (since it's already recipe/target specific)?

Quoted 6 lines

currently there is clutter 1.4 and clutter 1.6 which both use the clutter.inc. and yes, It is also fine to use duplicate bbappend to append clutter 1.4 and clutter 1.6 respectively. But if clutter.inc can be appended, then it will reduce the duplicate code. Also inc file append has another benefit, when clutter 1.8 is out in the future, the BSP append code don't need any change.

IIRC the common way to handle this now is to have shared code across versions in clutter.inc then have inc files for the major releases that require them (clutter-1.4.inc, clutter-1.6.inc, etc) and then have the version inc file include the core inc file.
The recipes would then include the appropriate inc file for the major version (1.6, etc) which they build.

Joshua

Signature · 3 lines
Joshua Lock
        Yocto Build System Monkey
        Intel Open Source Technology Centre
#5 lore raw
Quoted 26 lines · Joshua Lock
Quoted 18 lines · Yu Ke
Quoted 8 lines · Gary Thomas
Quoted 7 lines · Yu Ke

Hi,

bbappend file can be used to append content to bb file, and it is very useful in BSP meta data. Today I just find the *.inc file is also need to be appended, so I wonder if there
is similar incappend file that can append content to inc file?

Quoted 8 lines
Quoted 4 lines

I meet this requirement when trying to fix bug 896
(http://bugzilla.yoctoproject.org/show_bug.cgi?id=896). To make poky-image-clutter build pass in n450, the clutter.inc need to be appended to change the COMPATIBLE_MACHINE.

Why can't you just put the change in the .bbappend file (since it's already recipe/target specific)?

Quoted 6 lines

currently there is clutter 1.4 and clutter 1.6 which both use the clutter.inc. and yes, It is also fine to use duplicate bbappend to append clutter 1.4 and clutter 1.6 respectively. But if clutter.inc can be appended, then it will reduce the duplicate code. Also inc file append has another benefit, when clutter 1.8 is out in the future, the BSP append code don't need any change.

Quoted 6 lines

IIRC the common way to handle this now is to have shared code across versions in clutter.inc then have inc files for the major releases that require them (clutter-1.4.inc, clutter-1.6.inc, etc) and then have the version inc file include the core inc file.
The recipes would then include the appropriate inc file for the major version (1.6, etc) which they build.

How does that solve the problem that the .inc file needs to have BSP specific changes (which I find pretty abhorrent BTW)

Signature · 4 lines
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------
#6 lore raw
Quoted 34 lines · Gary Thomas
Quoted 26 lines · Joshua Lock
Quoted 18 lines · Yu Ke
Quoted 8 lines · Gary Thomas
Quoted 7 lines · Yu Ke

Hi,

bbappend file can be used to append content to bb file, and it is very useful in BSP meta data. Today I just find the *.inc file is also need to be appended, so I wonder if there
is similar incappend file that can append content to inc file?

Quoted 8 lines
Quoted 4 lines

I meet this requirement when trying to fix bug 896
(http://bugzilla.yoctoproject.org/show_bug.cgi?id=896). To make poky-image-clutter build pass in n450, the clutter.inc need to be appended to change the COMPATIBLE_MACHINE.

Why can't you just put the change in the .bbappend file (since it's already recipe/target specific)?

Quoted 6 lines

currently there is clutter 1.4 and clutter 1.6 which both use the clutter.inc. and yes, It is also fine to use duplicate bbappend to append clutter 1.4 and clutter 1.6 respectively. But if clutter.inc can be appended, then it will reduce the duplicate code. Also inc file append has another benefit, when clutter 1.8 is out in the future, the BSP append code don't need any change.

Quoted 6 lines

IIRC the common way to handle this now is to have shared code across versions in clutter.inc then have inc files for the major releases that require them (clutter-1.4.inc, clutter-1.6.inc, etc) and then have the version inc file include the core inc file.
The recipes would then include the appropriate inc file for the major version (1.6, etc) which they build.

Quoted 2 lines

How does that solve the problem that the .inc file needs to have BSP specific changes (which I find pretty abhorrent BTW)

If the .inc needs to change for a BSP, then it is by definition NOT common code. Sounds like the solution is to move anything in the .inc that needs changing out of the .inc and into the .bb files.

Signature · 3 lines
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel