musicpal: Fix registration of MMIO-less sysbus devices
PATCH 1/1 musicpal: Fix registration of MMIO-less sysbus devices
The proper way to signal that a sysbus devices need no MMIO region is to pass -1 to sysbus_create_simple.
Signed-off-by Jan Kiszka <[email protected]>
--- hw/musicpal.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
hw/musicpal.c +2 -2
@@ -1597,11 +1597,11 @@ static void musicpal_init(ram_addr_t ram_size,musicpal_misc_init (); dev =sysbus_create_simple ("musicpal_gpio" ,MP_GPIO_BASE , pic[MP_GPIO_IRQ ]); - i2c_dev =sysbus_create_simple ("gpio_i2c" ,0 ,NULL ); + i2c_dev =sysbus_create_simple ("gpio_i2c" ,-1 ,NULL ); i2c = (i2c_bus *)qdev_get_child_bus (i2c_dev,"i2c" ); lcd_dev =sysbus_create_simple ("musicpal_lcd" ,MP_LCD_BASE ,NULL ); - key_dev =sysbus_create_simple ("musicpal_key" ,0 ,NULL ); + key_dev =sysbus_create_simple ("musicpal_key" ,-1 ,NULL );/* I2C read data */ qdev_connect_gpio_out(i2c_dev, 0,
Signature · 1 line
1.7.1
Aurelien Jarno
AppliedQuoted 7 lines · Jan Kiszka
The proper way to signal that a sysbus devices need no MMIO region is to pass -1 to
sysbus_create_simple.Signed-off-by Jan Kiszka <[email protected]>--- hw/musicpal.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
Thanks, applied.
Quoted 21 lines
hw/musicpal.c +2
-2@@ -1597,11 +1597,11 @@ static void musicpal_init(ram_addr_t ram_size,musicpal_misc_init (); dev =sysbus_create_simple ("musicpal_gpio" ,MP_GPIO_BASE , pic[MP_GPIO_IRQ ]); - i2c_dev =sysbus_create_simple ("gpio_i2c" ,0 ,NULL ); + i2c_dev =sysbus_create_simple ("gpio_i2c" ,-1 ,NULL ); i2c = (i2c_bus *)qdev_get_child_bus (i2c_dev,"i2c" ); lcd_dev =sysbus_create_simple ("musicpal_lcd" ,MP_LCD_BASE ,NULL ); - key_dev =sysbus_create_simple ("musicpal_key" ,0 ,NULL ); + key_dev =sysbus_create_simple ("musicpal_key" ,-1 ,NULL );/* I2C read data */ qdev_connect_gpio_out(i2c_dev, 0,Signature · 1 line
1.7.1
Signature · 2 lines
Aurelien Jarno GPG: 1024D/F1BCDB73 [email protected] http://www.aurel32.net