Skip to contentSkip to conversation

kbuild: mark unicore32 header export as broken

PATCH In review Peter Foley 4 participants 6 messages Apr 24, 2011 – Apr 27, 2011 Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kbuild: mark unicore32 header export as broken

This patch marks userspace header export for unicore32 as broken so that it is skipped when running make headers_install_all.

---
 scripts/headers.sh |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
scripts/headers.sh +2 -0
index 978b42b..3ae218e 100755
@@ -21,6 +21,8 @@ for arch in ${archs}; do
 		;;
 	cris)      # headers export are known broken
 		;;
+	unicore32) # broken
+		;;
 	*)
 		if [ -d ${srctree}/arch/${arch} ]; then
 			do_command $1 ${arch}
Signature · 1 line
1.7.5.rc1
#1 lore raw

Hi,

Quoted 3 lines · Peter Foley

This patch marks userspace header export for unicore32 as broken so that it is skipped when running make headers_install_all.

Why ?

I would expect you to send this to arch/unicore32 maintainer too, he is not in the CC: list.

- Arnaud

Quoted 26 lines

---
 scripts/headers.sh |    2 ++

 1 files changed, 2 insertions(+), 0 deletions(-)
scripts/headers.sh +0 -0
index 978b42b..3ae218e 100755
@@ -21,6 +21,8 @@ for arch in ${archs}; do
                ;;

       cris)      # headers export are known broken ;;
+       unicore32) # broken
+               ;;
       *)
               if [ -d ${srctree}/arch/${arch} ]; then do_command $1 ${arch} --
1.7.5.rc1

--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

#2 lore raw
Quoted 10 lines · Arnaud Lacombe

Hi,

Quoted 3 lines · Peter Foley

This patch marks userspace header export for unicore32 as broken so that it is skipped when running make headers_install_all.

Why ?

I would expect you to send this to arch/unicore32 maintainer too, he is not in the CC: list.

+1

If you see errors when install kernel headers on unicore32, fix them instead of marking it as broken.

#3 lore raw
Quoted 9 lines · Américo Wang
Quoted 8 lines · Arnaud Lacombe

Hi,

Quoted 3 lines · Peter Foley

This patch marks userspace header export for unicore32 as broken so that it is skipped when running make headers_install_all.

Why ?

Quoted 7 lines
Quoted 2 lines

I would expect you to send this to arch/unicore32 maintainer too, he is not in the CC: list.

+1

If you see errors when install kernel headers on unicore32, fix them instead of marking it as broken.

The problem with unicore32 is that it generates various stub headers at compile time in include/generated/asm. I believe the unicore32 maintainer is already aware of headers_install not working (see https://lkml.org/lkml/2011/1/8/11).
I'm adding him to the CC list on this email.

#4 lore raw
Quoted 22 lines

-----Original Message-----
From: Peter Foley [mailto:[email protected]]
Sent: Wednesday, April 27, 2011 5:04 AM
To: Américo Wang
Cc: Arnaud Lacombe; [email protected]; [email protected]; [email protected]; [email protected]
Subject: Re: [PATCH] kbuild: mark unicore32 header export as broken

Quoted 12 lines · Américo Wang
Quoted 10 lines · Arnaud Lacombe

Hi,

Quoted 3 lines · Peter Foley

This patch marks userspace header export for unicore32 as broken so that it is skipped when running make headers_install_all.

Why ?

I would expect you to send this to arch/unicore32 maintainer too, he is not in the CC: list.

Quoted 7 lines
Quoted 4 lines

+1

If you see errors when install kernel headers on unicore32, fix them instead of marking it as broken.

The problem with unicore32 is that it generates various stub headers at compile time in include/generated/asm. I believe the unicore32 maintainer is already aware of headers_install not working (see https://lkml.org/lkml/2011/1/8/11).

Yes, thanks.
I am waiting for the generic-y patch by Sam. (also CC to Sam) Sorry to broke the rule of headers_install_all.

Thanks Peter. The patch not applied since I do need headers_install.

Thanks & Regards,

Guan Xuetao

#5 lore raw
In reply to Arnaud Lacombe
Quoted 6 lines · Arnaud Lacombe

Hi,

Quoted 3 lines · Peter Foley

This patch marks userspace header export for unicore32 as broken so that it is skipped when running make headers_install_all.

Quoted 7 lines

Why ?

I would expect you to send this to arch/unicore32 maintainer too, he is not in the CC: list.

- Arnaud

Sorry, I've CC'd him on this email.

The error I currently get is:

INSTALL include (0 file)
make[3]: *** No rule to make target /usr/src/git/arch/unicore32/include/asm/auxvec.h', needed by /root/linux/t/usr/include/asm/.install'. Stop. make[2]: *** [headers_install] Error 2
make[1]: *** [sub-make] Error 2
make: *** [all] Error 2

Patch below.

This patch marks userspace header export for unicore32 as broken so that it is skipped when running make headers_install_all.

---
 scripts/headers.sh |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
scripts/headers.sh +2 -0
index 978b42b..3ae218e 100755
@@ -21,6 +21,8 @@ for arch in ${archs}; do
 		;;
 	cris)      # headers export are known broken
 		;;
+	unicore32) # broken
+		;;
 	*)
 		if [ -d ${srctree}/arch/${arch} ]; then
 			do_command $1 ${arch}

-- 1.7.5.rc1