Skip to contentSkip to conversation

init: change EXPERT from menuconfig to config to remove an empty menu

PATCH New Peter Foley 2 participants 2 messages Apr 26, 2011

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 init: change EXPERT from menuconfig to config to remove an empty menu

This patch changes CONFIG_EXPERT from a menuconfig to a config because it no longer has any child items and is therefore an empty menu.

---
 init/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
init/Kconfig +1 -1
index 56240e7..332a2b3 100644
@@ -916,7 +916,7 @@ config SYSCTL
 config ANON_INODES
 	bool
 
-menuconfig EXPERT
+config EXPERT
 	bool "Configure standard kernel features (expert users)"
 	help
 	  This option allows certain base kernel options and settings
Signature · 1 line
1.7.5.rc1
#1 lore raw

PATCH 1/1 init: restore the EXPERT kconfig menu

Quoted 14 lines · On Mon, 25 Apr 2011 21:00:03 -0400 Peter Foley wrote:

This patch changes CONFIG_EXPERT from a menuconfig to a config because it no longer has any child items and is therefore an empty menu.

---
 init/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
init/Kconfig +0 -0
index 56240e7..332a2b3 100644

init/Kconfig config SYSCTL · line 922

Quoted 8 lines
init/Kconfig +1 -1
@@ -916,7 +916,7 @@ config SYSCTL
 config ANON_INODES
 	bool
 
-menuconfig EXPERT
+config EXPERT
 	bool "Configure standard kernel features (expert users)"
 	help
 	  This option allows certain base kernel options and settings

NAK. Just restore the EXPERT menu. Patch below.

---
From: Randy Dunlap <[email protected]>

Restore the EXPERT menu list -- don't inject a symbol (EMBEDDED) that does not depend on EXPERT into the list.

Cc David Rientjes <[email protected]>
---
 init/Kconfig |   16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)
init/Kconfig +8 -8
@@ -924,14 +924,6 @@ menuconfig EXPERT
           environments which can tolerate a "non-standard" kernel.
           Only use this if you really know what you are doing.
 
-config EMBEDDED
-	bool "Embedded system"
-	select EXPERT
-	help
-	  This option should be enabled if compiling the kernel for
-	  an embedded system so certain expert options are available
-	  for configuration.
-
 config UID16
 	bool "Enable 16-bit UID system calls" if EXPERT
 	depends on ARM || BLACKFIN || CRIS || FRV || H8300 || X86_32 || M68K || (S390 && !64BIT) || SUPERH || SPARC32 || (SPARC64 && COMPAT) || UML || (X86_64 && IA32_EMULATION)
@@ -1104,6 +1096,14 @@ config AIO
           by some high performance threaded applications. Disabling
           this option saves about 7k.
 
+config EMBEDDED
+	bool "Embedded system"
+	select EXPERT
+	help
+	  This option should be enabled if compiling the kernel for
+	  an embedded system so certain expert options are available
+	  for configuration.
+
 config HAVE_PERF_EVENTS
 	bool
 	help