Skip to contentSkip to conversation

ia64-kvm: fix sparse warnings

PATCH Applied Jeff Mahoney 3 participants 3 messages Apr 27, 2011 – Apr 28, 2011

lore
Share & tools
lore

Jeff Mahoney

author
#0 lore raw

PATCH 1/1 ia64-kvm: fix sparse warnings

This patch fixes some sparse warning about "dubious one-bit signed bitfield."

Signed-off-by Jeff Mahoney <[email protected]>
Originally-by Jan Blunck <[email protected]>
Signed-off-by Jan Blunck <[email protected]>
---
 arch/ia64/kvm/vti.h |   26 +++++++++++++-------------
 1 file changed, 13 insertions(+), 13 deletions(-)
arch/ia64/kvm/vti.h +13 -13
@@ -83,13 +83,13 @@
 union vac {
 	unsigned long value;
 	struct {
-		int a_int:1;
-		int a_from_int_cr:1;
-		int a_to_int_cr:1;
-		int a_from_psr:1;
-		int a_from_cpuid:1;
-		int a_cover:1;
-		int a_bsw:1;
+		unsigned int a_int:1;
+		unsigned int a_from_int_cr:1;
+		unsigned int a_to_int_cr:1;
+		unsigned int a_from_psr:1;
+		unsigned int a_from_cpuid:1;
+		unsigned int a_cover:1;
+		unsigned int a_bsw:1;
 		long reserved:57;
 	};
 };

@@ -97,12 +97,12 @@ union vac {
 union vdc {
 	unsigned long value;
 	struct {
-		int d_vmsw:1;
-		int d_extint:1;
-		int d_ibr_dbr:1;
-		int d_pmc:1;
-		int d_to_pmd:1;
-		int d_itm:1;
+		unsigned int d_vmsw:1;
+		unsigned int d_extint:1;
+		unsigned int d_ibr_dbr:1;
+		unsigned int d_pmc:1;
+		unsigned int d_to_pmd:1;
+		unsigned int d_itm:1;
 		long reserved:58;
 	};
 };
Signature · 2 lines
Jeff Mahoney
SUSE Labs
Acked-by on v1 1/1
#1 lore raw

Avi,
Can you take this patch to kvm.git ? Thanks!

Acked-by Xiantao Zhang <[email protected]>

-----Original Message-----
From: Jeff Mahoney [mailto:[email protected]]
Sent: Thursday, April 28, 2011 2:06 AM
To: Zhang, Xiantao; Avi Kivity; Luck, Tony; Yu, Fenghua
Cc: [email protected]
Subject: [PATCH] ia64-kvm: fix sparse warnings

This patch fixes some sparse warning about "dubious one-bit signed bitfield."

Signed-off-by Jeff Mahoney <[email protected]>
Originally-by Jan Blunck <[email protected]>
Signed-off-by Jan Blunck <[email protected]>
---
 arch/ia64/kvm/vti.h |   26 +++++++++++++-------------
 1 file changed, 13 insertions(+), 13 deletions(-)
arch/ia64/kvm/vti.h +13 -13
@@ -83,13 +83,13 @@
 union vac {
 	unsigned long value;
 	struct {
-		int a_int:1;
-		int a_from_int_cr:1;
-		int a_to_int_cr:1;
-		int a_from_psr:1;
-		int a_from_cpuid:1;
-		int a_cover:1;
-		int a_bsw:1;
+		unsigned int a_int:1;
+		unsigned int a_from_int_cr:1;
+		unsigned int a_to_int_cr:1;
+		unsigned int a_from_psr:1;
+		unsigned int a_from_cpuid:1;
+		unsigned int a_cover:1;
+		unsigned int a_bsw:1;
 		long reserved:57;
 	};
 };

@@ -97,12 +97,12 @@ union vac {
 union vdc {
 	unsigned long value;
 	struct {
-		int d_vmsw:1;
-		int d_extint:1;
-		int d_ibr_dbr:1;
-		int d_pmc:1;
-		int d_to_pmd:1;
-		int d_itm:1;
+		unsigned int d_vmsw:1;
+		unsigned int d_extint:1;
+		unsigned int d_ibr_dbr:1;
+		unsigned int d_pmc:1;
+		unsigned int d_to_pmd:1;
+		unsigned int d_itm:1;
 		long reserved:58;
 	};
 };
Signature · 2 lines
Jeff Mahoney
SUSE Labs
Applied
#2 lore raw
In reply to Jeff Mahoney
Quoted 1 line · Jeff Mahoney

This patch fixes some sparse warning about "dubious one-bit signed bitfield."

Thanks, applied.

Signature · 1 line
error compiling committee.c: too many arguments to function