Skip to contentSkip to conversation

Anysee

GIT PULL Antti Palosaari 2 participants 5 messages Apr 29, 2011 – Jun 1, 2011 Media (V4L/DVB)

lore
Share & tools
lore
#0 lore raw

Moikka Mauro,

PULL following patches for the 2.6.40.

This basically adds support for two Anysee satellite models:
1. E30 S2 Plus
2. E7 S2

t. Antti

The following changes since commit f5bc5d1d4730bce69fbfdc8949ff50b49c70d934:

anysee: add more info about known board configs (2011-04-13 02:17:11
+0300)

are available in the git repository at:
git://linuxtv.org/anttip/media_tree.git anysee

Antti Palosaari (3):
cx24116: add config option to split firmware download
anysee: add support for Anysee E30 S2 Plus
anysee: add support for Anysee E7 S2

 drivers/media/dvb/dvb-usb/Kconfig     |    4 +
 drivers/media/dvb/dvb-usb/anysee.c    |  103 
+++++++++++++++++++++++++++++++++
 drivers/media/dvb/dvb-usb/anysee.h    |    1 +
 drivers/media/dvb/frontends/cx24116.c |   17 +++++-
 drivers/media/dvb/frontends/cx24116.h |    3 +
 5 files changed, 125 insertions(+), 3 deletions(-)
Signature · 1 line
http://palosaari.fi/
#1 lore raw

Em 29-04-2011 14:05, Antti Palosaari escreveu:

Quoted 15 lines

Moikka Mauro,

PULL following patches for the 2.6.40.

This basically adds support for two Anysee satellite models:
1. E30 S2 Plus
2. E7 S2

t. Antti

The following changes since commit f5bc5d1d4730bce69fbfdc8949ff50b49c70d934:

anysee: add more info about known board configs (2011-04-13 02:17:11 +0300)

Quoted 7 lines

are available in the git repository at:
git://linuxtv.org/anttip/media_tree.git anysee

Antti Palosaari (3):
cx24116: add config option to split firmware download
anysee: add support for Anysee E30 S2 Plus
anysee: add support for Anysee E7 S2

As I said you on irc, at cx24116, please add a logic to explicitly check if I2C size is equal to zero. While your logic works, it is tricky, and having a more readable code at the expense of something like:

	if (i2c_max == 0)
		i2c_max = 65535;

seems to be the right thing to do.

Thanks,
Mauro.

#2 lore raw

Updated PULL requested!

Cc Steven Toth as cx24116 driver author.
Quoted 24 lines · Mauro Carvalho Chehab

Em 29-04-2011 14:05, Antti Palosaari escreveu:

Quoted 15 lines

Moikka Mauro,

PULL following patches for the 2.6.40.

This basically adds support for two Anysee satellite models:
1. E30 S2 Plus
2. E7 S2

t. Antti

The following changes since commit f5bc5d1d4730bce69fbfdc8949ff50b49c70d934:

anysee: add more info about known board configs (2011-04-13 02:17:11 +0300)

Quoted 7 lines

are available in the git repository at:
git://linuxtv.org/anttip/media_tree.git anysee

Antti Palosaari (3):
cx24116: add config option to split firmware download
anysee: add support for Anysee E30 S2 Plus
anysee: add support for Anysee E7 S2

Quoted 7 lines

As I said you on irc, at cx24116, please add a logic to explicitly check if I2C size is equal to zero. While your logic works, it is tricky, and having a more readable code at the expense of something like:

	if (i2c_max == 0)
		i2c_max = 65535;

seems to be the right thing to do.

For some reason as I mentioned on IRC, this change increases binary size 52 bytes, whilst functionality remains same. Feel free to select this new or old patch.

t. Antti

The following changes since commit f5bc5d1d4730bce69fbfdc8949ff50b49c70d934:

anysee: add more info about known board configs (2011-04-13 02:17:11
+0300)

are available in the git repository at:
git://linuxtv.org/anttip/media_tree.git anysee

Antti Palosaari (4):
cx24116: add config option to split firmware download
anysee: add support for Anysee E30 S2 Plus
anysee: add support for Anysee E7 S2
cx24116: make FW DL split more readable

 drivers/media/dvb/dvb-usb/Kconfig     |    4 +
 drivers/media/dvb/dvb-usb/anysee.c    |  103 
+++++++++++++++++++++++++++++++++
 drivers/media/dvb/dvb-usb/anysee.h    |    1 +
 drivers/media/dvb/frontends/cx24116.c |   19 +++++-
 drivers/media/dvb/frontends/cx24116.h |    3 +
 5 files changed, 127 insertions(+), 3 deletions(-)
Signature · 1 line
http://palosaari.fi/
#3 lore raw
In reply to Mauro Carvalho Chehab

Moikka Mauro,

Two new models and some fixes.

The following changes since commit 87cf028f3aa1ed51fe29c36df548aa714dc7438f:

[media] dm1105: GPIO handling added, I2C on GPIO added, LNB control
through GPIO reworked (2011-05-21 11:10:28 -0300)

are available in the git repository at:
git://linuxtv.org/anttip/media_tree.git anysee

Antti Palosaari (4):
anysee: return EOPNOTSUPP for unsupported I2C messages
anysee: add support for Anysee E7 PTC
anysee: add support for Anysee E7 PS2
anysee: style issues, comments, etc.

 drivers/media/dvb/dvb-usb/anysee.c |   86 
++++++++++++++++++++++++++----------
 drivers/media/dvb/dvb-usb/anysee.h |   16 ++++---
 2 files changed, 71 insertions(+), 31 deletions(-)

t. Antti

Signature · 1 line
http://palosaari.fi/
#4 lore raw

Em 25-05-2011 18:43, Antti Palosaari escreveu:

Quoted 7 lines

Moikka Mauro,

Two new models and some fixes.

The following changes since commit 87cf028f3aa1ed51fe29c36df548aa714dc7438f:

Quoted 7 lines

[media] dm1105: GPIO handling added, I2C on GPIO added, LNB control through GPIO reworked (2011-05-21 11:10:28 -0300)

are available in the git repository at:
git://linuxtv.org/anttip/media_tree.git anysee

Antti Palosaari (4):
anysee: return EOPNOTSUPP for unsupported I2C messages

This one is a bug fix. I'm adding it on my queue for 3.0.

A side note: you're using the stack for the I2C transfers. If the stack buffer is used also on a URB transfer, it may fail on x86 architecture and it will for sure fail on arm architectures, as the stack memory is not safe for DMA transfers.

Quoted 8 lines

anysee: add support for Anysee E7 PTC
anysee: add support for Anysee E7 PS2
anysee: style issues, comments, etc.

 drivers/media/dvb/dvb-usb/anysee.c |   86 ++++++++++++++++++++++++++----------
 drivers/media/dvb/dvb-usb/anysee.h |   16 ++++---
 2 files changed, 71 insertions(+), 31 deletions(-)

Cheers,
Mauro