Skip to contentSkip to conversation

Patch 6853/1 incorrectly moved to superseeded ?

DISCUSSION Viktor Rosendahl 3 participants 3 messages May 2, 2011

lore
Share & tools
lore
#0 lore raw

Hello Russell,

I got a message that you moved my patch "Patch 6853/1: Fix ldrd/strd emulation for kprobes" to superseeded based on the assumption that it would have been superseeded by John Medhurst's patch "ARM: kprobes: Fix emulation of LDRD and STRD instructions".

However, when I look at John's patch, it seems to me that his patch is supposed to sit on top of my patch, not to replacing it.

Nicolas and Tixy, feel free to correct me if I am wrong.

best regards,

Viktor

#1 lore raw
Quoted 11 lines · Viktor Rosendahl

Hello Russell,

I got a message that you moved my patch "Patch 6853/1: Fix ldrd/strd emulation for kprobes" to superseeded based on the assumption that it would have been superseeded by John Medhurst's patch "ARM: kprobes: Fix emulation of LDRD and STRD instructions".

However, when I look at John's patch, it seems to me that his patch is supposed to sit on top of my patch, not to replacing it.

Nicolas and Tixy, feel free to correct me if I am wrong.

I picked up a patch called "Fix ldrd/strd emulation" from you on the mailing list and included it in the kprobes branches along with Tixy's patches for RMK to pull. So I suppose that RMK discarded it from the patch system on that basis.

Nicolas

#2 lore raw
In reply to Viktor Rosendahl
Quoted 11 lines · Viktor Rosendahl

Hello Russell,

I got a message that you moved my patch "Patch 6853/1: Fix ldrd/strd emulation for kprobes" to superseeded based on the assumption that it would have been superseeded by John Medhurst's patch "ARM: kprobes: Fix emulation of LDRD and STRD instructions".

However, when I look at John's patch, it seems to me that his patch is supposed to sit on top of my patch, not to replacing it.

Nicolas and Tixy, feel free to correct me if I am wrong.

Viktor is correct. My patches were applied on top of his, and both are required for the code to work correctly.

However, Nicolas put Viktor's patch into his branch together with my patches, so it may be that the pull from Nicolas' branch will also get Viltor's patch. Meaning that patch 6853/1 doesn't need to be applied as well.(?)

Signature · 1 line
Tixy