Documenting the CONFIG_MACH_TYPE variable
Hi Wolfgang,
While looking at how to document the CONFIG_MACH_TYPE variable,
I caught myself wondering, why don't we provide an option to set
this variable in board config file and set the bi_arch_number field in
a more generic location (e.g. arch/arm/lib/board.c: board_init_f()),
then it is right now (in each board's board_init() function)?
Will such thing be accepted?
Are there any problems with it?
Have anyone tried this in the past?
Signature · 2 lines
Regards, Igor.
Dear Igor Grinberg,
Quoted 6 lines · In message <[email protected]> you wrote:
While looking at how to document the
CONFIG_MACH_TYPEvariable, I caught myself wondering, why don't we provide an option to set this variable in board config file and set thebi_arch_numberfield in a more generic location (e.g.arch/arm/lib/board.c:board_init_f()), then it is right now (in each board'sboard_init()function)?
"Historic reasons", probably.
Quoted 1 line
Will such thing be accepted?
Why not.
Quoted 3 lines
Are there any problems with it?
Have anyone tried this in the past?
Not that I know of.
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
What about WRITING it first and rationalizing it afterwords? :-)
- Larry Wall in <[email protected]>Hi Wolfgang,
Quoted 10 lines · Wolfgang Denk
Dear Igor Grinberg,
Quoted 5 lines · In message <[email protected]> you wrote:
While looking at how to document the
CONFIG_MACH_TYPEvariable, I caught myself wondering, why don't we provide an option to set this variable in board config file and set thebi_arch_numberfield in a more generic location (e.g.arch/arm/lib/board.c:board_init_f()), then it is right now (in each board'sboard_init()function)?"Historic reasons", probably.
Quoted 7 lines
Quoted 1 line
Will such thing be accepted?
Why not.
Quoted 3 lines
Are there any problems with it?
Have anyone tried this in the past?
Not that I know of.
Thanks, I'll send a patch in a couple of days.
Signature · 2 lines
Regards, Igor.