Skip to contentSkip to conversation

AT91: Add external RTC for Flexibity board

PATCH In review Maxim Osipov 5 participants 8 messages May 7, 2011 – Oct 17, 2011

Subsystems (3)
Arm (32-bit) Arm sub-architectures Arm/Microchip (AT91) SoC support
lore
Share & tools
lore

Maxim Osipov

author
#0 lore raw

PATCH 1/1 AT91: Add external RTC for Flexibity board

Hello,

This patch enables external RTC support on AT91 Flexibity board.

Kind regards,
Maxim

Signed-off-by Maxim Osipov <[email protected]>
---
 arch/arm/mach-at91/board-flexibity.c |   12 +++++++++++-
 1 files changed, 11 insertions(+), 1 deletions(-)
arch/arm/mach-at91/board-flexibity.c +11 -1
index c8a62dc..4fdc96c 100644
@@ -1,7 +1,7 @@
 /*
  * linux/arch/arm/mach-at91/board-flexibity.c
  *
- *  Copyright (C) 2010 Flexibity
+ *  Copyright (C) 2010-2011 Flexibity
  *  Copyright (C) 2005 SAN People
  *  Copyright (C) 2006 Atmel
  *

@@ -65,6 +65,13 @@ static struct at91_udc_data __initdata flexibity_udc_data = {
 	.pullup_pin	= 0,		/* pull-up driven by UDC */
 };
 
+/* I2C devices */
+static struct i2c_board_info __initdata flexibity_i2c_devices[] = {
+	{
+		I2C_BOARD_INFO("ds1307", 0x68),
+	},
+};
+
 /* SPI devices */
 static struct spi_board_info flexibity_spi_devices[] = {
 	{	/* DataFlash chip */

@@ -143,6 +150,9 @@ static void __init flexibity_board_init(void)
 	at91_add_device_usbh(&flexibity_usbh_data);
 	/* USB Device */
 	at91_add_device_udc(&flexibity_udc_data);
+	/* I2C */
+	at91_add_device_i2c(flexibity_i2c_devices,
+		ARRAY_SIZE(flexibity_i2c_devices));
 	/* SPI */
 	at91_add_device_spi(flexibity_spi_devices,
 		ARRAY_SIZE(flexibity_spi_devices));
Signature · 1 line
1.7.4.1
author
#1 lore raw

Hi,

Quoted 39 lines · Maxim Osipov

This patch enables external RTC support on AT91 Flexibity board.

Signed-off-by Maxim Osipov <[email protected]>

---
?arch/arm/mach-at91/board-flexibity.c | ? 12 +++++++++++- ?1 files changed, 11 insertions(+), 1 deletions(-)

arch/arm/mach-at91/board-flexibity.c +0 -0
index c8a62dc..4fdc96c 100644
@@ -1,7 +1,7 @@

?/*
?* linux/arch/arm/mach-at91/board-flexibity.c
?*
- * ?Copyright (C) 2010 Flexibity
+ * ?Copyright (C) 2010-2011 Flexibity
?* ?Copyright (C) 2005 SAN People
?* ?Copyright (C) 2006 Atmel
?*

arch/arm/mach-at91/board-flexibity.c +0 -0
@@ -65,6 +65,13 @@ static struct at91_udc_data __initdata flexibity_udc_data = {

? ? ? ?.pullup_pin ? ? = 0, ? ? ? ? ? ?/* pull-up driven by UDC */ ?};

arch/arm/mach-at91/board-flexibity.c +7 -0
+/* I2C devices */
+static struct i2c_board_info __initdata flexibity_i2c_devices[] = {
+ ? ? ? {
+ ? ? ? ? ? ? ? I2C_BOARD_INFO("ds1307", 0x68),
+ ? ? ? },
+};
+

?/* SPI devices */
?static struct spi_board_info flexibity_spi_devices[] = { ? ? ? ?{ ? ? ? /* DataFlash chip */

arch/arm/mach-at91/board-flexibity.c +0 -0
@@ -143,6 +150,9 @@ static void __init flexibity_board_init(void)
 ? ? ? ?at91_add_device_usbh(&flexibity_usbh_data);

? ? ? ?/* USB Device */
? ? ? ?at91_add_device_udc(&flexibity_udc_data);

Quoted 10 lines

+ ? ? ? /* I2C */
+ ? ? ? at91_add_device_i2c(flexibity_i2c_devices,
+ ? ? ? ? ? ? ? ARRAY_SIZE(flexibity_i2c_devices)); ? ? ? ?/* SPI */
? ? ? ?at91_add_device_spi(flexibity_spi_devices, ? ? ? ? ? ? ? ?ARRAY_SIZE(flexibity_spi_devices)); --
1.7.4.1

If no comments on the patch - could someone commit it please? Or should I submit it to the Russell's patch tracking system?

Kind regards,
Maxim

#2 lore raw
In reply to Maxim Osipov
Quoted 27 lines · Maxim Osipov

Hello,

This patch enables external RTC support on AT91 Flexibity board.

Kind regards,
Maxim

Signed-off-by Maxim Osipov <[email protected]>
---
 arch/arm/mach-at91/board-flexibity.c |   12 +++++++++++-
 1 files changed, 11 insertions(+), 1 deletions(-)
arch/arm/mach-at91/board-flexibity.c +1 -1
index c8a62dc..4fdc96c 100644
@@ -1,7 +1,7 @@
 /*
  * linux/arch/arm/mach-at91/board-flexibity.c
  *
- *  Copyright (C) 2010 Flexibity
+ *  Copyright (C) 2010-2011 Flexibity
  *  Copyright (C) 2005 SAN People
  *  Copyright (C) 2006 Atmel
  *

arch/arm/mach-at91/board-flexibity.c static struct at91_udc_data __initdata flexibity_udc_data = { · line 74

Quoted 10 lines
arch/arm/mach-at91/board-flexibity.c +7 -0
@@ -65,6 +65,13 @@ static struct at91_udc_data __initdata flexibity_udc_data = {
 	.pullup_pin	= 0,		/* pull-up driven by UDC */
 };
 
+/* I2C devices */
+static struct i2c_board_info __initdata flexibity_i2c_devices[] = {
+	{
+		I2C_BOARD_INFO("ds1307", 0x68),
+	},
+};
+

looks fine just one comment please add your board to the new at91sam9260_defconfig

so we can compile it when compiling all the sam9260

Best Regards,
J.

Acked-by
#3 lore raw

hi,

Quoted 1 line
Quoted 1 line

This patch enables external RTC support on AT91 Flexibity board.

Acked-by Andrew Victor <[email protected]>

Maxim: You can submit it to Russell's patch system.

Quoted 1 line

looks fine just one comment please add your board to the new at91sam9260_defconfig

That file does not exist in any mainline kernel.

Regards,
Andrew Victor

#4 lore raw

Le 11/05/2011 09:44, Andrew Victor :

Quoted 11 lines

hi,

Quoted 1 line
Quoted 1 line

This patch enables external RTC support on AT91 Flexibity board.

Acked-by Andrew Victor <[email protected]>

Maxim: You can submit it to Russell's patch system.

Quoted 1 line

looks fine just one comment please add your board to the new at91sam9260_defconfig

That file does not exist in any mainline kernel.

Absolutely, we will come back on this when this common defconfig will be properly included in mainline.

Bye,

Signature · 1 line
Nicolas Ferre
#5 lore raw
In reply to Andrew Victor
Quoted 4 lines · Andrew Victor

hi,

Quoted 1 line
Quoted 1 line

This patch enables external RTC support on AT91 Flexibity board.

Quoted 8 lines
Acked-by Andrew Victor <[email protected]>

Maxim: You can submit it to Russell's patch system.

Quoted 1 line

looks fine just one comment please add your board to the new at91sam9260_defconfig

That file does not exist in any mainline kernel.

It's been a while since this patch went into the patch system, and it didn't get applied for various reasons, including because it looked like it was sent there without any review (no acked-by's etc added to it.)

What's the status of this - and if its still relevant can we have it with the proper attributations please?

author
#6 lore raw

Ok, I'll do it. Thanks!
Maxim

Quoted 22 lines · Russell King - ARM Linux
Quoted 4 lines · Andrew Victor

hi,

Quoted 1 line
Quoted 1 line

This patch enables external RTC support on AT91 Flexibity board.

Quoted 8 lines
Acked-by Andrew Victor <[email protected]>

Maxim: You can submit it to Russell's patch system.

Quoted 1 line

looks fine just one comment please add your board to the new at91sam9260_defconfig

That file does not exist in any mainline kernel.

It's been a while since this patch went into the patch system, and it didn't get applied for various reasons, including because it looked like it was sent there without any review (no acked-by's etc added to it.)

What's the status of this - and if its still relevant can we have it with the proper attributations please?

#7 lore raw
In reply to Russell King - ARM Linux
Quoted 14 lines · Russell King - ARM Linux
Quoted 4 lines · Andrew Victor

hi,

Quoted 1 line
Quoted 1 line

This patch enables external RTC support on AT91 Flexibity board.

Quoted 8 lines
Acked-by Andrew Victor <[email protected]>

Maxim: You can submit it to Russell's patch system.

Quoted 1 line

looks fine just one comment please add your board to the new at91sam9260_defconfig

That file does not exist in any mainline kernel.

Quoted 7 lines

It's been a while since this patch went into the patch system, and it didn't get applied for various reasons, including because it looked like it was sent there without any review (no acked-by's etc added to it.)

What's the status of this - and if its still relevant can we have it with the proper attributations please

This patch is already in Arnd tree IIRC

Best Regards,
J.