Skip to contentSkip to conversation

v4l2 subdev driver for Samsung S5P MIPI CSI receiver

GIT PULL Sylwester Nawrocki 3 participants 3 messages May 13, 2011 – May 15, 2011 Media (V4L/DVB)

lore
Share & tools
lore
#0 lore raw

Hi Mauro,

The following changes since commit f9b51477fe540fb4c65a05027fdd6f2ecce4db3b:

[media] DVB: return meaningful error codes in dvb_frontend (2011-05-09 05:47:20 +0200)

are available in the git repository at:
git://git.infradead.org/users/kmpark/linux-2.6-samsung s5p-csis

Sylwester Nawrocki (3):
v4l: Add V4L2_MBUS_FMT_JPEG_1X8 media bus format
v4l: Move s5p-fimc driver into Video capture devices
v4l: Add v4l2 subdev driver for S5P/EXYNOS4 MIPI-CSI receivers

It's a new driver for MIPI CSI receiver available in S5PVxxx/EXYNOS4 SoCs. The first patch adds definition of a media bus code for JPEG format.

I've done three further driver amendments comparing to the last (v5) version posted on the mailing lists, i.e.:
- slightly improved description of struct csis_state
- moved the pad number check from __s5pcsis_get_format directly to set_fmt/get_fmt pad level operation handlers
- replaced __init attribute of s5pcsis_probe() with __devinit and added __devexit for s5pcsis_remove()

Gitweb: http://git.infradead.org/users/kmpark/linux-2.6-samsung/shortlog/refs/heads/s5p-csis

 Documentation/DocBook/v4l/subdev-formats.xml |   46 ++
 drivers/media/video/Kconfig                  |   28 +-
 drivers/media/video/s5p-fimc/Makefile        |    6 +-
 drivers/media/video/s5p-fimc/mipi-csis.c     |  725 ++++++++++++++++++++++++++
 drivers/media/video/s5p-fimc/mipi-csis.h     |   22 +
 include/linux/v4l2-mediabus.h                |    3 +
 6 files changed, 820 insertions(+), 10 deletions(-)
 create mode 100644 drivers/media/video/s5p-fimc/mipi-csis.c
 create mode 100644 drivers/media/video/s5p-fimc/mipi-csis.h

--
Regards,
Sylwester Nawrocki
Samsung Poland R&D Center

#1 lore raw

Hi Sylwester,

Quoted 19 lines · On Friday 13 May 2011 18:15:42 Sylwester Nawrocki wrote:

Hi Mauro,

The following changes since commit
f9b51477fe540fb4c65a05027fdd6f2ecce4db3b:

[media] DVB: return meaningful error codes in dvb_frontend (2011-05-09
05:47:20 +0200)

are available in the git repository at:
git://git.infradead.org/users/kmpark/linux-2.6-samsung s5p-csis

Sylwester Nawrocki (3):
v4l: Add V4L2_MBUS_FMT_JPEG_1X8 media bus format
v4l: Move s5p-fimc driver into Video capture devices
v4l: Add v4l2 subdev driver for S5P/EXYNOS4 MIPI-CSI receivers

It's a new driver for MIPI CSI receiver available in S5PVxxx/EXYNOS4 SoCs. The first patch adds definition of a media bus code for JPEG format.

Quoted 7 lines

I've done three further driver amendments comparing to the last (v5) version posted on the mailing lists, i.e.:
- slightly improved description of struct csis_state
- moved the pad number check from __s5pcsis_get_format directly to
set_fmt/get_fmt pad level operation handlers
- replaced __init attribute of s5pcsis_probe() with __devinit and added __devexit for s5pcsis_remove()

I've reviewed the patches yesterday, I think there's still a couple of small issues you might want to address.

Quoted 15 lines

Gitweb:
http://git.infradead.org/users/kmpark/linux-2.6-samsung/shortlog/refs/head
s/s5p-csis

 Documentation/DocBook/v4l/subdev-formats.xml |   46 ++
 drivers/media/video/Kconfig                  |   28 +-
 drivers/media/video/s5p-fimc/Makefile        |    6 +-
 drivers/media/video/s5p-fimc/mipi-csis.c     |  725
++++++++++++++++++++++++++ drivers/media/video/s5p-fimc/mipi-csis.h     | 
 22 +
 include/linux/v4l2-mediabus.h                |    3 +
 6 files changed, 820 insertions(+), 10 deletions(-)
 create mode 100644 drivers/media/video/s5p-fimc/mipi-csis.c
 create mode 100644 drivers/media/video/s5p-fimc/mipi-csis.h
Signature · 3 lines
Regards,

Laurent Pinchart
#2 lore raw

Hi Laurent,

Quoted 28 lines · Laurent Pinchart
Quoted 19 lines · On Friday 13 May 2011 18:15:42 Sylwester Nawrocki wrote:

Hi Mauro,

The following changes since commit
f9b51477fe540fb4c65a05027fdd6f2ecce4db3b:

[media] DVB: return meaningful error codes in dvb_frontend (2011-05-09
05:47:20 +0200)

are available in the git repository at:
git://git.infradead.org/users/kmpark/linux-2.6-samsung s5p-csis

Sylwester Nawrocki (3):
v4l: Add V4L2_MBUS_FMT_JPEG_1X8 media bus format
v4l: Move s5p-fimc driver into Video capture devices
v4l: Add v4l2 subdev driver for S5P/EXYNOS4 MIPI-CSI receivers

It's a new driver for MIPI CSI receiver available in S5PVxxx/EXYNOS4 SoCs. The first patch adds definition of a media bus code for JPEG format.

Quoted 7 lines

I've done three further driver amendments comparing to the last (v5) version posted on the mailing lists, i.e.:
- slightly improved description of struct csis_state
- moved the pad number check from __s5pcsis_get_format directly to
set_fmt/get_fmt pad level operation handlers
- replaced __init attribute of s5pcsis_probe() with __devinit and added __devexit for s5pcsis_remove()

Quoted 2 lines

I've reviewed the patches yesterday, I think there's still a couple of small issues you might want to address.

Yeah, I've noticed that ;-) Thanks for getting back to this.

Mauro, please ignore this pull request, my apologies for he noise.

--
Regards,
Sylwester Nawrocki