Skip to contentSkip to conversation

rtlwifi: Synchronize IRQ after disabling it

PATCH In review Mike McCormack 2 participants 2 messages May 23, 2011 Networking drivers (wireless)

lore
Share & tools
lore
#0 lore raw

PATCH 1/8 rtlwifi: Synchronize IRQ after disabling it

This make sure any IRQ handlers running on other CPUs complete.

---
 drivers/net/wireless/rtlwifi/rtl8192ce/hw.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/net/wireless/rtlwifi/rtl8192ce/hw.c +1 -0
index 4a56138..87b8a79 100644
@@ -1196,6 +1196,7 @@ void rtl92ce_disable_interrupt(struct ieee80211_hw *hw)
 	rtl_write_dword(rtlpriv, REG_HIMR, IMR8190_DISABLED);
 	rtl_write_dword(rtlpriv, REG_HIMRE, IMR8190_DISABLED);
 	rtlpci->irq_enabled = false;
+	synchronize_irq(rtlpci->pdev->irq);
 }
 
 static void _rtl92ce_poweroff_adapter(struct ieee80211_hw *hw)
Signature · 1 line
1.7.4.1
#1 lore raw
Quoted 12 lines · Mike McCormack

This make sure any IRQ handlers running on other CPUs complete.

---
  drivers/net/wireless/rtlwifi/rtl8192ce/hw.c |    1 +
  1 files changed, 1 insertions(+), 0 deletions(-)
drivers/net/wireless/rtlwifi/rtl8192ce/hw.c +0 -0
index 4a56138..87b8a79 100644

drivers/net/wireless/rtlwifi/rtl8192ce/hw.c void rtl92ce_disable_interrupt(struct ieee80211_hw *hw) · line 1202

Quoted 7 lines
drivers/net/wireless/rtlwifi/rtl8192ce/hw.c +1 -0
@@ -1196,6 +1196,7 @@ void rtl92ce_disable_interrupt(struct ieee80211_hw *hw)
  	rtl_write_dword(rtlpriv, REG_HIMR, IMR8190_DISABLED);
  	rtl_write_dword(rtlpriv, REG_HIMRE, IMR8190_DISABLED);
  	rtlpci->irq_enabled = false;
+	synchronize_irq(rtlpci->pdev->irq);
  }
 
  static void _rtl92ce_poweroff_adapter(struct ieee80211_hw *hw)

There is a similar construct in rtl8192se, but I will submit that patch.

Larry