compare cluster name in cman daemon
PATCH 1/1 compare cluster name in cman daemon
if length of cluster name = 16, last char of msg->clustername will not be zero.
In this case strcmp will continue read member fence_agent from cl_transmsg structure.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix-compare-clustername.diff
Type: text/x-patch
Size: 574 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/cluster-devel/attachments/20110525/55fdb480/attachment.bin>
PATCH 1/1 compare cluster name in cman daemon
Quoted 6 lines · Evgeniy Sokolov
if length of cluster name = 16, last char of
msg->clusternamewill not be zero.
In this case strcmp will continue read memberfence_agentfromcl_transmsgstructure.
If the length of the cluster name = 16 then there is a bug somewhere else that needs fixing ;-)
Chrissie
PATCH 1/1 compare cluster name in cman daemon
Quoted 8 lines · Christine Caulfield
Quoted 6 lines · Evgeniy Sokolov
if length of cluster name = 16, last char of
msg->clusternamewill not be zero.
In this case strcmp will continue read memberfence_agentfromcl_transmsgstructure.
Quoted 6 lines
If the length of the cluster name = 16 then there is a bug somewhere else that needs fixing ;-)
Chrissie
Design of cl_transmsg->clustername[16] is string with max length 15 + 1 char for zero. Is it correct?
PATCH 1/1 compare cluster name in cman daemon
Quoted 12 lines · Evgeniy Sokolov
Quoted 11 lines · Christine Caulfield
Quoted 6 lines · Evgeniy Sokolov
if length of cluster name = 16, last char of
msg->clusternamewill not be zero.
In this case strcmp will continue read memberfence_agentfromcl_transmsgstructure.If the length of the cluster name = 16 then there is a bug somewhere else that needs fixing ;-)
Quoted 6 lines
Quoted 3 lines
Chrissie
Design of cl_transmsg->clustername[16] is string with max length 15 + 1 char for zero. Is it correct?
Christine, can you answer the question?
PATCH 1/1 compare cluster name in cman daemon
Quoted 13 lines · Evgeniy Sokolov
Quoted 12 lines · Evgeniy Sokolov
Quoted 11 lines · Christine Caulfield
Quoted 6 lines · Evgeniy Sokolov
if length of cluster name = 16, last char of
msg->clusternamewill not be zero.
In this case strcmp will continue read memberfence_agentfromcl_transmsgstructure.If the length of the cluster name = 16 then there is a bug somewhere else that needs fixing ;-)
Quoted 8 lines
Quoted 6 lines
Quoted 3 lines
Chrissie
Design of cl_transmsg->clustername[16] is string with max length 15 + 1 char for zero. Is it correct?
Christine, can you answer the question?
Yes, that's correct.
Chrissie
PATCH 1/1 compare cluster name in cman daemon
In reply to Christine CaulfieldFor example, in user's mind or in incoming parameters parsing, do you mean this?
Where does this limitation come from?
Quoted 10 lines · On Wednesday 25 May 2011 12:05:05 Christine Caulfield wrote:
Quoted 4 lines · Evgeniy Sokolov
if length of cluster name = 16, last char of
msg->clusternamewill not be zero.
In this case strcmp will continue read memberfence_agentfromcl_transmsgstructure.If the length of the cluster name = 16 then there is a bug somewhere else that needs fixing ;-)
Chrissie
Signature · 2 lines
Thanks, Dmitry.