Possible bug in sdio.c?

Hi Michał,

In mmc/core/sdio.c, routine mmc_enable_4bit_bus():

I think:

    if (card->type == MMC_TYPE_SDIO)
              return sdio_enable_wide(card);

should really be:

    if (card->type == MMC_TYPE_SDIO || card->type == MMC_TYPE_SD_COMBO )
               return sdio_enable_wide(card);

Otherwise, the SDIO component of the SD Combo card will not operate in wide mode. What do you think?

Perhaps a similar change is needed in the sdio_enable_hs() routine too.

Thanks,
Prashanth

ps: I am sorry to be emailing you directly with questions/bug reports. What is the formal process of reporting suggestions for code change?

Hi,

You sent similar problem report some time ago. I assumed you will follow on with a patch fixing mmc_card_sd() and friends (the functions you point out in this mail should use that).

Best Regards,
Michał Mirosław

Thanks for the reply. Are there other places where this new function must be used? Is it only these 2 places?

Could you please clarify the formal process for including these changes into the build? I have made the previous changes in my private code tree only so far.

Thanks,
Prashanth

Hi,

See Documentation/SubmittingPatches, and send the patch you generate to the same list of e-mail addresses you're using here.

If you have a git commit corresponding to the patch, you can use git send-email or git format-patch to generate the patch file.

Thanks,

- Chris.

Chris Ball   <[email protected]>   <http://printf.net/>
One Laptop Per Child