Skip to contentSkip to conversation

possible memory corruption in cifs_parse_mount_options()

CIFS Vasily Averin 2 participants 2 messages Jun 6, 2011 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

error path after mountdata check frees uninitialized mountdata_copy

---
 fs/cifs/connect.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
fs/cifs/connect.c +0 -0
index 6d88b82..dd5e33e 100644
@@ -784,7 +784,7 @@ cifs_parse_mount_options(const char *mountdata, const char

*devname,
struct smb_vol *vol)
{
char *value, *data, *end;
- char *mountdata_copy, *options;
+ char *mountdata_copy = NULL, *options;
unsigned int temp_len, i, j;
char separator[2];
short int override_uid = -1;

Signature · 1 line
1.7.4.1

A message that is not in the archive (sent off-list or not yet received): [email protected]

#2 lore raw

Merged, after fixing patch corruption (line wrap due to emailer?)

Quoted 29 lines · Vasily Averin

error path after mountdata check frees uninitialized mountdata_copy

---
 fs/cifs/connect.c |    2 +-

 1 files changed, 1 insertions(+), 1 deletions(-)
fs/cifs/connect.c +1 -1
index 6d88b82..dd5e33e 100644
@@ -784,7 +784,7 @@ cifs_parse_mount_options(const char *mountdata, const char
 *devname,
                         struct smb_vol *vol)
  {
        char *value, *data, *end;
-       char *mountdata_copy, *options;
+       char *mountdata_copy = NULL, *options;
        unsigned int  temp_len, i, j;
        char separator[2];

       short int override_uid = -1;
--
1.7.4.1

--
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to [email protected] More majordomo info at  http://vger.kernel.org/majordomo-info.html

Signature · 3 lines
Thanks,

Steve