DVB_NET help message is useless
Hi,
I've just updated to 3.0-rc and saw CONFIG_DVB_NET. Hmm, let's see what's that by asking with '?'. And I got this crap:
================CONFIG_DVB_NET:
The DVB network support in the DVB core can
optionally be disabled if this
option is set to N.
If unsure say Y.
================
Why do you think this help message is useful? It's clear to everybody that if one eventually disables it it will be disabled. The help message should mention _what_ the network support is.
I would send a patch, but I really have no idea what's that good for.
thanks,
Signature · 1 line
js
Quoted 1 line · On Thursday 16 June 2011 09:06:59 Jiri Slaby wrote:
I would send a patch, but I really have no idea what's that good for.
DVB network support is referring to the IP stack. This option is set to "N" when compiling the Linux DVB stack on systems without IP networking.
Please submit a patch if you need a better description.
--HPS
Em 16-06-2011 04:06, Jiri Slaby escreveu:
Quoted 11 lines
Hi,
I've just updated to 3.0-rc and saw
CONFIG_DVB_NET. Hmm, let's see what's that by asking with '?'. And I got this crap:
================CONFIG_DVB_NET:The DVB network support in the DVB core can
optionally be disabled if this
option is set to N.
Quoted 7 lines
If unsure say Y.
================
Why do you think this help message is useful? It's clear to everybody that if one eventually disables it it will be disabled. The help message should mention _what_ the network support is.I would send a patch, but I really have no idea what's that good for.
As Hans answered this option disables the IP stack from the DVB driver. The IP stack is part of the DVB standard. It is used, for example, by automatic firmware updates used on STB's. It can also be used to access the Internet, via the DVB card, if the network provider supports it.
Before 3.0, this were enabled on all cards. However, if the IP stack is disabled, this would mean that the entire DVB would also be disabled. So, this option were added. It may make sense to make it dependent of CONFIG_EMBEDDED, as normal users should not need to disable it.
Feel free to send us a patch if you want to improve the Kconfig logic or help message.
Thanks,
Mauro
PATCH 1/1 DVB: dvb-net, make the kconfig text helpful
Telling the user they can disable an option if they want is not the much useful. Describe what it is good for instead.
The text was derived from Mauro's email.
--- drivers/media/Kconfig | 10 ++++++---- 1 files changed, 6 insertions(+), 4 deletions(-)
drivers/media/Kconfig +6 -4
@@ -89,11 +89,13 @@ config DVB_NET default (NET && INET) depends on NET && INET help - The DVB network support in the DVB core can - optionally be disabled if this - option is set to N. + This option enables DVB Network Support which is a part of the DVB + standard. It is used, for example, by automatic firmware updates used + on Set-Top-Boxes. It can also be used to access the Internet via the + DVB card, if the network provider supports it. - If unsure say Y. + You may want to disable the network support on embedded devices. If + unsure say Y. config VIDEO_MEDIA tristate
Signature · 1 line
1.7.5.4
Re: [PATCH] DVB: dvb-net, make the kconfig text helpful
Quoted 8 lines · On Thu, 16 Jun 2011 21:06:56 +0200 Jiri Slaby wrote:
Telling the user they can disable an option if they want is not the much useful. Describe what it is good for instead.
The text was derived from Mauro's email.
Signed-off-by Jiri Slaby <[email protected]>Cc Mauro Carvalho Chehab <[email protected]>Cc Hans Petter Selasky <[email protected]>
Yes, much better. Thanks.
Quoted 35 lines
--- drivers/media/Kconfig | 10 ++++++---- 1 files changed, 6 insertions(+), 4 deletions(-)drivers/media/Kconfig +6
-4@@ -89,11 +89,13 @@ config DVB_NET default (NET && INET) depends on NET && INET help - The DVB network support in the DVB core can - optionally be disabled if this - option is set to N. + This option enables DVB Network Support which is a part of the DVB + standard. It is used, for example, by automatic firmware updates used + on Set-Top-Boxes. It can also be used to access the Internet via the + DVB card, if the network provider supports it. - If unsure say Y. + You may want to disable the network support on embedded devices. If + unsure say Y. config VIDEO_MEDIA tristateSignature · 8 lines
1.7.5.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
Re: [PATCH] DVB: dvb-net, make the kconfig text helpful
In reply to Jiri SlabyQuoted 4 lines · On Thursday 16 June 2011 21:06:56 Jiri Slaby wrote:
Telling the user they can disable an option if they want is not the much useful. Describe what it is good for instead.
The text was derived from Mauro's email.
PS: Don't forget the other patch to add a dependency to DVB_CORE.
--HPS
Re: [PATCH] DVB: dvb-net, make the kconfig text helpful
Quoted 1 line · Hans Petter Selasky
PS: Don't forget the other patch to add a dependency to
DVB_CORE.
Sorry, I'm not your fixing monkey. Fix your bugs on your own.
thanks,
Signature · 1 line
js
Re: [PATCH] DVB: dvb-net, make the kconfig text helpful
Quoted 4 lines · On Friday 17 June 2011 10:02:21 Jiri Slaby wrote:
Quoted 1 line · Hans Petter Selasky
PS: Don't forget the other patch to add a dependency to
DVB_CORE.Sorry, I'm not your fixing monkey. Fix your bugs on your own.
The PS was intended for Mauro. Sorry if you confused that.
--HPS