Skip to contentSkip to conversation

ALSA: VIA HDA: Modify initial verbs list for VT1718S.

PATCH In review lydiawang 2 participants 3 messages Jun 20, 2011 – Jun 21, 2011 1 message not in the archive Sound

lore
Share & tools
lore

lydiawang

author
#0 lore raw

PATCH 1/3 ALSA: VIA HDA: Modify initial verbs list for VT1718S.

From: Lydia Wang <[email protected]>
Subject: ALSA: VIA HDA: Modify initial verbs list for VT1718S.

Remove some invalid initial verbs and correct some wrong initial verbs for VT1718S codec.

Signed-off-by Lydia Wang <[email protected]>
sound/pci/hda/patch_via.c +2 -7
Index: sound-2.6/sound/pci/hda/patch_via.c
===================================================================
@@ -4286,9 +4286,6 @@
 	{0x21, AC_VERB_SET_AMP_GAIN_MUTE, AMP_IN_MUTE(2)},
 	{0x21, AC_VERB_SET_AMP_GAIN_MUTE, AMP_IN_MUTE(3)},
 	{0x21, AC_VERB_SET_AMP_GAIN_MUTE, AMP_IN_UNMUTE(5)},
-
-	/* Setup default input of Front HP to MW9 */
-	{0x28, AC_VERB_SET_CONNECT_SEL, 0x1},
 	/* PW9 PW10 Output enable */
 	{0x2d, AC_VERB_SET_PIN_WIDGET_CONTROL, AC_PINCTL_OUT_EN},
 	{0x2e, AC_VERB_SET_PIN_WIDGET_CONTROL, AC_PINCTL_OUT_EN},

@@ -4297,10 +4294,10 @@
 	/* Enable Boost Volume backdoor */
 	{0x1, 0xf88, 0x8},
 	/* MW0/1/2/3/4: un-mute index 0 (AOWx), mute index 1 (MW9) */
-	{0x18, AC_VERB_SET_AMP_GAIN_MUTE, AMP_IN_UNMUTE(0)},
+	{0x18, AC_VERB_SET_AMP_GAIN_MUTE, AMP_IN_MUTE(0)},
 	{0x19, AC_VERB_SET_AMP_GAIN_MUTE, AMP_IN_UNMUTE(0)},
 	{0x1a, AC_VERB_SET_AMP_GAIN_MUTE, AMP_IN_UNMUTE(0)},
-	{0x1b, AC_VERB_SET_AMP_GAIN_MUTE, AMP_IN_UNMUTE(0)},
+	{0x1b, AC_VERB_SET_AMP_GAIN_MUTE, AMP_IN_MUTE(0)},
 	{0x1c, AC_VERB_SET_AMP_GAIN_MUTE, AMP_IN_UNMUTE(0)},
 	{0x18, AC_VERB_SET_AMP_GAIN_MUTE, AMP_IN_UNMUTE(1)},
 	{0x19, AC_VERB_SET_AMP_GAIN_MUTE, AMP_IN_MUTE(1)},

@@ -4310,8 +4307,6 @@
 	/* set MUX1 = 2 (AOW4), MUX2 = 1 (AOW3) */
 	{0x34, AC_VERB_SET_CONNECT_SEL, 0x2},
 	{0x35, AC_VERB_SET_CONNECT_SEL, 0x1},
-	/* Unmute MW4's index 0 */
-	{0x1c, AC_VERB_SET_AMP_GAIN_MUTE, AMP_IN_UNMUTE(0)},
 	{ }
 };
#1 lore raw

At Mon, 20 Jun 2011 14:14:37 +0800,

Quoted 8 lines · lydiawang

From: Lydia Wang <[email protected]>
Subject: ALSA: VIA HDA: Modify initial verbs list for VT1718S.

Remove some invalid initial verbs and correct some wrong initial verbs for VT1718S codec.

Signed-off-by Lydia Wang <[email protected]>

Are these three patches are needed for fixing the bugs or just clean-ups? If these are real fixes for 3.0-rc kernel, I'll merge them now.

If not, they can be irrelevant now, as I've been working on major rework of VIA codec driver. See the later post.

thanks,

Takashi

#3 lore raw
In reply to a message not in the archive

At Tue, 21 Jun 2011 09:36:14 +0800,

Quoted 26 lines · <[email protected]> wrote:
Quoted 26 lines

-----邮件原件-----
发件人: Takashi Iwai [mailto:[email protected]]
发送时间: 2011年6月20日 22:32
收件人: Lydia Wang
抄送: [email protected]; Harald Welte
主题: Re: [PATCH 1/3] ALSA: VIA HDA: Modify initial verbs list for VT1718S.

At Mon, 20 Jun 2011 14:14:37 +0800,

Quoted 8 lines · lydiawang

From: Lydia Wang <[email protected]>
Subject: ALSA: VIA HDA: Modify initial verbs list for VT1718S.

Remove some invalid initial verbs and correct some wrong initial verbs for VT1718S codec.

Signed-off-by Lydia Wang <[email protected]>

Are these three patches are needed for fixing the bugs or just clean-ups? If these are real fixes for 3.0-rc kernel, I'll merge them now.

If not, they can be irrelevant now, as I've been working on major rework of VIA codec driver. See the later post.

Quoted 6 lines
Quoted 3 lines

thanks,

Takashi

These patches are to fix the problem reported by alex.baldacchino.alsasub. You can refer the attached mail.

Fair enough. I'll take them for 3.0-rc, then.

thanks,

Takashi

_______________________________________________
Alsa-devel mailing list
[email protected]
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel