Skip to contentSkip to conversation

SATA status report updated

DISCUSSION Rainer Koenig 3 participants 3 messages Aug 20, 2005 – Aug 22, 2005 6 messages not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

#6 lore raw

Hi Jeff,

Quoted 2 lines · Jeff Garzik

Here is a list of problems with the patch. I'll paste this into the bug as well:

[Lot of interesting issues]

Quoted 3 lines

8) The DMA pad code is very buggy. It uses the dma_map_single() to map a buffer, but never synchronizes nor flushes the buffer. This can and will lead to data corruption, particularly on x86-64 platform.

That's very bad since the target platform for that chipset is able to support AMD64. :-(

Quoted 1 line

From your comments I've learned that my patch (just the device ID) is

too tiny and the SiS provided patch is doing too much things that it shouldn't do. How can we find a solution for that?

Would it make sense that I try to find the "goods" in the SiS patch and merge them somehow in the actual kernel? But: What kernel shall I take to do that work? The latest development kernel, the kernel of my distribution (whatever this will be, sooner or later it has to work with all distributions) or just a kernel that is "close" to the patch from SiS, e.g. 2.6.10?

As I mentioned before, getting hardware to try out patches wouldn't be that big deal since I'm located in a PC factory and I can get test machines if needed. What would be good tests to e.g. detect the problems that you mentioned above? Are there hardware specific tests for SATA hard disks around? I would be very interested in that since testing also under Linux will become daily work for me and my colleauges from the system test department.

Best regards
Rainer (posting from home)

Signature · 1 line
Please send NO spam to my mail addresses.
#7 lore raw

Hi Rainer

Quoted 8 lines · Rainer Koenig
Quoted 3 lines · Jeff Garzik

8) The DMA pad code is very buggy. It uses the dma_map_single() to map a buffer, but never synchronizes nor flushes the buffer. This can and will lead to data corruption, particularly on x86-64 platform.

That's very bad since the target platform for that chipset is able to support AMD64. :-(

that was my conclusion as well!

Quoted 10 lines

From your comments I've learned that my patch (just the device ID) is too tiny and the SiS provided patch is doing too much things that it shouldn't do. How can we find a solution for that?

Would it make sense that I try to find the "goods" in the SiS patch and
merge them somehow in the actual kernel? But: What kernel shall I take
to do that work? The latest development kernel, the kernel of my distribution (whatever this will be, sooner or later it has to work with all distributions) or just a kernel that is "close" to the patch
from SiS, e.g. 2.6.10?

Quoted 5 lines

As I mentioned before, getting hardware to try out patches wouldn't be
that big deal since I'm located in a PC factory and I can get test machines if needed. What would be good tests to e.g. detect the problems that you mentioned above? Are there hardware specific tests for SATA
hard disks around? I would be very interested in that since testing also under Linux will become daily work for me and my colleauges from the system test department.

I'll be happy to test patches that come up. I'm currently running 2.6.13-rc6-mm1, because it also has the sis190 ethernet driver in it, which actually does work :-)

Unfortunately I'm not able to check the logic of the driver, because although I can read C, I'm totally unfamiliar with the disk controler logic in the kernel...

Cheers

Simon

#8 lore raw

Hi Simon,

Quoted 3 lines · Simon Oosthoek

Unfortunately I'm not able to check the logic of the driver, because although I can read C, I'm totally unfamiliar with the disk controler logic in the kernel...

Well, today I've spent some time in looking at the SiS driver and compared it with the driver that is in kernel 2.6.10. And keeping Jeff's comments about libata in mind (together with a printout of libata.h) helped a bit to understand the differences. So I will see if I can somehow get the important things from the SiS driver while using whatever libata provides already. Will take some time anyway since kernel hacking is not the main focus of my job. Anyway, I will try. I guess the main issue is to find the 0x182 specific details and merge them into the kernel driver.

Best regards
Rainer

Signature · 1 line
Rainer König, Diplom-Informatiker (FH), Augsburg, Germany