sstate skips STAGING_DIR_KERNEL?

DISCUSSION Applied Tom Rini 3 participants 6 messages Jun 23, 2011

Share & tools

Tom Rini

author

2011-06-23 00:24 UTC #0 lore raw

Hey all,

As part of looking into the problem I had that I just posted a patch for I was going "why isn't -c clean (or cleanall or cleansstate) knocking out STAGING_DIR_KERNEL contents? Answer, sstate is totally skipping that out. Is there some variable we need to be setting somewhere to add this in? Or are we going to have to take in the various bits of OE.dev kernel.bbclass instead here?

Signature · 2 lines

Tom Rini
Mentor Graphics Corporation

Richard Purdie

2011-06-23 15:33 UTC #1 lore raw

Quoted 6 lines · Tom Rini

As part of looking into the problem I had that I just posted a patch for I was going "why isn't -c clean (or cleanall or cleansstate) knocking out STAGING_DIR_KERNEL contents? Answer, sstate is totally skipping that out. Is there some variable we need to be setting somewhere to add this in? Or are we going to have to take in the various bits of OE.dev kernel.bbclass instead here?

I think there is a bug in kernel.bbclass. This should fix it:

meta/classes/kernel.bbclass +1 -1

index aaf341b..9f09107 100644
@@ -119,7 +119,7 @@ kernel_do_install() {
        # Support for external module building - create a minimal copy of the
        # kernel source tree.
        #
-       kerneldir=${STAGING_KERNEL_DIR}
+       kerneldir=${D}/kernel
        install -d $kerneldir
 
        #

I'll merge something like this is nobody objects.

Cheers,

Richard

Tom Rini

author

2011-06-23 16:19 UTC #2 lore raw

Quoted 24 lines · Richard Purdie

Quoted 6 lines · Tom Rini
As part of looking into the problem I had that I just posted a patch for I was going "why isn't -c clean (or cleanall or cleansstate) knocking out STAGING_DIR_KERNEL contents? Answer, sstate is totally skipping that out. Is there some variable we need to be setting somewhere to add this in? Or are we going to have to take in the various bits of OE.dev kernel.bbclass instead here?
I think there is a bug in kernel.bbclass. This should fix it:
meta/classes/kernel.bbclass +1 -1
index aaf341b..9f09107 100644
@@ -119,7 +119,7 @@ kernel_do_install() {
        # Support for external module building - create a minimal copy of the
        # kernel source tree.
        #
-       kerneldir=${STAGING_KERNEL_DIR}
+       kerneldir=${D}/kernel
        install -d $kerneldir
 
        #

Quoted 1 line

I'll merge something like this is nobody objects.

That makes sense, testing this now.

Signature · 2 lines

Tom Rini
Mentor Graphics Corporation

Tom Rini

author Tested-by

2011-06-23 16:55 UTC #3 lore raw

Quoted 23 lines · Tom Rini

Quoted 22 lines · Richard Purdie
Quoted 6 lines · Tom Rini
As part of looking into the problem I had that I just posted a patch for I was going "why isn't -c clean (or cleanall or cleansstate) knocking out STAGING_DIR_KERNEL contents? Answer, sstate is totally skipping that out. Is there some variable we need to be setting somewhere to add this in? Or are we going to have to take in the various bits of OE.dev kernel.bbclass instead here?
I think there is a bug in kernel.bbclass. This should fix it:
meta/classes/kernel.bbclass +1 -1
index aaf341b..9f09107 100644
@@ -119,7 +119,7 @@ kernel_do_install() {
        # Support for external module building - create a minimal copy of the
        # kernel source tree.
        #
-       kerneldir=${STAGING_KERNEL_DIR}
+       kerneldir=${D}/kernel
        install -d $kerneldir
 

Quoted 5 lines

Quoted 3 lines
meta/classes/kernel.bbclass +0 -0
        #
I'll merge something like this is nobody objects.
That makes sense, testing this now.

Yeah, that does it.

Tested-by Tom Rini <[email protected]>

Koen, once this is in oe-core need a request to bring it over too or just want to come grab it?

Signature · 2 lines

Tom Rini
Mentor Graphics Corporation

Koen Kooi

2011-06-23 17:23 UTC #4 lore raw

Op 23 jun 2011, om 18:51 heeft Tom Rini het volgende geschreven:

Quoted 31 lines · Tom Rini

Quoted 24 lines · Richard Purdie
Quoted 23 lines · Tom Rini
Quoted 6 lines
As part of looking into the problem I had that I just posted a patch for I was going "why isn't -c clean (or cleanall or cleansstate) knocking out STAGING_DIR_KERNEL contents? Answer, sstate is totally skipping that out. Is there some variable we need to be setting somewhere to add this in? Or are we going to have to take in the various bits of OE.dev kernel.bbclass instead here?
I think there is a bug in kernel.bbclass. This should fix it:
meta/classes/kernel.bbclass +0 -0
index aaf341b..9f09107 100644
@@ -119,7 +119,7 @@ kernel_do_install() {
       # Support for external module building - create a minimal  
copy of the
       # kernel source tree.
       #
meta/classes/kernel.bbclass +1 -1
-       kerneldir=${STAGING_KERNEL_DIR}
+       kerneldir=${D}/kernel
       install -d $kerneldir
Quoted 5 lines
Quoted 3 lines
       #
I'll merge something like this is nobody objects.
That makes sense, testing this now.

Quoted 6 lines

Yeah, that does it.
Tested-by Tom Rini <[email protected]>
Koen, once this is in oe-core need a request to bring it over too or just want to come grab it?

I have it applied locally, just waiting for it to land in oe-core so I can transplant the commit headers :)

Richard Purdie

Applied

2011-06-23 19:51 UTC #5 lore raw

In reply to Tom Rini

Quoted 30 lines · Tom Rini

Quoted 23 lines · Tom Rini
Quoted 22 lines · Richard Purdie
Quoted 6 lines · Tom Rini
As part of looking into the problem I had that I just posted a patch for I was going "why isn't -c clean (or cleanall or cleansstate) knocking out STAGING_DIR_KERNEL contents? Answer, sstate is totally skipping that out. Is there some variable we need to be setting somewhere to add this in? Or are we going to have to take in the various bits of OE.dev kernel.bbclass instead here?
I think there is a bug in kernel.bbclass. This should fix it:
meta/classes/kernel.bbclass +1 -1
index aaf341b..9f09107 100644
@@ -119,7 +119,7 @@ kernel_do_install() {
        # Support for external module building - create a minimal copy of the
        # kernel source tree.
        #
-       kerneldir=${STAGING_KERNEL_DIR}
+       kerneldir=${D}/kernel
        install -d $kerneldir
 
Quoted 5 lines
Quoted 3 lines
meta/classes/kernel.bbclass +0 -0
        #
I'll merge something like this is nobody objects.
That makes sense, testing this now.

Quoted 6 lines

Yeah, that does it.
Tested-by Tom Rini <[email protected]>
Koen, once this is in oe-core need a request to bring it over too or just want to come grab it?

I've merged it into OE-Core.

Cheers,

Richard