Skip to contentSkip to conversation

xfs: Silence bounds checking compiler warning

PATCH New Maarten Lankhorst 1 participant 1 message Jun 23, 2011 XFS filesystem

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 xfs: Silence bounds checking compiler warning

gcc with -Warray-bounds generates a false positive on this since xfs defines the struct with u8 name[1]; to be able to add a tag at the end.

---
 fs/xfs/xfs_dir2_block.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
fs/xfs/xfs_dir2_block.c +1 -1
index 580d99c..2c5f287 100644
@@ -1148,7 +1148,7 @@ xfs_dir2_sf_to_block(
 		((char *)block + XFS_DIR2_DATA_DOTDOT_OFFSET);
 	dep->inumber = cpu_to_be64(xfs_dir2_sf_get_inumber(sfp, &sfp->hdr.parent));
 	dep->namelen = 2;
-	dep->name[0] = dep->name[1] = '.';
+	memset(dep->name, '.', 2);
 	tagp = xfs_dir2_data_entry_tag_p(dep);
 	*tagp = cpu_to_be16((char *)dep - (char *)block);
 	xfs_dir2_data_log_entry(tp, bp, dep);
Signature · 8 lines
1.7.5.4

v2: memset looks like the cleanest solution, other options rely on ugly casts

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs