udev: bump to 172
PATCH 1/1 udev: bump to 172
--- package/udev/Config.in | 39 +-------- package/udev/libvolume_id.la.tmpl | 35 -------- package/udev/udev.mk | 150 ++++++-------------------------------- 3 files changed, 32 insertions(+), 192 deletions(-) delete mode 100644 package/udev/libvolume_id.la.tmpl
package/udev/Config.in +7 -32
@@ -5,37 +5,12 @@ ftp://ftp.kernel.org/pub/linux/utils/kernel/hotplug/ -config BR2_PACKAGE_UDEV_UTILS - bool "udev-utils" - depends on BR2_PACKAGE_UDEV +config BR2_PACKAGE_UDEV_ALL_EXTRAS + bool "enable all extras" + depends on BR2_PACKAGE_UDEV && BR2_PACKAGE_ACL && BR2_PACKAGE_LIBUSB && BR2_PACKAGE_LIBUSB_COMPAT && BR2_PACKAGE_USBUTILS && BR2_PACKAGE_HWDATA help - Adds the udevmonitor, udevinfo, and udevtest binaries - to your filesystem. + Enable all extras with external dependencies like + libacl, libusb, libusb-compat, usbutils, hwdata -menu "Extra udev tools" - depends on BR2_PACKAGE_UDEV - -config BR2_PACKAGE_UDEV_VOLUME_ID - bool "udev-libvolume_id" - depends on BR2_PACKAGE_UDEV - help - Build and install volume identification library. - -config BR2_PACKAGE_UDEV_SCSI_ID - bool "udev-scsi_id" - depends on BR2_PACKAGE_UDEV_VOLUME_ID - help - Build and install SCSI disk identification library. - -config BR2_PACKAGE_UDEV_PATH_ID - bool "udev-path_id" - depends on BR2_PACKAGE_UDEV_VOLUME_ID - help - Install udev's unique device path generation program path_id. - -config BR2_PACKAGE_UDEV_FIRMWARE_SH - bool "udev-firmware_sh" - depends on BR2_PACKAGE_UDEV_VOLUME_ID - help - Install udev's firmware loading script firmware.sh. -endmenu +comment "some additional udev extras require acl and libusb to be built" + depends on !BR2_PACKAGE_ACL || !BR2_PACKAGE_LIBUSB || !BR2_PACKAGE_LIBUSB_COMPAT || !BR2_PACKAGE_USBUTILS || !BR2_PACKAGE_HWDATA
package/udev/libvolume_id.la.tmpl deleted +0 -35
@@ -1,35 +0,0 @@ -# libvolume_id.la - a libtool library file -# Generated by ltmain.sh - GNU libtool 1.5.22 (1.1220.2.365 2005/12/18 22:14:06) -# -# Please DO NOT delete this file! -# It is necessary for linking the library. - -# The name that we can dlopen(3). -dlname='libvolume_id.so.REPLACE_CURRENT' - -# Names of this library. -library_names='libvolume_id.so.REPLACE_CURRENT.REPLACE_AGE.REPLACE_REVISION libvolume_id.so.REPLACE_CURRENT libvolume_id.so' - -# The name of the static archive. -old_library='libvolume_id.a' - -# Libraries that this one depends upon. -dependency_libs=' -lc' - -# Version information for libvolume_id. -current=REPLACE_CURRENT -age=REPLACE_AGE -revision=REPLACE_REVISION - -# Is this an already installed library? -installed=yes - -# Should we warn about portability when linking against -modules? -shouldnotlink=no - -# Files to dlopen/dlpreopen -dlopen='' -dlpreopen='' - -# Directory that this library needs to be installed in: -libdir='REPLACE_LIB_DIR'
package/udev/udev.mk +25 -125
157 lines not on this page · raw message
PATCH 1/1 udev: bump to 172
Hello,
Thanks Yegor for this patch. It's really great to have a modern version of udev in Buildroot.
Le Tue, 12 Jul 2011 14:39:12 +0200,
Yegor Yefremov <[email protected]> a ?crit :
Quoted 14 lines
Signed-off-by Heiko Zuerker <[email protected]>Signed-off-by Yegor Yefremov <[email protected]>--- package/udev/Config.in | 39 +-------- package/udev/libvolume_id.la.tmpl | 35 -------- package/udev/udev.mk | 150 ++++++-------------------------------- 3 files changed, 32 insertions(+), 192 deletions(-) delete mode 100644 package/udev/libvolume_id.la.tmplIndex: b/package/udev/Config.in
===================================================================
package/udev/Config.in line 10
Quoted 9 lines
package/udev/Config.in +3
-3@@ -5,37 +5,12 @@ ftp://ftp.kernel.org/pub/linux/utils/kernel/hotplug/ -config BR2_PACKAGE_UDEV_UTILS - bool "udev-utils" - depends on BR2_PACKAGE_UDEV +config BR2_PACKAGE_UDEV_ALL_EXTRAS + bool "enable all extras" + depends on BR2_PACKAGE_UDEV && BR2_PACKAGE_ACL && BR2_PACKAGE_LIBUSB && BR2_PACKAGE_LIBUSB_COMPAT && BR2_PACKAGE_USBUTILS && BR2_PACKAGE_HWDATA
I'm wondering whether we should turn this into :
depends on BR2_PACKAGE_UDEV
select BR2_PACKAGE_ACL
select BR2_PACKAGE_LIBUSB
select BR2_PACKAGE_LIBUSB_COMPAT
select BR2_PACKAGE_USBUTILS
select BR2_PACKAGE_HWDATA
Because all those dependencies are not really obvious.
package/udev/Config.in line 16
Quoted 2 lines
package/udev/Config.in +2
-0+comment "some additional udev extras require acl and libusb to be built" + depends on !BR2_PACKAGE_ACL || !BR2_PACKAGE_LIBUSB || !BR2_PACKAGE_LIBUSB_COMPAT || !BR2_PACKAGE_USBUTILS || !BR2_PACKAGE_HWDATA
The message does not match the dependencies: it doesn't say anything about libusb-compat, usbutils and hwdata. But see above, I think "select" style dependencies would be better.
I have tried building your package. Just udev itself works fine, but udev with extras doesn't work, you forgot the libglib2 dependency :
checking for GLIB... no
configure: error: Package requirements (glib-2.0 >= 2.22.0 gobject-2.0 >= 2.22.0) were not met:
No package 'glib-2.0' found
No package 'gobject-2.0' found
Regards,
Thomas
Signature · 4 lines
Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com
PATCH 1/1 udev: bump to 172
Am 12.07.2011 15:47, schrieb Thomas Petazzoni:
Quoted 4 lines
Hello,
Thanks Yegor for this patch. It's really great to have a modern version of udev in Buildroot.
At this place I would like to thank Heiko Zuerker for making the patch, I was basing mine on.
Quoted 32 lines
Quoted 14 lines
Signed-off-by Heiko Zuerker <[email protected]>Signed-off-by Yegor Yefremov <[email protected]>--- package/udev/Config.in | 39 +-------- package/udev/libvolume_id.la.tmpl | 35 -------- package/udev/udev.mk | 150 ++++++-------------------------------- 3 files changed, 32 insertions(+), 192 deletions(-) delete mode 100644 package/udev/libvolume_id.la.tmplIndex: b/package/udev/Config.in
===================================================================package/udev/Config.in line 10
Quoted 9 lines
package/udev/Config.in +3
-3@@ -5,37 +5,12 @@ ftp://ftp.kernel.org/pub/linux/utils/kernel/hotplug/ -config BR2_PACKAGE_UDEV_UTILS - bool "udev-utils" - depends on BR2_PACKAGE_UDEV +config BR2_PACKAGE_UDEV_ALL_EXTRAS + bool "enable all extras" + depends on BR2_PACKAGE_UDEV && BR2_PACKAGE_ACL && BR2_PACKAGE_LIBUSB && BR2_PACKAGE_LIBUSB_COMPAT && BR2_PACKAGE_USBUTILS && BR2_PACKAGE_HWDATAI'm wondering whether we should turn this into :
depends on
BR2_PACKAGE_UDEV
selectBR2_PACKAGE_ACL
selectBR2_PACKAGE_LIBUSB
selectBR2_PACKAGE_LIBUSB_COMPAT
selectBR2_PACKAGE_USBUTILS
selectBR2_PACKAGE_HWDATA
Quoted 7 lines
Because all those dependencies are not really obvious.
package/udev/Config.in line 16
Quoted 2 lines
package/udev/Config.in +2
-0+comment "some additional udev extras require acl and libusb to be built" + depends on !BR2_PACKAGE_ACL || !BR2_PACKAGE_LIBUSB || !BR2_PACKAGE_LIBUSB_COMPAT || !BR2_PACKAGE_USBUTILS || !BR2_PACKAGE_HWDATAThe message does not match the dependencies: it doesn't say anything about libusb-compat, usbutils and hwdata. But see above, I think "select" style dependencies would be better.
So do I. Fixed.
Quoted 7 lines
I have tried building your package. Just udev itself works fine, but udev with extras doesn't work, you forgot the libglib2 dependency :
checking for GLIB... no
configure: error: Package requirements (glib-2.0 >= 2.22.0 gobject-2.0 >= 2.22.0) were not met:
No package 'glib-2.0' found
No package 'gobject-2.0' found
Fixed. I had glibc already activated because of some other package. As always :-)
Thanks for review.
Best regards,
Yegor
PATCH 1/1 udev: bump to 172
Quoting Yegor Yefremov <[email protected]>:
Quoted 8 lines
Am 12.07.2011 15:47, schrieb Thomas Petazzoni:
Quoted 4 lines
Hello,
Thanks Yegor for this patch. It's really great to have a modern version of udev in Buildroot.
At this place I would like to thank Heiko Zuerker for making the patch, I was basing mine on.
I'm just glad we're moving on it. I don't have much time lately to keep these things going....
Signature · 3 lines
Regards Heiko Zuerker http://www.devil-linux.org