Skip to contentSkip to conversation

lpfc_debugfs_dumpHBASlim_data() stack space use

DISCUSSION Rob Evers 2 participants 2 messages Jul 12, 2011 – Jul 13, 2011 SCSI

lore
Share & tools
lore

Rob Evers

author
#0 lore raw

Hi James S.

I noticed:

static int
lpfc_debugfs_dumpHBASlim_data(struct lpfc_hba *phba, char *buf, int size)

{
        int len = 0;
        int i, off;
        uint32_t *ptr;
        char buffer[1024];

Would 'char *buffer=kmalloc()' be more appropriate here?

Rob

#1 lore raw

yes - something popped up with a recent change in the compiler.

The following patch addressed this issue.
http://marc.info/?l=linux-scsi&m=130655514918715&w=2

-- james s

Quoted 17 lines · Rob Evers

Hi James S.

I noticed:

static int
lpfc_debugfs_dumpHBASlim_data(struct lpfc_hba *phba, char *buf, int size)

{
          int len = 0;
          int i, off;
          uint32_t *ptr;
          char buffer[1024];

Would 'char *buffer=kmalloc()' be more appropriate here?

Rob