Skip to contentSkip to conversation

at91: reworked support for meesc board

PATCH New Matthias Fuchs 2 participants 2 messages Jul 19, 2011 – Aug 4, 2011

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 at91: reworked support for meesc board

The meesc board support was broken. Within this opportunity, I completely reworked the board files.

---
V3: -fix white space issues and don't patch boards.cfg
V2: -fixed commit description

 board/esd/meesc/config.mk |    1 -
 board/esd/meesc/meesc.c   |   49 ++++++-----
 include/configs/meesc.h   |  208 ++++++++++++++++++++++++++-------------------
 3 files changed, 147 insertions(+), 111 deletions(-)
 delete mode 100644 board/esd/meesc/config.mk
board/esd/meesc/config.mk deleted +0 -1
deleted file mode 100644
index 2077692..0000000
@@ -1 +0,0 @@
-CONFIG_SYS_TEXT_BASE = 0x21f00000
board/esd/meesc/meesc.c +26 -23

125 lines not on this page · raw message

include/configs/meesc.h +121 -87

281 lines not on this page · raw message

Signature · 1 line
1.6.1
#1 lore raw

PATCH 1/1 at91: reworked support for meesc board

Dear Matthias Fuchs,

Quoted 9 lines

The meesc board support was broken. Within this opportunity, I completely reworked the board files.

---
V3: -fix white space issues and don't patch boards.cfg
V2: -fixed commit description

Quoted 5 lines
 board/esd/meesc/config.mk |    1 -
 board/esd/meesc/meesc.c   |   49 ++++++-----
 include/configs/meesc.h   |  208 ++++++++++++++++++++++++++-------------------
 3 files changed, 147 insertions(+), 111 deletions(-)
 delete mode 100644 board/esd/meesc/config.mk

Sorry, this patch had escaped my sight.
Checkpatch has the following issues:

WARNING: Use #include <linux/io.h> instead of <asm/io.h> #53: FILE: board/esd/meesc/meesc.c:30:
+#include <asm/io.h>
--> ignored

WARNING: please, no space for starting a line,
excluding comments
#334: FILE: include/configs/meesc.h:134:
+ /* DataFlash */$
--> fixed before applying

ERROR: Macros with complex values should be enclosed in parenthesis #369: FILE: include/configs/meesc.h:157:
+# define CONFIG_SYS_NAND_ENABLE_PIN AT91_PIO_PORTD, 15
ERROR: Macros with complex values should be enclosed in parenthesis #370: FILE: include/configs/meesc.h:158:
+# define CONFIG_SYS_NAND_READY_PIN AT91_PIO_PORTA, 22
--> both not nice style, but understandable als long as gpio routines have 2 parameters (port and bit).

Configuring for meesc - Board: meesc, Options:
AT91SAM9263,SYS_USE_NANDFLASH
text data bss dec hex filename
201434 5304 74688 281426 44b52 ./u-boot

Configuring for meesc_dataflash - Board: meesc, Options:
AT91SAM9263,SYS_USE_DATAFLASH
text data bss dec hex filename
207303 5472 75096 287871 4647f ./u-boot

"[U-Boot,41/52] ARM: remove broken "meesc" board" set to "not applicable"

Thanks, Reinhard