Skip to contentSkip to conversation

cgroups/cgroup_regression_test: clear dmesg before test

PATCH In review Jan Stancek 2 participants 2 messages Jul 22, 2011 – Jul 28, 2011

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/6 cgroups/cgroup_regression_test: clear dmesg before test

dmesg can rotate and number of found bugs can actually go down, clear the buffer before test to avoid this

---
  .../controllers/cgroup/cgroup_regression_test.sh   |    3 +++
  1 files changed, 3 insertions(+), 0 deletions(-)
testcases/kernel/controllers/cgroup/cgroup_regression_test.sh +3 -0
index 878f91a..5615053 100755
@@ -40,6 +40,7 @@ elif [ "x$(id -ru)" != x0 ]; then
 	exit 0
 fi
 
+dmesg -c > /dev/null
 nr_bug=`dmesg | grep -c "kernel BUG"`
 nr_null=`dmesg | grep -c "kernel NULL pointer dereference"`
 nr_warning=`dmesg | grep -c "^WARNING"`
@@ -78,6 +79,8 @@ check_kernel_bug()
 	nr_warning=$new_warning
 	nr_lockdep=$new_lockdep
 
+	echo "check_kernel_bug found something!"
+	dmesg
 	failed=1
 	return 0
 }

------------------------------------------------------------------------------
10 Tips for Better Web Security
Learn 10 ways to better secure your business today. Topics covered include:
Web security, SSL, hacker attacks & Denial of Service (DoS), private keys, security Microsoft Exchange, secure Instant Messaging, and much more.
http://www.accelacomm.com/jaw/sfnl/114/51426210/

_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

#1 lore raw

Hi!

Quoted 24 lines

dmesg can rotate and number of found bugs can actually go down, clear the buffer before test to avoid this

---
  .../controllers/cgroup/cgroup_regression_test.sh   |    3 +++
  1 files changed, 3 insertions(+), 0 deletions(-)
testcases/kernel/controllers/cgroup/cgroup_regression_test.sh +1 -0
index 878f91a..5615053 100755
@@ -40,6 +40,7 @@ elif [ "x$(id -ru)" != x0 ]; then
 	exit 0
 fi
 
+dmesg -c > /dev/null
 nr_bug=`dmesg | grep -c "kernel BUG"`
 nr_null=`dmesg | grep -c "kernel NULL pointer dereference"`
 nr_warning=`dmesg | grep -c "^WARNING"`

testcases/kernel/controllers/cgroup/cgroup_regression_test.sh check_kernel_bug() · line 86

Quoted 8 lines
testcases/kernel/controllers/cgroup/cgroup_regression_test.sh +2 -0
@@ -78,6 +79,8 @@ check_kernel_bug()
 	nr_warning=$new_warning
 	nr_lockdep=$new_lockdep
 
+	echo "check_kernel_bug found something!"
+	dmesg
 	failed=1
 	return 0
 }

Applied, but with the 'dmesg -c' the test could be simplified as storing number of bugs in log at the start is meaningless now as it's most likely 0.

Signature · 12 lines
Cyril Hrubis
[email protected]

------------------------------------------------------------------------------
Got Input?   Slashdot Needs You.
Take our quick survey online.  Come on, we don't ask for help often.
Plus, you'll get a chance to win $100 to spend on ThinkGeek.
http://p.sf.net/sfu/slashdot-survey
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list