Skip to contentSkip to conversation

fix fat utf8 iocharset warning message

PATCH Superseded Mihai Moldovan 3 participants 4 messages Jul 24, 2011 – Jul 25, 2011 VFAT/FAT/msdos filesystem

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Mihai Moldovan

author
#0 lore raw

PATCH 1/1 fix fat utf8 iocharset warning message

The fat_msg function already formats the given message and appends a newline to it - we don't need to do this in the passed message string as well, or will end up with a blank line printed in the kernel log ring buffer.

Signed-off-by Mihai Moldovan <[email protected]>
Cc OGAWA Hirofumi <[email protected]>
---
 fs/fat/inode.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
fs/fat/inode.c +1 -1
index 5942fec..46530a1 100644
@@ -1190,7 +1190,7 @@ out:
     if (!strcmp(opts->iocharset, "utf8")) {
         fat_msg(sb, KERN_ERR, "utf8 is not a recommended IO charset"
                " for FAT filesystems, filesystem will be "
-               "case sensitive!\n");
+               "case sensitive!");
     }
 
     /* If user doesn't specify allow_utime, it's initialized from dmask. */
Signature · 1 line
1.7.6
#1 lore raw
Quoted 16 lines · Mihai Moldovan

The fat_msg function already formats the given message and appends a newline to it - we don't need to do this in the passed message string as well, or will end up with a blank line printed in the kernel log ring buffer.

Signed-off-by Mihai Moldovan <[email protected]>
Cc OGAWA Hirofumi <[email protected]>
---
 fs/fat/inode.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
fs/fat/inode.c +0 -0
index 5942fec..46530a1 100644

fs/fat/inode.c out: · line 1191

Quoted 2 lines
fs/fat/inode.c +0 -0
@@ -1190,7 +1190,7 @@ out:
     if (!strcmp(opts->iocharset, "utf8")) {
         fat_msg(sb, KERN_ERR, "utf8 is not a recommended IO charset"

Is KERN_ERR really the right thing to use here?
Sounds more like a warning to me..

Quoted 7 lines
fs/fat/inode.c +1 -1
                " for FAT filesystems, filesystem will be "
-               "case sensitive!\n");
+               "case sensitive!");
     }
 
     /* If user doesn't specify allow_utime, it's initialized from dmask. */
Signature · 3 lines
Jesper Juhl <[email protected]>       http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.
author
#2 lore raw
Quoted 5 lines · * On 24.07.2011 07:22 PM, Jesper Juhl wrote:
fs/fat/inode.c +0 -0
@@ -1190,7 +1190,7 @@ out:
     if (!strcmp(opts->iocharset, "utf8")) {
         fat_msg(sb, KERN_ERR, "utf8 is not a recommended IO charset"

Is KERN_ERR really the right thing to use here?
Sounds more like a warning to me..

I'm interested to see what Ogawa says, but I'd say KERN_WARNING would be better here as well, yeah.

maintainer
#3 lore raw
Quoted 9 lines · Mihai Moldovan
Quoted 5 lines · * On 24.07.2011 07:22 PM, Jesper Juhl wrote:
fs/fat/inode.c +0 -0
@@ -1190,7 +1190,7 @@ out:
     if (!strcmp(opts->iocharset, "utf8")) {
         fat_msg(sb, KERN_ERR, "utf8 is not a recommended IO charset"

Is KERN_ERR really the right thing to use here?
Sounds more like a warning to me..

I'm interested to see what Ogawa says, but I'd say KERN_WARNING would be better here as well, yeah.

I agree to change it.

Thanks.

Signature · 1 line
OGAWA Hirofumi <[email protected]>