linux-yocto_3.0: pull powerpc compile fix for -0s in BOOTFLAGS

DISCUSSION Darren Hart 3 participants 6 messages Aug 10, 2011

Share & tools

Darren Hart

author

2011-08-10 04:18 UTC #0 lore raw

Bruce,

The following patch is needed for qemuppc and fsl-mpc8315e-rdb (same reasons as before). Can you pull this in from the 2.6.37 yocto tree?

commit 5ff609967ffe87c49d534d7861a7e0b150517726

Author: Bruce Ashfield <[email protected]>
Date:   Thu Oct 14 16:38:00 2010 -0400

powerpc/boot: remove -Os from BOOTFLAGS

Thanks,

Signature · 3 lines

Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel

Kumar Gala

2011-08-10 04:24 UTC #1 lore raw

Quoted 5 lines · Darren Hart

Bruce,
The following patch is needed for qemuppc and fsl-mpc8315e-rdb (same reasons as before). Can you pull this in from the 2.6.37 yocto tree?

Quoted 7 lines

commit 5ff609967ffe87c49d534d7861a7e0b150517726
Author: Bruce Ashfield <[email protected]>
Date:   Thu Oct 14 16:38:00 2010 -0400
powerpc/boot: remove -Os from BOOTFLAGS
Thanks,

Before we do this I have a query about default toolchain? I just posted a patch that should make this NOT needed if we utilize gcc-4.6

So wondering what the feeling was about a fix to kernel tree needed for one version of toolchain and not another?

- k

Bruce Ashfield

2011-08-10 04:28 UTC #2 lore raw

Quoted 12 lines · Kumar Gala

Quoted 9 lines · Darren Hart
Bruce,
The following patch is needed for qemuppc and fsl-mpc8315e-rdb (same reasons as before). Can you pull this in from the 2.6.37 yocto tree?
commit 5ff609967ffe87c49d534d7861a7e0b150517726
Author: Bruce Ashfield<[email protected]>
Date:   Thu Oct 14 16:38:00 2010 -0400

Quoted 7 lines

Quoted 3 lines
powerpc/boot: remove -Os from BOOTFLAGS
Thanks,
Before we do this I have a query about default toolchain? I just posted a patch that should make this NOT needed if we utilize gcc-4.6
So wondering what the feeling was about a fix to kernel tree needed for one version of toolchain and not another?

As long as it fixes one build (the 4.5 one), and doesn't beak other toolchain versions. I'm typically ok with any patch of that nature.

At the time, this was the fastest thing to do to get the kernel building with gcc 4.5, but we can absolutely update it with something newer.

Cheers,

Bruce

Quoted 6 lines

- k
_______________________________________________
yocto mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/yocto

Bruce Ashfield

2011-08-10 04:26 UTC #3 lore raw

In reply to Darren Hart

Quoted 4 lines · Darren Hart

Bruce,
The following patch is needed for qemuppc and fsl-mpc8315e-rdb (same reasons as before). Can you pull this in from the 2.6.37 yocto tree?

It should already be there for the fsl-mpc:

Quoted 1 line

git show f6a70a6408a5d173d69fe3dc26fdaece38b4be3c

commit f6a70a6408a5d173d69fe3dc26fdaece38b4be3c

Author: Bruce Ashfield <[email protected]>
Date:   Thu Oct 14 16:38:00 2010 -0400

powerpc/boot: remove -Os from BOOTFLAGS

Some variants of gcc 4.5 have issues with -Os and will throw:

cc1: error: Do not use -Os option if --enable-target-optspace is
not set.

-Os is not required to build a valid boot environment, so the easiest solution is to simply remove the boot flag.

Signed-off-by Bruce Ashfield <[email protected]>

Quoted 1 line

git branch --contains f6a70a6408a5d173d69fe3dc26fdaece38b4be3c

* yocto/standard/fsl-mpc8315e-rdb

I can add it for qemuppc, but I've been building it all along and have never seen the failure. What configuration are you building that is showing this ?

Bruce

Quoted 9 lines

commit 5ff609967ffe87c49d534d7861a7e0b150517726
Author: Bruce Ashfield<[email protected]>
Date:   Thu Oct 14 16:38:00 2010 -0400
powerpc/boot: remove -Os from BOOTFLAGS
Thanks,

Darren Hart

author

2011-08-10 06:21 UTC #4 lore raw

Quoted 27 lines · Bruce Ashfield

Quoted 4 lines · Darren Hart
Bruce,
The following patch is needed for qemuppc and fsl-mpc8315e-rdb (same reasons as before). Can you pull this in from the 2.6.37 yocto tree?
It should already be there for the fsl-mpc:
Quoted 1 line
git show f6a70a6408a5d173d69fe3dc26fdaece38b4be3c
commit f6a70a6408a5d173d69fe3dc26fdaece38b4be3c
Author: Bruce Ashfield <[email protected]>
Date:   Thu Oct 14 16:38:00 2010 -0400
powerpc/boot: remove -Os from BOOTFLAGS
Some variants of gcc 4.5 have issues with -Os and will throw:
cc1: error: Do not use -Os option if --enable-target-optspace is
not set.
-Os is not required to build a valid boot environment, so the easiest solution is to simply remove the boot flag.
Signed-off-by Bruce Ashfield <[email protected]>

Quoted 7 lines

Quoted 1 line
git branch --contains f6a70a6408a5d173d69fe3dc26fdaece38b4be3c
* yocto/standard/fsl-mpc8315e-rdb
I can add it for qemuppc, but I've been building it all along and have never seen the failure. What configuration are you building that is showing this ?

yocto/standard/preempt-rt/base

So we can create preempt-rt/fsl-mpc8315e-rdb and qemuppc, or we can just push the patch down into standard. As it only impacts powerpc builds, I don't see the harm in having it just in standard/base.

--
Darren

Quoted 13 lines

Bruce
Quoted 9 lines
commit 5ff609967ffe87c49d534d7861a7e0b150517726
Author: Bruce Ashfield<[email protected]>
Date:   Thu Oct 14 16:38:00 2010 -0400
powerpc/boot: remove -Os from BOOTFLAGS
Thanks,

Signature · 3 lines

Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel

Bruce Ashfield

2011-08-10 13:21 UTC #5 lore raw

Quoted 38 lines · Darren Hart

Quoted 27 lines · Bruce Ashfield
Quoted 4 lines · Darren Hart
Bruce,
The following patch is needed for qemuppc and fsl-mpc8315e-rdb (same reasons as before). Can you pull this in from the 2.6.37 yocto tree?
It should already be there for the fsl-mpc:
Quoted 1 line
git show f6a70a6408a5d173d69fe3dc26fdaece38b4be3c
commit f6a70a6408a5d173d69fe3dc26fdaece38b4be3c
Author: Bruce Ashfield<[email protected]>
Date:   Thu Oct 14 16:38:00 2010 -0400
powerpc/boot: remove -Os from BOOTFLAGS
Some variants of gcc 4.5 have issues with -Os and will throw:
cc1: error: Do not use -Os option if --enable-target-optspace is
not set.
-Os is not required to build a valid boot environment, so the easiest solution is to simply remove the boot flag.
Signed-off-by Bruce Ashfield<[email protected]>
Quoted 7 lines
Quoted 1 line
git branch --contains f6a70a6408a5d173d69fe3dc26fdaece38b4be3c
* yocto/standard/fsl-mpc8315e-rdb
I can add it for qemuppc, but I've been building it all along and have never seen the failure. What configuration are you building that is showing this ?

Quoted 5 lines

yocto/standard/preempt-rt/base
So we can create preempt-rt/fsl-mpc8315e-rdb and qemuppc, or we can just push the patch down into standard. As it only impacts powerpc builds, I don't see the harm in having it just in standard/base.

It can definitely be pushed down. This is all the proof that we need that it actually belongs there.

Bruce

Quoted 18 lines

--
Darren
Quoted 13 lines
Bruce
Quoted 9 lines
commit 5ff609967ffe87c49d534d7861a7e0b150517726
Author: Bruce Ashfield<[email protected]>
Date:   Thu Oct 14 16:38:00 2010 -0400
powerpc/boot: remove -Os from BOOTFLAGS
Thanks,