Skip to contentSkip to conversation

when to submit new board support

DISCUSSION Michael Jones 2 participants 3 messages Aug 10, 2011 – Aug 22, 2011

lore
Share & tools
lore
#0 lore raw

I would like to submit some patches to add support for a new OMAP board...

Is there a right or wrong time to post such patches to this list? How does the kernel merge window effect what kind of patches are expected here on the OMAP list?

What should I use as the base for my patches? At
http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap-2.6.git,
at the moment 'master' hasn't been updated for 4 weeks. Should I base it on v3.1-rc1 instead (as an example, since I won't manage to submit it while v3.1-rc1 is the most recent tag)?

thanks,
Michael

MATRIX VISION GmbH, Talstrasse 16, DE-71570 Oppenweiler
Registergericht: Amtsgericht Stuttgart, HRB 271090
Geschaeftsfuehrer: Gerhard Thullner, Werner Armingeon, Uwe Furtner, Erhard Meier

#1 lore raw
Quoted 5 lines · Michael Jones

I would like to submit some patches to add support for a new OMAP board...

Is there a right or wrong time to post such patches to this list? How does the kernel merge window effect what kind of patches are expected here on the OMAP list?

Well this is the right time, however we're moving things to device tree and coalescing code. So you may need to be prepared to update the patches a few times before we get them to mainline.

Quoted 5 lines

What should I use as the base for my patches? At
http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap-2.6.git,
at the moment 'master' hasn't been updated for 4 weeks. Should I base it on v3.1-rc1 instead (as an example, since I won't manage to submit it while v3.1-rc1 is the most recent tag)?

Yes v3.1-rc1 should be used as the base. I've been on vacation and have not updated the omap tree for a while, will updated it soonish, but will be just v3.1-rc1 + bug fixes.

Tony

#2 lore raw

Hi Tony,

Thanks for the reply.

Quoted 11 lines · Tony Lindgren
Quoted 5 lines · Michael Jones

I would like to submit some patches to add support for a new OMAP board...

Is there a right or wrong time to post such patches to this list? How does the kernel merge window effect what kind of patches are expected here on the OMAP list?

Well this is the right time, however we're moving things to device tree and coalescing code. So you may need to be prepared to update the patches a few times before we get them to mainline.

Unfortunately I am not ready to pull the trigger on submitting my code right _now_, so I was hoping to get a better understanding of the system- when the right time would be AND when the wrong time would be. I.e. what makes "this" the right time?

Also, I'm uncertain whether my submission will generally be welcome. Are there criteria for which boards are desirable to merge upstream? In April [1] you said in response to the inquiry about submitting support for the Nook Color that usually supporting a new machine adds "a few tens of lines". My machine is not even on the market yet, and its board file is currently 384 lines long, which is more than a few tens. I don't want to submit unwanted bloat.

I'm not familiar yet with Device Tree, so I don't understand what the implications are for existing supported boards and their board files, but I would of course be prepared to make necessary changes after review.

-Michael

[1] http://www.mail-archive.com/linux-omap%40vger.kernel.org/msg48348.html

Quoted 7 lines
Quoted 6 lines

What should I use as the base for my patches? At
http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap-2.6.git,
at the moment 'master' hasn't been updated for 4 weeks. Should I base it on v3.1-rc1 instead (as an example, since I won't manage to submit it while v3.1-rc1 is the most recent tag)?

Quoted 5 lines

Yes v3.1-rc1 should be used as the base. I've been on vacation and have not updated the omap tree for a while, will updated it soonish, but will be just v3.1-rc1 + bug fixes.

Tony

MATRIX VISION GmbH, Talstrasse 16, DE-71570 Oppenweiler
Registergericht: Amtsgericht Stuttgart, HRB 271090
Geschaeftsfuehrer: Gerhard Thullner, Werner Armingeon, Uwe Furtner, Erhard Meier