ERROR: "em28xx_add_into_devlist" [drivers/media/video/em28xx/em28xx.ko] undefined!

DISCUSSION Antti Palosaari 3 participants 7 messages Sep 4, 2011 – Sep 5, 2011 Media (V4L/DVB)

Share & tools

Antti Palosaari

author

2011-09-04 23:46 UTC #0 lore raw

Moikka,
Current linux-media make gives error. Any idea what's wrong?

Kernel: arch/x86/boot/bzImage is ready (#1)
Building modules, stage 2.
MODPOST 1907 modules
ERROR: "em28xx_add_into_devlist" [drivers/media/video/em28xx/em28xx.ko] undefined!
WARNING: modpost: Found 2 section mismatch(es).
To see full details build your kernel with:
'make CONFIG_DEBUG_SECTION_MISMATCH=y'
make[1]: *** [__modpost] Error 1
make: *** [modules] Error 2

regards
Antti

Signature · 1 line

http://palosaari.fi/

Chris Rankin

2011-09-05 00:15 UTC #1 lore raw

Quoted 4 lines · Antti Palosaari

Moikka,
Current linux-media make gives error. Any idea what's wrong?

Quoted 9 lines

Kernel: arch/x86/boot/bzImage is ready (#1)
Building modules, stage 2.
MODPOST 1907 modules
ERROR: "em28xx_add_into_devlist" [drivers/media/video/em28xx/em28xx.ko] undefined!
WARNING: modpost: Found 2 section mismatch(es).
To see full details build your kernel with:
'make CONFIG_DEBUG_SECTION_MISMATCH=y'
make[1]: *** [__modpost] Error 1
make: *** [modules] Error 2

The function em28xx_add_into_devlist() should have been deleted as part of this change:

http://git.linuxtv.org/media_tree.git?a=commitdiff;h=6c03e38b34dcfcdfa2f10cf984995a48f030f039

Its only reference should have been removed at the same time.

Cheers,
Chris

Chris Rankin

2011-09-05 00:24 UTC #6 lore raw

In reply to Antti Palosaari

Quoted 4 lines · Antti Palosaari

Moikka,
Current linux-media make gives error. Any idea what's wrong?

Quoted 9 lines

Kernel: arch/x86/boot/bzImage is ready (#1)
Building modules, stage 2.
MODPOST 1907 modules
ERROR: "em28xx_add_into_devlist" [drivers/media/video/em28xx/em28xx.ko] undefined!
WARNING: modpost: Found 2 section mismatch(es).
To see full details build your kernel with:
'make CONFIG_DEBUG_SECTION_MISMATCH=y'
make[1]: *** [__modpost] Error 1
make: *** [modules] Error 2

I think I see what's happened here. An extra reference to em28xx_add_into_devlist() has been added to em28xx_init_dev() at line 2888. This reference can be deleted because em28xx_init_extension() has been modified to add the struct em28xx to the devlist and then pass it to each extension's init() function all as a single operation.

Cheers,
Chris

Antti Palosaari

author

2011-09-05 00:25 UTC #2 lore raw

In reply to Chris Rankin

Quoted 16 lines · Chris Rankin

Quoted 4 lines · Antti Palosaari
Moikka,
Current linux-media make gives error. Any idea what's wrong?
Quoted 10 lines
Kernel: arch/x86/boot/bzImage is ready (#1)
Building modules, stage 2.
MODPOST 1907 modules
ERROR: "em28xx_add_into_devlist"
[drivers/media/video/em28xx/em28xx.ko] undefined!
WARNING: modpost: Found 2 section mismatch(es).
To see full details build your kernel with:
'make CONFIG_DEBUG_SECTION_MISMATCH=y'
make[1]: *** [__modpost] Error 1
make: *** [modules] Error 2

Quoted 7 lines

The function em28xx_add_into_devlist() should have been deleted as part of this change:
http://git.linuxtv.org/media_tree.git?a=commitdiff;h=6c03e38b34dcfcdfa2f10cf984995a48f030f039
Its only reference should have been removed at the same time.

git grep m28xx_add_into_devlis drivers/media/ drivers/media/video/em28xx/em28xx-cards.c: em28xx_add_into_devlist(dev); drivers/media/video/em28xx/em28xx.h:void em28xx_add_into_devlist(struct em28xx *dev);

If you select em28xx-cards.c blob link you give you can see it is there still for some reason.

regards
Antti

Signature · 1 line

http://palosaari.fi/

Chris Rankin

2011-09-05 00:34 UTC #3 lore raw

Quoted 2 lines · Antti Palosaari

If you select em28xx-cards.c blob link you give you can see it is there still for some reason.

It's a merge issue. This lingering reference must have been added after I posted my original patch. Fortunately, it's easily fixed: the

    list_add_tail(&dev->devlist, &em28xx_devlist);

operation is now done by ex28xx_init_extension() instead, meaning we only take the devlist mutex once. So that last em28xx_add_into_devlist() reference is obsolete.

Cheers,
Chris

Mauro Carvalho Chehab

2011-09-05 13:58 UTC #4 lore raw

Em 04-09-2011 21:34, Chris Rankin escreveu:

Quoted 9 lines · Antti Palosaari

Quoted 2 lines
If you select em28xx-cards.c blob link you give you can see it is there still for some reason.
It's a merge issue. This lingering reference must have been added after I posted my original patch. Fortunately, it's easily fixed: the
list_add_tail(&dev->devlist, &em28xx_devlist);
operation is now done by ex28xx_init_extension() instead, meaning we only take the devlist mutex once. So that last em28xx_add_into_devlist() reference is obsolete.

Could you please provide me a patch for it? I'll merge with your original one when submitting it upstream.

Quoted 4 lines

Cheers,
Chris

Chris Rankin

2011-09-05 14:26 UTC #5 lore raw

Quoted 2 lines · Mauro Carvalho Chehab

Could you please provide me a patch for it? I'll merge with your original one when submitting it upstream.

Here you go. Did you also pick up the other merge fix and the (separate) memory leak fix, please?

Cheers,
Chris

Signed-off-by Chris Rankin <[email protected]>

drivers/media/video/em28xx/em28xx-cards.c renamed from drivers/media/video/em28xx/em28xx-cards.c.orig +0 -1

@@ -2885,7 +2885,6 @@
 		retval = em28xx_audio_setup(dev);
 		if (retval)
 			return -ENODEV;
-		em28xx_add_into_devlist(dev);
 		em28xx_init_extension(dev);
 
 		return 0;