Implement new list text naming scheme
Could a C coder please review this changeset for me? There's nothing too technical in it so any proficient C coder should be able to review it adequately. It's only had a very small amount of testing so far, but seems to work.
http://mlmmj.org/hg/mlmmj/rev/c3ee2bfaeb02
(After this, the substitution mechanism needs to be reworked, which will need a code review, and then the new list texts can be tested. Then I will just fix a few easy and high priority bugs before releasing a beta. Other bug fixes and enhancements can wait for another release which I expect will follow much more quickly.)
Ben.
-------- Original Message --------
Subject: [mlmmj commits] Implement new list text naming scheme
Date: Sat, 10 Sep 2011 06:03:15 +0300
From: mlmmj hg <[email protected]>
Reply-To: <[email protected]>
To: [email protected]
o changeset: http://mlmmj.org/hg/mlmmj/rev/c3ee2bfaeb02 | tag: tip | user: Ben Schmidt | date: Sat Sep 10 12:23:40 2011 +1000 | description: | Implement new list text naming scheme | | Also fix a bug where the normal list text would be sent when unsubscribing | from the nomail version of the list | | Also fix some minor documentation bugs | | o changeset: http://mlmmj.org/hg/mlmmj/rev/9f503b69a55d | user: Ben Schmidt | date: Mon Mar 07 01:30:02 2011 +1100 | description: | Update documentation to reflect intended changes to list text naming | | o changeset: http://mlmmj.org/hg/mlmmj/rev/8c4064ce228e | user: Ben Schmidt | date: Tue Feb 22 10:16:40 2011 +1100 | description: | Mark a bunch of stuff as deprecated. | | Replacing some generic stuff with even more generic stuff, looking forward to | the day when we will do things like http://$www$.$domain$/$list$/archive. | | o changeset: http://mlmmj.org/hg/mlmmj/rev/6f8df4842d91 | user: Ben Schmidt | date: Tue Feb 22 10:12:42 2011 +1100 | description: | Add a space to $controlN$ substitution and improve documentation. | | o changeset: http://mlmmj.org/hg/mlmmj/rev/21265d660d19 | user: Ben Schmidt | date: Mon Mar 07 00:30:58 2011 +1100 | description: | Added forgotten ChangeLog entry
|
|
Quoted 7 lines · Ben Schmidt
Could a C coder please review this changeset for me? There's nothing too technical in it so any proficient C coder should be able to review it adequately. It's only had a very small amount of testing so far, but seems to work.
Quoted 7 lines
(After this, the substitution mechanism needs to be reworked, which will need a code review, and then the new list texts can be tested. Then I will just fix a few easy and high priority bugs before releasing a beta. Other bug fixes and enhancements can wait for another release which I expect will follow much more quickly.)
Ben.
I had a quick look, and as you said, there's not much in this patch that could be seen as suspicious. Few functional tests should be enough.
Thomas
Thank you, Thomas. That was a very quick reply.
Ben.
Quoted 23 lines · Thomas Goirand
Quoted 7 lines · Ben Schmidt
Could a C coder please review this changeset for me? There's nothing too technical in it so any proficient C coder should be able to review it adequately. It's only had a very small amount of testing so far, but seems to work.
Quoted 7 lines
(After this, the substitution mechanism needs to be reworked, which will need a code review, and then the new list texts can be tested. Then I will just fix a few easy and high priority bugs before releasing a beta. Other bug fixes and enhancements can wait for another release which I expect will follow much more quickly.)
Ben.
I had a quick look, and as you said, there's not much in this patch that could be seen as suspicious. Few functional tests should be enough.
Thomas