Skip to contentSkip to conversation

Warning

U-Boot Albert ARIBAUD 3 participants 5 messages Sep 12, 2011

lore
Share & tools
lore
#0 lore raw

Sanjeev, Sandeep,

I see a lot of this warning in many OMAP boards:

---------------------
Configuring for omap4_sdp4430 board...
gpio.c: In function 'omap_get_gpio_dataout':
gpio.c:161: warning: assignment discards qualifiers from pointer target type
---------------------

Commit 5c2684dbebe9df47ea0a1865ed94db7886ea5941, I assume, is what brought this in, but I cannot verify this right now, as I am in the middle of aMAKEALL arm.

Can someone look up what causes this warning?

Amicalement,

Signature · 1 line
Albert.
#1 lore raw
Quoted 17 lines

-----Original Message-----
From: Albert ARIBAUD [mailto:albert.u.boot at aribaud.net]
Sent: Monday, September 12, 2011 12:06 PM
To: U-Boot; Premi, Sanjeev; Paulraj, Sandeep
Subject: Warning

Sanjeev, Sandeep,

I see a lot of this warning in many OMAP boards:

---------------------
Configuring for omap4_sdp4430 board...
gpio.c: In function 'omap_get_gpio_dataout':
gpio.c:161: warning: assignment discards qualifiers from pointer target type
---------------------

Quoted 5 lines

Commit 5c2684dbebe9df47ea0a1865ed94db7886ea5941, I assume, is what brought this in, but I cannot verify this right now, as I am in the middle of aMAKEALL arm.

Can someone look up what causes this warning?

[sp] I just started looking into this.
Expect a response in next 30 mins.

~sanjeev

Quoted 5 lines

Amicalement,

Signature · 1 line
Albert.
#2 lore raw
In reply to Albert ARIBAUD
Quoted 8 lines

-----Original Message-----
From: Albert ARIBAUD [mailto:albert.u.boot at aribaud.net]
Sent: Monday, September 12, 2011 12:06 PM
To: U-Boot; Premi, Sanjeev; Paulraj, Sandeep
Subject: Warning

Sanjeev, Sandeep,

Quoted 8 lines

I see a lot of this warning in many OMAP boards:

---------------------
Configuring for omap4_sdp4430 board...
gpio.c: In function 'omap_get_gpio_dataout':
gpio.c:161: warning: assignment discards qualifiers from pointer target type
---------------------

Albert,

Which branch are you seeing this warning on?

I was able to build the u-boot successfully for "omap4_sdp4430" using codesourcery 2011.03-41 and codesourcery2009q1-203 on the u-boot-arm/master at:

4f02fba : omap4: fix pad configuration settings for SDP and Panda 3e90493 : omap4: IO settings
a5b6a6c : omap4: make SDRAM init work for ES1.0 silicon e5c06a0 : omap4: factor out common part from board config headers 9a18112 : omap: gpio: Adapt board files to use generic API d7605af : omap: gpio: generic changes after changing API 5b5c435 : omap: gpio: Use generic API
c7a993f : led: remove camel casing of led identifiers globally

Infact, the function "omap_get_gpio_dataout" shouldn't exist as it was replaced with generic gpio API in commit "5b5c435" listed above.

Believeing that you were trying to build the u-boot master, I tried to check there, but always get stuck with different errors:

premi # make omap4_sdp4430_config
Configuring for omap4_sdp4430 board...
premi # make > bld-master.log
make[1]: *** No rule to make target /home/premi/u-boot/include/configs/omap4_common.h', needed by hello_world.o'. Stop.
make: *** [examples/standalone] Error 2
premi # make distclean
premi # make omap3_evm_config
Configuring for omap3_evm board...
premi # make >> bld-master.log
make[1]: *** No rule to make target /home/premi/u-boot/include/configs/omap4_common.h', needed by hello_world.o'. Stop.
make: *** [examples/standalone] Error 2

Quoted 5 lines

Commit 5c2684dbebe9df47ea0a1865ed94db7886ea5941, I assume, is what brought this in, but I cannot verify this right now, as I am in the middle of aMAKEALL arm.

Couldn't find this commit in my repo may be, because I am tracking only master. But wasn't able to find via gitweb either on:
http://git.denx.de/?p=u-boot/u-boot-arm.git;a=shortlog

~sanjeev

Quoted 6 lines

Can someone look up what causes this warning?

Amicalement,

Signature · 1 line
Albert.
#3 lore raw
Quoted 48 lines

-----Original Message-----
From: u-boot-bounces at lists.denx.de [mailto:u-boot-bounces at lists.denx.de] On Behalf Of Premi, Sanjeev
Sent: Monday, September 12, 2011 2:42 PM
To: Albert ARIBAUD; U-Boot; Paulraj, Sandeep
Subject: Re: [U-Boot] Warning

Quoted 8 lines

-----Original Message-----
From: Albert ARIBAUD [mailto:albert.u.boot at aribaud.net]
Sent: Monday, September 12, 2011 12:06 PM
To: U-Boot; Premi, Sanjeev; Paulraj, Sandeep
Subject: Warning

Sanjeev, Sandeep,

Quoted 8 lines

I see a lot of this warning in many OMAP boards:

---------------------
Configuring for omap4_sdp4430 board...
gpio.c: In function 'omap_get_gpio_dataout':
gpio.c:161: warning: assignment discards qualifiers from pointer target type
---------------------

Albert,

Which branch are you seeing this warning on?

I was able to build the u-boot successfully for "omap4_sdp4430" using codesourcery 2011.03-41 and codesourcery2009q1-203 on the u-boot-arm/master
at:

4f02fba : omap4: fix pad configuration settings for SDP and Panda 3e90493 : omap4: IO settings
a5b6a6c : omap4: make SDRAM init work for ES1.0 silicon e5c06a0 : omap4: factor out common part from board config headers 9a18112 : omap: gpio: Adapt board files to use generic API d7605af : omap: gpio: generic changes after changing API 5b5c435 : omap: gpio: Use generic API
c7a993f : led: remove camel casing of led identifiers globally

Infact, the function "omap_get_gpio_dataout" shouldn't exist as it was replaced with generic gpio API in commit "5b5c435" listed above.

Believeing that you were trying to build the u-boot master, I tried to check there, but always get stuck with different errors:

Quoted 15 lines

premi # make omap4_sdp4430_config
Configuring for omap4_sdp4430 board...
premi # make > bld-master.log
make[1]: *** No rule to make target /home/premi/u-boot/include/configs/omap4_common.h', needed by hello_world.o'. Stop.
make: *** [examples/standalone] Error 2
premi # make distclean
premi # make omap3_evm_config
Configuring for omap3_evm board...
premi # make >> bld-master.log
make[1]: *** No rule to make target /home/premi/u-boot/include/configs/omap4_common.h', needed by hello_world.o'. Stop.
make: *** [examples/standalone] Error 2

It appears the .depend files are not getting cleaned by distclean. When I deleted them manually, I was able to build for omap3_evm_config but then faced similar problem when building for omap4_sdp4430_config.

~sanjeev

Here is the log from my work session:

premi # make >> bld-master.log
make[1]: *** No rule to make target /home/premi/u-boot/include/configs/omap4_common.h', needed by hello_world.o'. Stop.
make: *** [examples/standalone] Error 2
premi # make distclean
premi # make omap3_evm_config
Configuring for omap3_evm board...
premi #
premi # make >> bld-master.log
make[1]: *** No rule to make target /home/premi/u-boot/include/configs/omap4_common.h', needed by hello_world.o'. Stop.
make: *** [examples/standalone] Error 2
premi # make examples/standalone/hello_world.o

CORRECT> make examples/standalone/hello_world.c (y|n|e)?no
arm-none-linux-gnueabi-gcc -g -Os -fno-common -ffixed-r8 -msoft-float -D__
KERNEL__ -DCONFIG_SYS_TEXT_BASE=0x80008000 -I/home/premi/u-boot/I nclude -fno-builtin -ffreestanding -nostdinc -isystem /opt/codesourcery/2009q1-2 03/bin/../lib/gcc/arm-none-linux-gnueabi/4.3.3/include -pipe -DCONFIG_ARM -D__A RM__ -marm -mabi=aapcs-linux -mno-thumb-interwork -march=armv5 -Wall -Wstrict-p
rototypes -fno-stack-protector -Wno-format-nonliteral -Wno-format-security -o
examples/standalone/hello_world.o examples/standalone/hello_world.c -c premi #
premi #
premi #
premi # make distclean
premi #
premi # pwd
/home/premi/u-boot
premi # make distclean
premi # find . -print | grep depend
./api/.depend
./board/ti/sdp4430/.depend
./common/.depend
./disk/.depend
./drivers/bios_emulator/.depend
./drivers/block/.depend
./drivers/dma/.depend
./drivers/fpga/.depend
./drivers/gpio/.depend
./drivers/hwmon/.depend

[... list of files trimmed here ...]

./spl/drivers/i2c/.depend
./spl/drivers/mmc/.depend
./spl/drivers/serial/.depend
./spl/fs/fat/.depend
./spl/lib/.depend
premi # find . -print | grep depend | xargs rm

CORRECT> find . -print | grep depend | xargs arm (y|n|e)?no
premi # make omap3_evm_config
awk '(NF && $1 !~ /^#/) { print $1 ": " $1 "_config; $(MAKE)" }' boards.cfg > .boards.depend Configuring for omap3_evm board...
premi # make >> bld-master.log
premi #
premi # make distclean
premi # make omap4_sdp4430_config
Configuring for omap4_sdp4430 board...
premi # make >> bld-master.log
make[1]: *** No rule to make target /home/premi/u-boot/include/asm/arch/omap3.h', needed by hello_world.o'. Stop.
make: *** [examples/standalone] Error 2
premi # find . -print | grep depend | xargs rm

CORRECT> find . -print | grep depend | xargs arm (y|n|e)?no
premi # make omap4_sdp4430_config
awk '(NF && $1 !~ /^#/) { print $1 ": " $1 "_config; $(MAKE)" }' boards.cfg > .boards.depend Configuring for omap4_sdp4430 board...
premi # make >> bld-master.log
premi #

Quoted 25 lines
Quoted 6 lines

Commit 5c2684dbebe9df47ea0a1865ed94db7886ea5941, I assume, is what brought this in, but I cannot verify this right now, as I am in the middle of aMAKEALL arm.

Couldn't find this commit in my repo may be, because I am tracking only
master. But wasn't able to find via gitweb either on:
http://git.denx.de/?p=u-boot/u-boot-arm.git;a=shortlog

~sanjeev

Quoted 6 lines

Can someone look up what causes this warning?

Amicalement,

Signature · 1 line
Albert.

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

#4 lore raw

Dear "Premi, Sanjeev",

Quoted 2 lines · In message <[email protected]> you…

It appears the .depend files are not getting cleaned by distclean.

This would then be another bug that needs to be fixed.

Note: you can try "git clean -n -x" to find any files not registered in the git repo; after a "make distclean" no such files must exist. [And you can use "git clean -f -x" to actually delete any such files.]

Best regards,

Wolfgang Denk

Signature · 6 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Is truth not truth for all?
	-- Natira, "For the World is Hollow and I have Touched
		   the Sky", stardate 5476.4.