ALSA: HDA: Cirrus - fix "Surround Speaker" volume control, name

PATCH In review David Henningsson 3 participants 7 messages Sep 14, 2011 Sound

lore

Share & tools

lore

David Henningsson

author

2011-09-14 11:25 UTC #0 lore raw

PATCH 1/1 ALSA: HDA: Cirrus - fix "Surround Speaker" volume control, name

Commit b4dabfc452a10 fixed only the "Switch" name, not the "Volume" name.

Signature · 2 lines

David Henningsson, Canonical Ltd.
http://launchpad.net/~diwic

Quoted 1 line

From 7d63b3c06a02d107d9f499c43d6396ada9caae98 Mon Sep 17 00:00:00 2001

From: David Henningsson <[email protected]>
Date: Wed, 14 Sep 2011 13:22:54 +0200
Subject: [PATCH] ALSA: HDA: Cirrus - fix "Surround Speaker" volume control
name

Commit b4dabfc452a10 fixed only the "Switch" name, not the "Volume" name.

Signed-off-by David Henningsson <[email protected]>

---
 sound/pci/hda/patch_cirrus.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

sound/pci/hda/patch_cirrus.c +1 -1

index d6c93d9..c45f3e6 100644
@@ -535,7 +535,7 @@ static int add_volume(struct hda_codec *codec, const char *name,
 		      int index, unsigned int pval, int dir,
 		      struct snd_kcontrol **kctlp)
 {
-	char tmp[32];
+	char tmp[44];
 	struct snd_kcontrol_new knew =
 		HDA_CODEC_VOLUME_IDX(tmp, index, 0, 0, HDA_OUTPUT);
 	knew.private_value = pval;

Signature · 1 line

1.7.5.4

Takashi Iwai

2011-09-14 11:35 UTC #1 lore raw

At Wed, 14 Sep 2011 13:25:55 +0200,

Quoted 19 lines · David Henningsson

Quoted 2 lines
From 7d63b3c06a02d107d9f499c43d6396ada9caae98 Mon Sep 17 00:00:00 2001
From: David Henningsson <[email protected]>
Date: Wed, 14 Sep 2011 13:22:54 +0200
Subject: [PATCH] ALSA: HDA: Cirrus - fix "Surround Speaker" volume control
name
Commit b4dabfc452a10 fixed only the "Switch" name, not the "Volume" name.
Signed-off-by David Henningsson <[email protected]>
---
 sound/pci/hda/patch_cirrus.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
sound/pci/hda/patch_cirrus.c +0 -0
index d6c93d9..c45f3e6 100644

sound/pci/hda/patch_cirrus.c static int add_volume(struct hda_codec *codec, const char *name, · line 541

Quoted 8 lines

sound/pci/hda/patch_cirrus.c +1 -1

@@ -535,7 +535,7 @@ static int add_volume(struct hda_codec *codec, const char *name,
 		      int index, unsigned int pval, int dir,
 		      struct snd_kcontrol **kctlp)
 {
-	char tmp[32];
+	char tmp[44];
 	struct snd_kcontrol_new knew =
 		HDA_CODEC_VOLUME_IDX(tmp, index, 0, 0, HDA_OUTPUT);
 	knew.private_value = pval;

Hm, it doesn't match with the patch description...

Takashi

David Henningsson

author

2011-09-14 11:39 UTC #2 lore raw

Quoted 16 lines · Takashi Iwai

At Wed, 14 Sep 2011 13:25:55 +0200,
Quoted 14 lines · David Henningsson
Quoted 2 lines
From 7d63b3c06a02d107d9f499c43d6396ada9caae98 Mon Sep 17 00:00:00 2001
From: David Henningsson<[email protected]>
Date: Wed, 14 Sep 2011 13:22:54 +0200
Subject: [PATCH] ALSA: HDA: Cirrus - fix "Surround Speaker" volume control
name
Commit b4dabfc452a10 fixed only the "Switch" name, not the "Volume" name.
Signed-off-by David Henningsson<[email protected]>
---
  sound/pci/hda/patch_cirrus.c |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)

Quoted 15 lines

sound/pci/hda/patch_cirrus.c static int add_volume(struct hda_codec *codec, const char *name, · line 541
Quoted 13 lines
sound/pci/hda/patch_cirrus.c +1 -1
index d6c93d9..c45f3e6 100644
@@ -535,7 +535,7 @@ static int add_volume(struct hda_codec *codec, const char *name,
  		      int index, unsigned int pval, int dir,
  		      struct snd_kcontrol **kctlp)
  {
-	char tmp[32];
+	char tmp[44];
  	struct snd_kcontrol_new knew =
  		HDA_CODEC_VOLUME_IDX(tmp, index, 0, 0, HDA_OUTPUT);
  	knew.private_value = pval;
Hm, it doesn't match with the patch description...

Sorry, can you clarify what I have to do to get this patch committed?

Signature · 2 lines

David Henningsson, Canonical Ltd.
http://launchpad.net/~diwic

Takashi Iwai

2011-09-14 11:41 UTC #3 lore raw

At Wed, 14 Sep 2011 13:38:58 +0200,

Quoted 34 lines · David Henningsson

Quoted 16 lines · Takashi Iwai
At Wed, 14 Sep 2011 13:25:55 +0200,
Quoted 14 lines · David Henningsson
Quoted 2 lines
From 7d63b3c06a02d107d9f499c43d6396ada9caae98 Mon Sep 17 00:00:00 2001
From: David Henningsson<[email protected]>
Date: Wed, 14 Sep 2011 13:22:54 +0200
Subject: [PATCH] ALSA: HDA: Cirrus - fix "Surround Speaker" volume control
name
Commit b4dabfc452a10 fixed only the "Switch" name, not the "Volume" name.
Signed-off-by David Henningsson<[email protected]>
---
  sound/pci/hda/patch_cirrus.c |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)
Quoted 15 lines
sound/pci/hda/patch_cirrus.c static int add_volume(struct hda_codec *codec, const char *name, · line 541
Quoted 13 lines
sound/pci/hda/patch_cirrus.c +1 -1
index d6c93d9..c45f3e6 100644
@@ -535,7 +535,7 @@ static int add_volume(struct hda_codec *codec, const char *name,
  		      int index, unsigned int pval, int dir,
  		      struct snd_kcontrol **kctlp)
  {
-	char tmp[32];
+	char tmp[44];
  	struct snd_kcontrol_new knew =
  		HDA_CODEC_VOLUME_IDX(tmp, index, 0, 0, HDA_OUTPUT);
  	knew.private_value = pval;
Hm, it doesn't match with the patch description...

Quoted 1 line

Sorry, can you clarify what I have to do to get this patch committed?

Dunno, the full moon was over, no? :)

Takashi

David Henningsson

author

2011-09-14 11:42 UTC #4 lore raw

Re: [PATCH] ALSA: HDA: Cirrus - fix "Surround Speaker" volume control name

In reply to Takashi Iwai

Quoted 16 lines · Takashi Iwai

At Wed, 14 Sep 2011 13:25:55 +0200,
Quoted 14 lines · David Henningsson
Quoted 2 lines
From 7d63b3c06a02d107d9f499c43d6396ada9caae98 Mon Sep 17 00:00:00 2001
From: David Henningsson<[email protected]>
Date: Wed, 14 Sep 2011 13:22:54 +0200
Subject: [PATCH] ALSA: HDA: Cirrus - fix "Surround Speaker" volume control
name
Commit b4dabfc452a10 fixed only the "Switch" name, not the "Volume" name.
Signed-off-by David Henningsson<[email protected]>
---
  sound/pci/hda/patch_cirrus.c |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)

Quoted 15 lines

sound/pci/hda/patch_cirrus.c static int add_volume(struct hda_codec *codec, const char *name, · line 541
Quoted 13 lines
sound/pci/hda/patch_cirrus.c +1 -1
index d6c93d9..c45f3e6 100644
@@ -535,7 +535,7 @@ static int add_volume(struct hda_codec *codec, const char *name,
  		      int index, unsigned int pval, int dir,
  		      struct snd_kcontrol **kctlp)
  {
-	char tmp[32];
+	char tmp[44];
  	struct snd_kcontrol_new knew =
  		HDA_CODEC_VOLUME_IDX(tmp, index, 0, 0, HDA_OUTPUT);
  	knew.private_value = pval;
Hm, it doesn't match with the patch description...

Better commit message now?

Signature · 2 lines

David Henningsson, Canonical Ltd.
http://launchpad.net/~diwic

Quoted 1 line

From cd0944c76e1d43e15aa5147546ede32813e85901 Mon Sep 17 00:00:00 2001

From: David Henningsson <[email protected]>
Date: Wed, 14 Sep 2011 13:22:54 +0200
Subject: [PATCH] ALSA: HDA: Cirrus - fix "Surround Speaker" volume control
name

This patch fixes "Surround Speaker Playback Volume" being cut off. (Commit b4dabfc452a10 was probably meant to fix this, but it fixed only the "Switch" name, not the "Volume" name.)

Signed-off-by David Henningsson <[email protected]>

---
 sound/pci/hda/patch_cirrus.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

sound/pci/hda/patch_cirrus.c +1 -1

index d6c93d9..c45f3e6 100644
@@ -535,7 +535,7 @@ static int add_volume(struct hda_codec *codec, const char *name,
 		      int index, unsigned int pval, int dir,
 		      struct snd_kcontrol **kctlp)
 {
-	char tmp[32];
+	char tmp[44];
 	struct snd_kcontrol_new knew =
 		HDA_CODEC_VOLUME_IDX(tmp, index, 0, 0, HDA_OUTPUT);
 	knew.private_value = pval;

Signature · 1 line

1.7.5.4

Paul Menzel

2011-09-14 12:02 UTC #6 lore raw

In reply to David Henningsson

Am Mittwoch, den 14.09.2011, 13:25 +0200 schrieb David Henningsson:

Quoted 1 line

Commit b4dabfc452a10 fixed only the "Switch" name, not the "Volume" name.

Remembering commit IDs is quite hard, so adding the commit summary in for example parentheses is a good way to at least help me to understand the message better. ;-)

Thanks,

Paul

Takashi Iwai

2011-09-14 12:05 UTC #5 lore raw

Re: [PATCH] ALSA: HDA: Cirrus - fix "Surround Speaker" volume control name

In reply to David Henningsson

At Wed, 14 Sep 2011 13:42:52 +0200,

Quoted 35 lines · David Henningsson

[1 <text/plain; ISO-8859-1 (7bit)>]
Quoted 16 lines · Takashi Iwai
At Wed, 14 Sep 2011 13:25:55 +0200,
Quoted 14 lines · David Henningsson
Quoted 2 lines
From 7d63b3c06a02d107d9f499c43d6396ada9caae98 Mon Sep 17 00:00:00 2001
From: David Henningsson<[email protected]>
Date: Wed, 14 Sep 2011 13:22:54 +0200
Subject: [PATCH] ALSA: HDA: Cirrus - fix "Surround Speaker" volume control
name
Commit b4dabfc452a10 fixed only the "Switch" name, not the "Volume" name.
Signed-off-by David Henningsson<[email protected]>
---
  sound/pci/hda/patch_cirrus.c |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)
Quoted 15 lines
sound/pci/hda/patch_cirrus.c static int add_volume(struct hda_codec *codec, const char *name, · line 541
Quoted 13 lines
sound/pci/hda/patch_cirrus.c +1 -1
index d6c93d9..c45f3e6 100644
@@ -535,7 +535,7 @@ static int add_volume(struct hda_codec *codec, const char *name,
  		      int index, unsigned int pval, int dir,
  		      struct snd_kcontrol **kctlp)
  {
-	char tmp[32];
+	char tmp[44];
  	struct snd_kcontrol_new knew =
  		HDA_CODEC_VOLUME_IDX(tmp, index, 0, 0, HDA_OUTPUT);
  	knew.private_value = pval;
Hm, it doesn't match with the patch description...

Quoted 1 line

Better commit message now?

Yep, more understandable. Applied now (with Cc to stable).

thanks,

Takashi

Quoted 37 lines

Signature · 4 lines
-- 
David Henningsson, Canonical Ltd.
http://launchpad.net/~diwic
[2 0001-ALSA-HDA-Cirrus-fix-Surround-Speaker-volume-control-.patch <text/x-patch (7bit)>]
Quoted 1 line
From cd0944c76e1d43e15aa5147546ede32813e85901 Mon Sep 17 00:00:00 2001
From: David Henningsson <[email protected]>
Date: Wed, 14 Sep 2011 13:22:54 +0200
Subject: [PATCH] ALSA: HDA: Cirrus - fix "Surround Speaker" volume control
name
This patch fixes "Surround Speaker Playback Volume" being cut off. (Commit b4dabfc452a10 was probably meant to fix this, but it fixed only the "Switch" name, not the "Volume" name.)
Signed-off-by David Henningsson <[email protected]>
---
 sound/pci/hda/patch_cirrus.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
sound/pci/hda/patch_cirrus.c +1 -1
index d6c93d9..c45f3e6 100644
@@ -535,7 +535,7 @@ static int add_volume(struct hda_codec *codec, const char *name,
 		      int index, unsigned int pval, int dir,
 		      struct snd_kcontrol **kctlp)
 {
-	char tmp[32];
+	char tmp[44];
 	struct snd_kcontrol_new knew =
 		HDA_CODEC_VOLUME_IDX(tmp, index, 0, 0, HDA_OUTPUT);
 	knew.private_value = pval;
Signature · 1 line
1.7.5.4