policycoreutils: fixfiles: FIXME label /root but not

From 0af95817aaac37be5b7bd502df4894bd3e03d4d7 Mon Sep 17 00:00:00 2001
From: Eric Paris <[email protected]>
Date: Sun, 10 Jul 2011 16:25:18 +0200
Subject: [PATCH 10/67] policycoreutils: fixfiles: FIXME label /root but not
/var/lib/BackupPC

This patch removes /root from the excluded dirs.

This also adds /var/lib/BackupPC to list of directories to ignore labeling. Mainly because this directory tends to be Huge and causes a huge spike in the amount of time it takes to relabel. Especially if there is a relabel caused by a policy update.

I'm not certain if either/both of these changes are appropriate.

NOT-Signed-off-by Eric Paris <[email protected]>

---
 policycoreutils/scripts/fixfiles |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

policycoreutils/scripts/fixfiles +0 -0

index e4e5f0d..27dcccf 100755

Quoted 19 lines · Daniel J Walsh

From 0af95817aaac37be5b7bd502df4894bd3e03d4d7 Mon Sep 17 00:00:00 2001 From: Eric Paris <[email protected]> Date: Sun, 10 Jul 2011 16:25:18 +0200 Subject: [PATCH 10/67] policycoreutils: fixfiles:
FIXME label /root but not /var/lib/BackupPC

This patch removes /root from the excluded dirs.

This also adds /var/lib/BackupPC to list of directories to ignore labeling. Mainly because this directory tends to be Huge and causes a huge spike in the amount of time it takes to relabel. Especially if there is a relabel caused by a policy update.

I'm not certain if either/both of these changes are appropriate.

NOT-Signed-off-by Eric Paris <[email protected]> ---

policycoreutils/scripts/fixfiles | 2 +- 1 files changed, 1
insertions(+), 1 deletions(-)

Quoted 8 lines

(quoted diff) +0 -0

b/policycoreutils/scripts/fixfiles index e4e5f0d..27dcccf 100755 --- a/policycoreutils/scripts/fixfiles +++ b/policycoreutils/scripts/fixfiles @@ -103,7 +103,7 @@ exclude_dirs_from_relabelling() {

exclude_dirs() { exclude= - for i in /home /root /tmp /dev;
do + for i in /var/lib/BackupPC /home /tmp /dev; do

Not everybody uses BackupPC, but just in case, you could make it more general by adapting at run-time to
http://backuppc.sourceforge.net/faq/BackupPC.html#_conf_topdir_

In other words, could read the BackupPC configuration file, if a different TopDir is being used instead of default /var/lib/BackupPC then exclude that.

Quoted 2 lines

[ -e $i ] && exclude="$exclude -e $i"; done exclude="$exclude exclude_dirs_from_relabelling"

Guido

Quoted 27 lines · Daniel J Walsh

From 0af95817aaac37be5b7bd502df4894bd3e03d4d7 Mon Sep 17 00:00:00 2001
From: Eric Paris <[email protected]>
Date: Sun, 10 Jul 2011 16:25:18 +0200
Subject: [PATCH 10/67] policycoreutils: fixfiles: FIXME label /root but not
/var/lib/BackupPC

This patch removes /root from the excluded dirs.

This also adds /var/lib/BackupPC to list of directories to ignore labeling. Mainly because this directory tends to be Huge and causes a huge spike in the amount of time it takes to relabel. Especially if there is a relabel caused by a policy update.

I'm not certain if either/both of these changes are appropriate.

NOT-Signed-off-by Eric Paris <[email protected]>

---
 policycoreutils/scripts/fixfiles |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

policycoreutils/scripts/fixfiles +0 -0

index e4e5f0d..27dcccf 100755

policycoreutils/scripts/fixfiles exclude_dirs_from_relabelling() { · line 106

Quoted 5 lines

policycoreutils/scripts/fixfiles +1 -1

@@ -103,7 +103,7 @@ exclude_dirs_from_relabelling() {
 
 exclude_dirs() {
     exclude=
-    for i in /home /root /tmp /dev; do
+    for i in /var/lib/BackupPC /home /tmp /dev; do

Not everybody uses BackupPC, but just in case, you could make it more general by adapting at run-time to
http://backuppc.sourceforge.net/faq/BackupPC.html#_conf_topdir_

In other words, could read the BackupPC configuration file, if a different TopDir is being used instead of default /var/lib/BackupPC then exclude that.