libsepol: Preserve tunables when required by semodule
PATCH 51/67 libsepol: Preserve tunables when required by semodule
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
This patch looks good to me. acked.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEARECAAYFAk5yV/4ACgkQrlYvE4MpobPXdQCeOTiLhF/U8qUdlMk5F0ZZvNhS LXkAn1f2NBX+bqe7X6aFAw8Cbvyp1g2x
=vIAs
-----END PGP SIGNATURE-----
Quoted 20 lines · Daniel J Walsh
From
f2a839faa71dac0bc575615bfe0aafca94a00892Mon Sep 17 00:00:00 2001
From: Harry Ciao <[email protected]>
Date: Thu, 1 Sep 2011 11:29:47 +0800
Subject: [PATCH 51/67] libsepol: Preserve tunables when required by semodule
program.If the "-P/--preserve_tunables" option is set for the semodule program,
thepreserve_tunablesflag insepol_handle_twould be set, then all tunables
would be treated as booleans by having their TUNABLE flag bit cleared, resulting in all tunables if-else conditionals preserved for raw policy.Note, such option would invalidate the logic to double-check if tunables
ever mix with booleans in one expression, so skip the call toassert()when this option is passed.
Quoted 5 lines
Signed-off-by Harry Ciao <[email protected]>Signed-off-by Eric Paris <[email protected]>--- libsepol/src/expand.c | 36 ++++++++++++++++++++++++------------ 1 files changed, 24 insertions(+), 12 deletions(-)
Hello Dan.
The new option seems not fully enabled yet by parsing the option and setting the preserve_tunables flag appropriately in main().
Is it going to be enabled elsewhere ?
Guido
--
This message was distributed to subscribers of the selinux mailing list. If you no longer wish to subscribe, send mail to [email protected] with the words "unsubscribe selinux" without quotes as the message.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Quoted 22 lines · Guido Trentalancia
Quoted 15 lines · Daniel J Walsh
From
f2a839faa71dac0bc575615bfe0aafca94a00892Mon Sep 17 00:00:00 2001 From: Harry Ciao <[email protected]> Date: Thu, 1 Sep 2011 11:29:47 +0800 Subject: [PATCH 51/67] libsepol: Preserve tunables when required by semodule program.If the "-P/--preserve_tunables" option is set for the semodule program, the
preserve_tunablesflag insepol_handle_twould be set, then all tunables would be treated as booleans by having their TUNABLE flag bit cleared, resulting in all tunables if-else conditionals preserved for raw policy.Note, such option would invalidate the logic to double-check if tunables ever mix with booleans in one expression, so skip the call to
assert()when this option is passed.Quoted 5 lines
Signed-off-by Harry Ciao <[email protected]>Signed-off-by Eric Paris <[email protected]> ---
libsepol/src/expand.c| 36
++++++++++++++++++++++++------------ 1 files changed, 24 insertions(+), 12 deletions(-)
Quoted 9 lines
Hello Dan.
The new option seems not fully enabled yet by parsing the option and setting the
preserve_tunablesflag appropriately inmain().Is it going to be enabled elsewhere ?
Guido
I actually have not started to play with this stuff yet, I am still concerned about the audit2why being able to figure out which boolean/tunable would be able to allow the access. I am fine with it for people who do not care about this technology and just want smaller policy. Meaning I am not sure what we are missing. -----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEARECAAYFAk5zXGUACgkQrlYvE4MpobPf8gCfZAfBBZ32jOxz+fMxZ5d3GgcP RL8An1tuvX6Q2FayFvAJ1jGkbITU3Dpu
=cfic
-----END PGP SIGNATURE-----
--
This message was distributed to subscribers of the selinux mailing list. If you no longer wish to subscribe, send mail to [email protected] with the words "unsubscribe selinux" without quotes as the message.