qxl: Drop phread_yield on OOM

PATCH In review Jan Kiszka 2 participants 2 messages Sep 20, 2011

Share & tools

Jan Kiszka

author

2011-09-20 15:21 UTC #0 lore raw

PATCH 1/1 qxl: Drop phread_yield on OOM

This was only a best-effort attempt, by far not guaranteed to have an effect. Drop it so that also no direct pthread usage remain in the device model.

Signed-off-by Jan Kiszka <[email protected]>

---

Depends on the previous qxl patch I just sent.

 hw/qxl.c |    6 ------
 1 files changed, 0 insertions(+), 6 deletions(-)

hw/qxl.c +0 -6

index 082b940..3e9052f 100644
@@ -18,8 +18,6 @@
  * along with this program; if not, see <http://www.gnu.org/licenses/>.
  */
 
-#include <pthread.h>
-
 #include "qemu-common.h"
 #include "qemu-timer.h"
 #include "qemu-queue.h"

@@ -1215,10 +1213,6 @@ async_common:
         if (!SPICE_RING_IS_EMPTY(&d->ram->release_ring)) {
             break;
         }
-        pthread_yield();
-        if (!SPICE_RING_IS_EMPTY(&d->ram->release_ring)) {
-            break;
-        }
         d->oom_running = 1;
         qxl_spice_oom(d);
         d->oom_running = 0;

Signature · 1 line

1.7.3.4

Gerd Hoffmann

2011-09-20 15:37 UTC #1 lore raw

Quoted 5 lines · Jan Kiszka

This was only a best-effort attempt, by far not guaranteed to have an effect. Drop it so that also no direct pthread usage remain in the device model.
Signed-off-by Jan Kiszka<[email protected]>

All three patches are fine.

I'll go queue it up in the spice queue when I'm back from vacation in 2-3 weeks (unless they find their way upstream through a another tree meanwhile).

cheers,
Gerd