target-i386: Remove redundant word mask in port out instructions

PATCH Applied Jan Kiszka 3 participants 3 messages Sep 26, 2011 – Oct 1, 2011

lore

Share & tools

lore

Jan Kiszka

author

2011-09-26 17:20 UTC #0 lore raw

PATCH 1/1 target-i386: Remove redundant word mask in port out instructions

T0 was already masked to 16 bits when loading it.

Signed-off-by Jan Kiszka <[email protected]>

---
 target-i386/translate.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

target-i386/translate.c +0 -2

index b894e97..1ef8d16 100644
@@ -6116,7 +6116,6 @@ static target_ulong disas_insn(DisasContext *s, target_ulong pc_start)
         if (use_icount)
             gen_io_start();
         tcg_gen_trunc_tl_i32(cpu_tmp2_i32, cpu_T[0]);
-        tcg_gen_andi_i32(cpu_tmp2_i32, cpu_tmp2_i32, 0xffff);
         tcg_gen_trunc_tl_i32(cpu_tmp3_i32, cpu_T[1]);
         gen_helper_out_func(ot, cpu_tmp2_i32, cpu_tmp3_i32);
         if (use_icount) {

@@ -6159,7 +6158,6 @@ static target_ulong disas_insn(DisasContext *s, target_ulong pc_start)
         if (use_icount)
             gen_io_start();
         tcg_gen_trunc_tl_i32(cpu_tmp2_i32, cpu_T[0]);
-        tcg_gen_andi_i32(cpu_tmp2_i32, cpu_tmp2_i32, 0xffff);
         tcg_gen_trunc_tl_i32(cpu_tmp3_i32, cpu_T[1]);
         gen_helper_out_func(ot, cpu_tmp2_i32, cpu_tmp3_i32);
         if (use_icount) {

Signature · 1 line

1.7.3.4

Richard Henderson

Reviewed-by on v1 1/1

2011-09-27 15:20 UTC #1 lore raw

Quoted 3 lines · Jan Kiszka

T0 was already masked to 16 bits when loading it.
Signed-off-by Jan Kiszka <[email protected]>

Reviewed-by Richard Henderson <[email protected]>

Blue Swirl

Applied

2011-10-01 12:05 UTC #2 lore raw

In reply to Jan Kiszka

Thanks, applied.

Quoted 30 lines · Jan Kiszka

T0 was already masked to 16 bits when loading it.

Signed-off-by Jan Kiszka <[email protected]>

---
target-i386/translate.c | 2 --

 1 files changed, 0 insertions(+), 2 deletions(-)

target-i386/translate.c +0 -3

index b894e97..1ef8d16 100644
@@ -6116,7 +6116,6 @@ static target_ulong disas_insn(DisasContext *s, target_ulong pc_start)
         if (use_icount)
             gen_io_start();
         tcg_gen_trunc_tl_i32(cpu_tmp2_i32, cpu_T[0]);
-        tcg_gen_andi_i32(cpu_tmp2_i32, cpu_tmp2_i32, 0xffff);
         tcg_gen_trunc_tl_i32(cpu_tmp3_i32, cpu_T[1]);
         gen_helper_out_func(ot, cpu_tmp2_i32, cpu_tmp3_i32);
         if (use_icount) {

@@ -6159,7 +6158,6 @@ static target_ulong disas_insn(DisasContext *s, target_ulong pc_start)
         if (use_icount)
             gen_io_start();
         tcg_gen_trunc_tl_i32(cpu_tmp2_i32, cpu_T[0]);
-        tcg_gen_andi_i32(cpu_tmp2_i32, cpu_tmp2_i32, 0xffff);
         tcg_gen_trunc_tl_i32(cpu_tmp3_i32, cpu_T[1]);
         gen_helper_out_func(ot, cpu_tmp2_i32, cpu_tmp3_i32);
         if (use_icount) {
--

1.7.3.4