S5K6AAFX sensor driver and a videobuf2 update

PATCH In review Sylwester Nawrocki 3 participants 5 messages Sep 30, 2011 – Oct 6, 2011 Media (V4L/DVB)

lore

Share & tools

lore

Sylwester Nawrocki

author

2011-09-30 16:10 UTC #0 lore raw

PATCH 1/1 S5K6AAFX sensor driver and a videobuf2 update

Hi Mauro,

please pull from
git://git.infradead.org/users/kmpark/linux-2.6-samsung s5k6aafx

for S5K6AAFX sensor subdev driver, a videbuf2 enhancement for non-MMU systems and minor s5p-mfc amendment changing the firmware name to something more generic as the driver supports multiple SoC versions.

The following changes since commit 446b792c6bd87de4565ba200b75a708b4c575a06:

[media] media: DocBook: Fix trivial typo in Sub-device Interface (2011-09-27
09:14:58 -0300)

are available in the git repository at:
git://git.infradead.org/users/kmpark/linux-2.6-samsung s5k6aafx

Sachin Kamat (1):
MFC: Change MFC firmware binary name

Scott Jiang (1):
vb2: add vb2_get_unmapped_area in vb2 core

Sylwester Nawrocki (2):
v4l: Add AUTO option for the V4L2_CID_POWER_LINE_FREQUENCY control
v4l: Add v4l2 subdev driver for S5K6AAFX sensor

 Documentation/DocBook/media/v4l/controls.xml |    5 +-
 drivers/media/video/Kconfig                  |    7 +
 drivers/media/video/Makefile                 |    1 +
 drivers/media/video/s5k6aa.c                 | 1688 ++++++++++++++++++++++++++
 drivers/media/video/s5p-mfc/s5p_mfc_ctrl.c   |    4 +-
 drivers/media/video/v4l2-ctrls.c             |    1 +
 drivers/media/video/videobuf2-core.c         |   31 +
 include/linux/videodev2.h                    |    1 +
 include/media/s5k6aa.h                       |   51 +
 include/media/videobuf2-core.h               |    7 +
 10 files changed, 1792 insertions(+), 4 deletions(-)
 create mode 100644 drivers/media/video/s5k6aa.c
 create mode 100644 include/media/s5k6aa.h

Regards

Signature · 2 lines

Sylwester Nawrocki
Samsung Poland R&D Center

Sakari Ailus

2011-09-30 21:16 UTC #1 lore raw

Hi Sylwester,

Quoted 21 lines · Sylwester Nawrocki

Hi Mauro,
please pull from
git://git.infradead.org/users/kmpark/linux-2.6-samsung s5k6aafx
for S5K6AAFX sensor subdev driver, a videbuf2 enhancement for non-MMU systems and minor s5p-mfc amendment changing the firmware name to something more generic as the driver supports multiple SoC versions.
The following changes since commit 446b792c6bd87de4565ba200b75a708b4c575a06:
[media] media: DocBook: Fix trivial typo in Sub-device Interface (2011-09-27
09:14:58 -0300)
are available in the git repository at:
git://git.infradead.org/users/kmpark/linux-2.6-samsung s5k6aafx
Sachin Kamat (1):
MFC: Change MFC firmware binary name

Quoted 6 lines

Scott Jiang (1):
vb2: add vb2_get_unmapped_area in vb2 core
Sylwester Nawrocki (2):
v4l: Add AUTO option for the V4L2_CID_POWER_LINE_FREQUENCY control
v4l: Add v4l2 subdev driver for S5K6AAFX sensor

I'd like to ask you what's your intention regarding the preset functionality in this driver? My understanding it it isn't provided to user space currently, nor we have such drivers currently (that I know of).

Regards,

Signature · 2 lines

Sakari Ailus
e-mail: [email protected]	jabber/XMPP/Gmail: [email protected]

Sylwester Nawrocki

2011-10-01 09:44 UTC #2 lore raw

Hi Sakari,

Quoted 27 lines · Sakari Ailus

Hi Sylwester,
Quoted 24 lines · Sylwester Nawrocki
Hi Mauro,
please pull from
git://git.infradead.org/users/kmpark/linux-2.6-samsung s5k6aafx
for S5K6AAFX sensor subdev driver, a videbuf2 enhancement for non-MMU systems and minor s5p-mfc amendment changing the firmware name to something more generic as the driver supports multiple SoC versions.
The following changes since commit 446b792c6bd87de4565ba200b75a708b4c575a06:
[media] media: DocBook: Fix trivial typo in Sub-device Interface (2011-09-27
09:14:58 -0300)
are available in the git repository at:
git://git.infradead.org/users/kmpark/linux-2.6-samsung s5k6aafx
Sachin Kamat (1):
MFC: Change MFC firmware binary name
Scott Jiang (1):
vb2: add vb2_get_unmapped_area in vb2 core

Quoted 7 lines

Quoted 3 lines
Sylwester Nawrocki (2):
v4l: Add AUTO option for the V4L2_CID_POWER_LINE_FREQUENCY control
v4l: Add v4l2 subdev driver for S5K6AAFX sensor
I'd like to ask you what's your intention regarding the preset functionality in this driver? My understanding it it isn't provided to user space currently, nor we have such drivers currently (that I know of).

The user configuration register sets present in the device are separated by the driver from user space. So there is no such thing like user-space preset functionality coming with this driver. I think it's pretty clear from the code. Also please see my response to the previous e-mail (v2 thread).
If there is anything that should be fixed in this driver I'd like Mauro to decide about this.

Cheers, S.

Sakari Ailus

2011-10-02 07:36 UTC #3 lore raw

Quoted 1 line · Sylwester Nawrocki

Hi Sakari,

Hi Sylwester,

Quoted 36 lines · Sakari Ailus

Quoted 27 lines
Hi Sylwester,
Quoted 24 lines · Sylwester Nawrocki
Hi Mauro,
please pull from
git://git.infradead.org/users/kmpark/linux-2.6-samsung s5k6aafx
for S5K6AAFX sensor subdev driver, a videbuf2 enhancement for non-MMU systems and minor s5p-mfc amendment changing the firmware name to something more generic as the driver supports multiple SoC versions.
The following changes since commit 446b792c6bd87de4565ba200b75a708b4c575a06:
[media] media: DocBook: Fix trivial typo in Sub-device Interface (2011-09-27
09:14:58 -0300)
are available in the git repository at:
git://git.infradead.org/users/kmpark/linux-2.6-samsung s5k6aafx
Sachin Kamat (1):
MFC: Change MFC firmware binary name
Scott Jiang (1):
vb2: add vb2_get_unmapped_area in vb2 core
Quoted 7 lines
Quoted 3 lines
Sylwester Nawrocki (2):
v4l: Add AUTO option for the V4L2_CID_POWER_LINE_FREQUENCY control
v4l: Add v4l2 subdev driver for S5K6AAFX sensor
I'd like to ask you what's your intention regarding the preset functionality in this driver? My understanding it it isn't provided to user space currently, nor we have such drivers currently (that I know of).

Quoted 6 lines

The user configuration register sets present in the device are separated by the driver from user space. So there is no such thing like user-space preset functionality coming with this driver. I think it's pretty clear from the code. Also please see my response to the previous e-mail (v2 thread).
If there is anything that should be fixed in this driver I'd like Mauro to decide about this.

Agreed; the preset functionality isn't shown to the user space. The sensor implements it and in my understanding some sensor features (not implemented in the driver) like flash strobe timing requires it.

We should discuss at some point how to best support sensors like this, but I don't think it has to be now.

I see no reason why this patch (v4l: Add v4l2 subdev driver for S5K6AAFX sensor) shouldn't go in right now.

Regards,

Signature · 2 lines

Sakari Ailus
e-mail: [email protected]	jabber/XMPP/Gmail: [email protected]

Sylwester Nawrocki

2011-10-06 20:08 UTC #4 lore raw

Hi Sakari,

Quoted 42 lines · Sakari Ailus

Quoted 34 lines · Sylwester Nawrocki
Quoted 25 lines · Sakari Ailus
Quoted 24 lines · Sylwester Nawrocki
Hi Mauro,
please pull from
git://git.infradead.org/users/kmpark/linux-2.6-samsung s5k6aafx
for S5K6AAFX sensor subdev driver, a videbuf2 enhancement for non-MMU systems and minor s5p-mfc amendment changing the firmware name to something more generic as the driver supports multiple SoC versions.
The following changes since commit 446b792c6bd87de4565ba200b75a708b4c575a06:
[media] media: DocBook: Fix trivial typo in Sub-device Interface (2011-09-27
09:14:58 -0300)
are available in the git repository at:
git://git.infradead.org/users/kmpark/linux-2.6-samsung s5k6aafx
Sachin Kamat (1):
MFC: Change MFC firmware binary name
Scott Jiang (1):
vb2: add vb2_get_unmapped_area in vb2 core
Quoted 7 lines
Quoted 3 lines
Sylwester Nawrocki (2):
v4l: Add AUTO option for the V4L2_CID_POWER_LINE_FREQUENCY control
v4l: Add v4l2 subdev driver for S5K6AAFX sensor
I'd like to ask you what's your intention regarding the preset functionality in this driver? My understanding it it isn't provided to user space currently, nor we have such drivers currently (that I know of).
Quoted 6 lines
The user configuration register sets present in the device are separated by the driver from user space. So there is no such thing like user-space preset functionality coming with this driver. I think it's pretty clear from the code. Also please see my response to the previous e-mail (v2 thread).
If there is anything that should be fixed in this driver I'd like Mauro to decide about this.

Quoted 3 lines

Agreed; the preset functionality isn't shown to the user space. The sensor implements it and in my understanding some sensor features (not implemented in the driver) like flash strobe timing requires it.

Yes, that's exactly right.

Quoted 6 lines

We should discuss at some point how to best support sensors like this, but I don't think it has to be now.
I see no reason why this patch (v4l: Add v4l2 subdev driver for S5K6AAFX sensor) shouldn't go in right now.

Thanks.

Sylwester