Skip to contentSkip to conversation

Add test showing git-fetch groks gitfiles

PATCH In review Phil Hord 2 participants 2 messages Jun 15, 2016

lore
Share & tools
lore

Phil Hord

author
#0 lore raw

PATCH v3 5/5 Add test showing git-fetch groks gitfiles

Add a test for two subtly different cases: 'git fetch path/.git' and 'git fetch path' to confirm that transport recognizes both paths as git repositories when using the gitfile mechanism.

t/t5601-clone.sh +14 -0
index e810314..87ee016 100755
@@ -206,6 +206,20 @@ test_expect_success 'clone from .git file' '
 	git clone dst/.git dst2
 '
 
+test_expect_success 'fetch from .git gitfile' '
+	(
+		cd dst2 &&
+		git fetch ../dst/.git
+	)
+'
+
+test_expect_success 'fetch from gitfile parent' '
+	(
+		cd dst2 &&
+		git fetch ../dst
+	)
+'
+
 test_expect_success 'clone separate gitdir where target already exists' '
 	rm -rf dst &&
 	test_must_fail git clone --separate-git-dir realgitdir src dst
Signature · 1 line
1.7.7.505.ga09f6
#1 lore raw
Quoted 3 lines · Phil Hord

Add a test for two subtly different cases: 'git fetch path/.git' and 'git fetch path' to confirm that transport recognizes both paths as git repositories when using the gitfile mechanism.

It'd be interesting to test failed cases too. I can think of two: .git file is not a valid file and .git points to an invalid repo.

Signature · 1 line
Duy