Skip to contentSkip to conversation

ALSA: hda - Fix a regression of the position-buffer check

DISCUSSION David Henningsson 2 participants 3 messages Oct 7, 2011 – Oct 9, 2011

lore
Share & tools
lore
#0 lore raw

Hi Takashi,

The offending commit a810364a042 seems to be in v3.0-rc2 (according to git describe), so is there a reason why the below is not sent to 3.0 stable tree?

commit 798cb7e897210dbf827f69a302c0967e0380ebac
Author: Takashi Iwai <[email protected]>
Date: Fri Sep 30 08:52:26 2011 +0200

ALSA: hda - Fix a regression of the position-buffer check

The commit a810364a0424c297242c6c66071a42f7675a5568
ALSA: hda - Handle -1 as invalid position, too
caused a regression on some machines that require the position-buffer instead of LPIB, e.g. resulting in noises with mic recording with PulseAudio.

Signature · 2 lines
David Henningsson, Canonical Ltd.
http://launchpad.net/~diwic
#1 lore raw

At Fri, 07 Oct 2011 21:39:54 +0200,

Quoted 5 lines · David Henningsson

Hi Takashi,

The offending commit a810364a042 seems to be in v3.0-rc2 (according to git describe),

No, it's in 3.1-rc2.

% git describe --contains a810364a
v3.1-rc2~4^2~47^2~88

Takashi

Quoted 19 lines

so is there a reason why the below is not sent to 3.0 stable tree?

commit 798cb7e897210dbf827f69a302c0967e0380ebac
Author: Takashi Iwai <[email protected]>
Date: Fri Sep 30 08:52:26 2011 +0200

ALSA: hda - Fix a regression of the position-buffer check

The commit a810364a0424c297242c6c66071a42f7675a5568
ALSA: hda - Handle -1 as invalid position, too
caused a regression on some machines that require the position-buffer instead of LPIB, e.g. resulting in noises with mic recording with PulseAudio.

Signature · 2 lines
David Henningsson, Canonical Ltd.
http://launchpad.net/~diwic
#2 lore raw
Quoted 5 lines · Takashi Iwai

At Fri, 07 Oct 2011 21:39:54 +0200,

Quoted 3 lines · David Henningsson

Hi Takashi,

Quoted 7 lines
Quoted 2 lines

The offending commit a810364a042 seems to be in v3.0-rc2 (according to git describe),

No, it's in 3.1-rc2.

% git describe --contains a810364a
v3.1-rc2~4^2~47^2~88

Sorry for the fuzz. I stand corrected.

Signature · 2 lines
David Henningsson, Canonical Ltd.
http://launchpad.net/~diwic